Merge pull request #110 from prgrms-web-devcourse-final-project/feature/EA3-122-study-crud

[EA3-122] refactor: BusinessException 메서드 변경

Author: hyeunS-P

src/main/java/grep/neogul_coder/domain/prtemplate/service/PrTemplateService.java

@@ -40,20 +40,20 @@ public void deleteByUserId(Long userId) {
 
     public void update(Long id, String location) {
         PrTemplate prTemplate = prTemplateRepository.findById(id).orElseThrow(
-            () -> new NotFoundException(PrTemplateErrorCode.TEMPLATE_NOT_FOUND, "템플릿이 존재하지 않습니다."));
+            () -> new NotFoundException(PrTemplateErrorCode.TEMPLATE_NOT_FOUND));
         prTemplate.update(location);
     }
 
     public void updateIntroduction(Long id, String introduction) {
         PrTemplate prTemplate = prTemplateRepository.findById(id).orElseThrow(
-            () -> new NotFoundException(PrTemplateErrorCode.TEMPLATE_NOT_FOUND, "템플릿이 존재하지 않습니다."));
+            () -> new NotFoundException(PrTemplateErrorCode.TEMPLATE_NOT_FOUND));
         prTemplate.updateIntroduction(introduction);
     }
 
     public PrPageResponse toResponse(Long userId) {
 
         User user = userRepository.findById(userId).orElseThrow(() -> new NotFoundException(
-            UserErrorCode.USER_NOT_FOUND, "회원이 존재하지 않습니다."));
+            UserErrorCode.USER_NOT_FOUND));
         PrTemplate prTemplate = prTemplateRepository.findByUserId(userId);
         List<Link> links = linkRepository.findAllByPrIdAndActivatedTrue(prTemplate.getId());
         List<ReviewEntity> reviews = reviewRepository.findAllByTargetUserId(userId);
@@ -94,7 +94,7 @@ public PrPageResponse toResponse(Long userId) {
             .limit(5)
             .map(review -> {
                 User writer = userRepository.findById(review.getWriteUserId())
-                    .orElseThrow(() -> new NotFoundException(UserErrorCode.USER_NOT_FOUND, "작성자를 찾을 수 없습니다."));
+                    .orElseThrow(() -> new NotFoundException(UserErrorCode.USER_NOT_FOUND));
                 return PrPageResponse.ReviewContentDto.builder()
                     .reviewUserId(writer.getId())
                     .reviewUserImgUrl(writer.getProfileImageUrl())

src/main/java/grep/neogul_coder/domain/recruitment/post/service/RecruitmentPostService.java

@@ -52,10 +52,10 @@ public void delete(long recruitmentPostId, long userId) {
 
     private RecruitmentPost findRecruitmentPost(long recruitmentPostId, long userId) {
         RecruitmentPost recruitmentPost = recruitmentPostRepository.findById(recruitmentPostId)
-                .orElseThrow(() -> new NotFoundException(NOT_FOUND, NOT_FOUND.getMessage()));
+                .orElseThrow(() -> new NotFoundException(NOT_FOUND));
 
         if (recruitmentPost.isNotOwnedBy(userId)) {
-            throw new BusinessException(NOT_OWNER, NOT_OWNER.getMessage());
+            throw new BusinessException(NOT_OWNER);
         }
         return recruitmentPost;
     }

src/main/java/grep/neogul_coder/domain/review/ReviewTags.java

@@ -30,7 +30,7 @@ public ReviewType ensureSingleReviewType() {
                 .anyMatch(tag -> firstReviewType.isNotSameType(tag.getReviewType()));
 
         if (hasNotSingleType) {
-            throw new BusinessException(NOT_SINGLE_REVIEW_TYPE, NOT_SINGLE_REVIEW_TYPE.getMessage());
+            throw new BusinessException(NOT_SINGLE_REVIEW_TYPE);
         }
         return firstReviewType;
     }

src/main/java/grep/neogul_coder/domain/review/service/ReviewService.java

@@ -59,7 +59,7 @@ public ReviewTargetUsersInfo getReviewTargetUsersInfo(long studyId, String myNic
     @Transactional
     public void save(ReviewSaveServiceRequest request, long writeUserId) {
         if(isAlreadyWrittenReviewBy(request.getStudyId(), request.getTargetUserId(), writeUserId)){
-            throw new BusinessException(ALREADY_REVIEW_WRITE_USER, ALREADY_REVIEW_WRITE_USER.getMessage());
+            throw new BusinessException(ALREADY_REVIEW_WRITE_USER);
         }
 
         Study study = findValidStudy(request.getStudyId());
@@ -91,14 +91,14 @@ public ReviewContentsPagingInfo getMyReviewContents(Pageable pageable, long user
 
     private Study findValidStudy(long studyId){
         return studyRepository.findById(studyId)
-                .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND, STUDY_NOT_FOUND.getMessage()));
+                .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND));
     }
 
     private List<StudyMember> findValidStudyMember(long studyId) {
         List<StudyMember> studyMembers = studyMemberRepository.findByStudyIdFetchStudy(studyId);
 
         if (studyMembers.isEmpty()) {
-            throw new NotFoundException(STUDY_MEMBER_EMPTY, STUDY_MEMBER_EMPTY.getMessage());
+            throw new NotFoundException(STUDY_MEMBER_EMPTY);
         }
         return studyMembers;
     }

src/main/java/grep/neogul_coder/domain/study/exception/NotStudyLeaderException.java

@@ -5,7 +5,7 @@
 
 public class NotStudyLeaderException extends BusinessException {
 
-    public NotStudyLeaderException(ErrorCode errorCode, String message) {
-        super(errorCode, message);
+    public NotStudyLeaderException(ErrorCode errorCode) {
+        super(errorCode);
     }
 }

src/main/java/grep/neogul_coder/domain/study/service/StudyService.java

@@ -34,7 +34,7 @@ public List<StudyItemResponse> getMyStudies(Long userId) {
 
     public StudyHeaderResponse getStudyHeader(Long studyId) {
         Study study = studyRepository.findById(studyId)
-            .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND, STUDY_NOT_FOUND.getMessage()));
+            .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND));
 
         return StudyHeaderResponse.from(study);
     }
@@ -49,11 +49,11 @@ public List<StudyImageResponse> getStudyImages(Long userId) {
 
     public StudyInfoResponse getStudyInfo(Long studyId, Long userId) {
         Study study = studyRepository.findById(studyId)
-            .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND, STUDY_NOT_FOUND.getMessage()));
+            .orElseThrow(() -> new NotFoundException(STUDY_NOT_FOUND));
 
         StudyMemberRole role = studyQueryRepository.findMyRole(studyId, userId);
         if (!role.equals(LEADER)) {
-            throw new NotStudyLeaderException(STUDY_NOT_LEADER, STUDY_NOT_FOUND.getMessage());
+            throw new NotStudyLeaderException(STUDY_NOT_LEADER);
         }
 
         List<StudyMemberResponse> members = studyQueryRepository.findStudyMembers(studyId);

src/main/java/grep/neogul_coder/domain/users/service/UserService.java

@@ -95,13 +95,13 @@ public void deleteUser(Long id, String password) {
     private User findUser(Long id) {
         return userRepository.findById(id)
             .orElseThrow(
-                () -> new NotFoundException(UserErrorCode.USER_NOT_FOUND, "회원이 존재하지 않습니다."));
+                () -> new NotFoundException(UserErrorCode.USER_NOT_FOUND));
     }
 
     private User findUser(String email) {
         return userRepository.findByEmail(email)
             .orElseThrow(
-                () -> new NotFoundException(UserErrorCode.USER_NOT_FOUND, "회원이 존재하지 않습니다."));
+                () -> new NotFoundException(UserErrorCode.USER_NOT_FOUND));
     }
 
     private boolean duplicationCheck(String email, String nickname) {

src/main/java/grep/neogul_coder/global/exception/business/BusinessException.java

@@ -6,8 +6,8 @@ public class BusinessException extends RuntimeException {
 
     private ErrorCode errorCode;
 
-    public BusinessException(ErrorCode errorCode, String message) {
-        super(message);
+    public BusinessException(ErrorCode errorCode) {
+        super(errorCode.getMessage());
         this.errorCode = errorCode;
     }
 

src/main/java/grep/neogul_coder/global/exception/business/NotFoundException.java

@@ -3,7 +3,7 @@
 import grep.neogul_coder.global.response.code.ErrorCode;
 
 public class NotFoundException extends BusinessException{
-    public NotFoundException(ErrorCode errorcode, String message) {
-        super(errorcode, message);
+    public NotFoundException(ErrorCode errorcode) {
+        super(errorcode);
     }
 }