Skip to content

Commit b73dcbf

Browse files
committed
fix: 순환 참조 해결 및 BaseEntity activated boolean 수정
1 parent 4760dab commit b73dcbf

File tree

8 files changed

+102
-97
lines changed

8 files changed

+102
-97
lines changed

src/main/java/grep/neogul_coder/domain/admin/controller/dto/response/AdminRecruitmentPostResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public static AdminRecruitmentPostResponse from(RecruitmentPost post) {
2929
.id(post.getId())
3030
.subject(post.getSubject())
3131
.expiredDate(post.getExpiredDate())
32-
.activated(post.getActivated())
32+
.activated(post.isActivated())
3333
.build();
3434
}
3535

src/main/java/grep/neogul_coder/domain/admin/controller/dto/response/AdminStudyResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public static AdminStudyResponse from(Study study) {
4343
.name(study.getName())
4444
.category(study.getCategory())
4545
.isFinished(study.isFinished())
46-
.activated(study.getActivated())
46+
.activated(study.isActivated())
4747
.build();
4848
}
4949

src/main/java/grep/neogul_coder/domain/admin/controller/dto/response/AdminUserResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static AdminUserResponse from(User user) {
3434
user.getId(),
3535
user.getEmail(),
3636
user.getNickname(),
37-
user.getActivated()
37+
user.isActivated()
3838
);
3939
}
4040

src/main/java/grep/neogul_coder/domain/users/service/EmailVerificationService.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import grep.neogul_coder.domain.users.exception.EmailDuplicationException;
77
import grep.neogul_coder.domain.users.exception.code.UserErrorCode;
8+
import grep.neogul_coder.domain.users.repository.UserRepository;
89
import lombok.RequiredArgsConstructor;
910
import org.springframework.data.redis.core.RedisTemplate;
1011
import org.springframework.mail.SimpleMailMessage;
@@ -17,13 +18,13 @@ public class EmailVerificationService {
1718

1819
private final JavaMailSender mailSender;
1920
private final RedisTemplate<String, Object> redisTemplate;
20-
private final UserService userService;
21+
private final UserRepository userRepository;
2122

2223
private static final long CODE_TTL_SECONDS = 300;
2324

2425
public void sendVerificationEmail(String email) {
2526

26-
if(userService.isDuplicateEmail(email)) {
27+
if(isDuplicateEmail(email)) {
2728
throw new EmailDuplicationException(UserErrorCode.IS_DUPLICATED_MALI);
2829
}
2930

@@ -77,6 +78,10 @@ private String getVerifiedKey(String email) {
7778
return "email_verified:" + email;
7879
}
7980

81+
private boolean isDuplicateEmail(String email) {
82+
return userRepository.findByEmail(email).isPresent();
83+
}
84+
8085
private boolean isValidCode(Object storedCode, String inputCode) {
8186
return storedCode != null && storedCode.equals(inputCode);
8287
}

src/main/java/grep/neogul_coder/domain/users/service/UserService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private void duplicationCheck(String email, String nickname) {
190190
}
191191
}
192192

193-
public boolean isDuplicateEmail(String email) {
193+
private boolean isDuplicateEmail(String email) {
194194
return userRepository.findByEmail(email).isPresent();
195195
}
196196

src/main/java/grep/neogul_coder/global/auth/service/AuthService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public TokenDto processOAuthSignin(OAuth2UserInfo userInfo, String roles) {
117117
private boolean isUnactivatedUser(String email) {
118118
return !usersRepository.findByEmail(email)
119119
.orElseThrow(() -> new UserNotFoundException(UserErrorCode.USER_NOT_FOUND))
120-
.getActivated();
120+
.isActivated();
121121
}
122122

123123
private boolean isGoogleUser(String email) {

src/main/java/grep/neogul_coder/global/entity/BaseEntity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
@EntityListeners(AuditingEntityListener.class)
1515
public class BaseEntity {
1616

17-
protected Boolean activated = true;
17+
protected boolean activated = true;
1818

1919
@CreatedDate
2020
protected LocalDateTime createdDate = LocalDateTime.now();

src/main/resources/data.sql

Lines changed: 89 additions & 89 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)