[EA3-143] refactor:PR 피드백 적용 리팩터링

Author: hyeunS-P

src/main/java/grep/neogul_coder/domain/prtemplate/entity/Link.java

@@ -1,5 +1,6 @@
 package grep.neogul_coder.domain.prtemplate.entity;
 
+import grep.neogul_coder.domain.prtemplate.controller.dto.request.LinkUpdateRequest;
 import grep.neogul_coder.global.entity.BaseEntity;
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
@@ -40,6 +41,11 @@ public static Link LinkInit(Long prId, String prUrl, String urlName) {
             .build();
     }
 
+    public static boolean isRequestLinkEmpty(LinkUpdateRequest request) {
+        String prUrl = request.getPrUrl();
+        return prUrl == null || prUrl.isBlank();
+    }
+
     protected Link() {
     }
 

src/main/java/grep/neogul_coder/domain/prtemplate/service/LinkService.java

@@ -3,6 +3,8 @@
 import grep.neogul_coder.domain.prtemplate.controller.dto.request.LinkUpdateRequest;
 import grep.neogul_coder.domain.prtemplate.entity.Link;
 import grep.neogul_coder.domain.prtemplate.repository.LinkRepository;
+import grep.neogul_coder.domain.quiz.exception.code.QuizErrorCode;
+import grep.neogul_coder.global.exception.business.BusinessException;
 import jakarta.transaction.Transactional;
 import java.util.List;
 import lombok.RequiredArgsConstructor;
@@ -26,7 +28,7 @@ public void update(Long userId, List<LinkUpdateRequest> requests) {
         List<Link> links = linkRepository.findAllByUserId(userId);
 
         if (requests.size() != 2) {
-            throw new IllegalArgumentException("링크는 정확히 2개가 전달되어야 합니다.");
+            throw new BusinessException(QuizErrorCode.NEED_CORRECT_COUNT);
         }
 
         for (int i = 0; i < links.size(); i++) {
@@ -35,7 +37,7 @@ public void update(Long userId, List<LinkUpdateRequest> requests) {
     }
 
     private void applyRequestToLink(Link link, LinkUpdateRequest request) {
-        if (isRequestLinkEmpty(request)) {
+        if (Link.isRequestLinkEmpty(request)) {
             link.delete();
         } else {
             link.updateUrlName(request.getUrlName());
@@ -44,9 +46,4 @@ private void applyRequestToLink(Link link, LinkUpdateRequest request) {
         }
     }
 
-    private boolean isRequestLinkEmpty(LinkUpdateRequest request) {
-        String prUrl = request.getPrUrl();
-        return prUrl == null || prUrl.isBlank();
-    }
-
-}
+}

src/main/java/grep/neogul_coder/domain/quiz/controller/AiQuizController.java

@@ -28,13 +28,14 @@ public class AiQuizController implements AiQuizSpecification {
 
     @GetMapping("/{postId}")
     public ApiResponse<QuizResponse> get(@PathVariable("postId") Long postId) {
+
         StudyPost post = studyPostService.findById(postId);
+
         if (!Category.FREE.equals((post.getCategory()))) {
             throw new PostNotFreeException(QuizErrorCode.POST_NOT_FREE_ERROR);
         }
 
         Optional<Quiz> quiz = aiQuizRepository.findByPostId(postId);
-
         if (quiz.isPresent()) {
             Quiz q = quiz.get();
             QuizResponse quizResponse = QuizResponse.toResponse(q.getQuizContent(), q.isQuizAnswer());
@@ -45,4 +46,4 @@ public ApiResponse<QuizResponse> get(@PathVariable("postId") Long postId) {
         return ApiResponse.success(quizResponse);
     }
 
-}
+}

src/main/java/grep/neogul_coder/domain/quiz/controller/dto/response/QuizResponse.java

@@ -3,8 +3,10 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.Builder;
 import lombok.Data;
+import lombok.Getter;
 
 @Schema(description = "퀴즈 응답 DTO")
+@Getter
 @Data
 public class QuizResponse {
 

src/main/java/grep/neogul_coder/domain/quiz/entity/Quiz.java

@@ -17,13 +17,10 @@ public class Quiz extends BaseEntity {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    @NotNull
     private Long postId;
 
-    @NotNull
     private String quizContent;
 
-    @NotNull
     private boolean quizAnswer;
 
     @Builder

src/main/java/grep/neogul_coder/domain/quiz/exception/code/QuizErrorCode.java

@@ -2,13 +2,15 @@
 
 import grep.neogul_coder.global.response.code.ErrorCode;
 import lombok.Getter;
+import org.springframework.boot.autoconfigure.graphql.GraphQlProperties.Http;
 import org.springframework.http.HttpStatus;
 
 @Getter
 public enum QuizErrorCode implements ErrorCode {
 
     POST_NOT_FREE_ERROR("Q001",HttpStatus.BAD_REQUEST,"자유 게시글이 아닙니다."),
-    QUIZ_NOT_FOUND("Q002",HttpStatus.NOT_FOUND,"퀴즈가 없습니다.");
+    QUIZ_NOT_FOUND("Q002",HttpStatus.NOT_FOUND,"퀴즈가 없습니다."),
+    NEED_CORRECT_COUNT("Q003", HttpStatus.BAD_REQUEST,"요청 개수가 정확하지 않습니다.");
 
     private final String code;
     private final HttpStatus status;

src/main/java/grep/neogul_coder/domain/quiz/service/AiQuizServiceImpl.java

@@ -3,6 +3,8 @@
 import grep.neogul_coder.domain.quiz.controller.dto.response.QuizResponse;
 import grep.neogul_coder.domain.quiz.entity.Quiz;
 import grep.neogul_coder.domain.quiz.repository.AiQuizRepository;
+import grep.neogul_coder.global.response.ApiResponse;
+import java.util.Optional;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -31,4 +33,4 @@ public QuizResponse createAndSaveQuiz(Long postId, String postContent) {
 
     }
 
-}
+}

src/main/java/grep/neogul_coder/domain/studypost/exception/code/PostErrorCode.java

@@ -9,8 +9,6 @@ public enum PostErrorCode implements ErrorCode {
 
     POST_NOT_FOUND("P001",HttpStatus.BAD_REQUEST,"게시글을 찾을 수 없습니다.");
 
-
-
     private final String code;
     private final HttpStatus status;
     private final String message;
@@ -21,7 +19,4 @@ public enum PostErrorCode implements ErrorCode {
         this.message = message;
     }
 
-
-
-
-}
+}