Skip to content

Commit 9615728

Browse files
committed
refactor: dto -> record로 수정 및 그에 따른 서비스, 컨트롤러, 매퍼 변환
1 parent 716795f commit 9615728

File tree

8 files changed

+38
-42
lines changed

8 files changed

+38
-42
lines changed

src/main/java/com/threestar/trainus/domain/review/controller/ReviewController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public ResponseEntity<PagedResponse<ReviewPageWrapperDto>> readAll(@PathVariable
5555
int correctPageSize = Math.max(1, Math.min(pageSize, pageSizeLimit));
5656
ReviewPageResponseDto reviewsInfo = reviewService.readAll(userId, correctPage, correctPageSize);
5757
ReviewPageWrapperDto reviews = ReviewMapper.toReviewPageWrapperDto(reviewsInfo);
58-
return PagedResponse.ok("조회가 완료됐습니다.", reviews, reviewsInfo.getCount(), HttpStatus.OK);
58+
return PagedResponse.ok("조회가 완료됐습니다.", reviews, reviewsInfo.count(), HttpStatus.OK);
5959
}
6060
/*
6161
* TODO:구조 통일
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package com.threestar.trainus.domain.review.dto;
22

33
import jakarta.validation.constraints.NotNull;
4-
import lombok.Data;
54

6-
@Data
7-
public class ReviewCreateRequestDto {
8-
private String content;
5+
public record ReviewCreateRequestDto(
6+
String content,
97
@NotNull(message = "점수는 필수입니다.")
10-
private Double rating;
11-
private String reviewImage;
8+
Double rating,
9+
String reviewImage
10+
) {
11+
1212
}
Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package com.threestar.trainus.domain.review.dto;
22

33
import lombok.Builder;
4-
import lombok.Getter;
54

6-
@Getter
75
@Builder
8-
public class ReviewCreateResponseDto {
9-
private Long reviewId;
10-
private String content;
11-
private Double rating;
12-
private String reviewImage;
6+
public record ReviewCreateResponseDto(
7+
Long reviewId,
8+
String content,
9+
Double rating,
10+
String reviewImage
11+
) {
1312
}

src/main/java/com/threestar/trainus/domain/review/dto/ReviewPageResponseDto.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@
33
import java.util.List;
44

55
import lombok.Builder;
6-
import lombok.Getter;
76

8-
@Getter
97
@Builder
10-
public class ReviewPageResponseDto {
11-
private Long userId;
12-
private Integer count;
13-
private List<ReviewViewResponseDto> reviews;
8+
public record ReviewPageResponseDto(
9+
Long userId,
10+
Integer count,
11+
List<ReviewViewResponseDto> reviews
12+
) {
1413
}

src/main/java/com/threestar/trainus/domain/review/dto/ReviewPageWrapperDto.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
import java.util.List;
44

55
import lombok.Builder;
6-
import lombok.Getter;
76

8-
@Getter
97
@Builder
10-
public class ReviewPageWrapperDto {
11-
private Long userId;
12-
private List<ReviewViewResponseDto> reviews;
8+
public record ReviewPageWrapperDto(
9+
Long userId,
10+
List<ReviewViewResponseDto> reviews
11+
) {
1312
}

src/main/java/com/threestar/trainus/domain/review/dto/ReviewViewResponseDto.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,17 @@
33
import java.time.LocalDateTime;
44

55
import lombok.Builder;
6-
import lombok.Getter;
76

8-
@Getter
97
@Builder
10-
public class ReviewViewResponseDto {
11-
private Long reviewId;
12-
private Long lessonId;
13-
private String lessonName;
14-
private Long reviewerId;
15-
private String reviewerNickname;
16-
private String reviewImage;
17-
private String content;
18-
private Double rating;
19-
private LocalDateTime createdAt;
8+
public record ReviewViewResponseDto(
9+
Long reviewId,
10+
Long lessonId,
11+
String lessonName,
12+
Long reviewerId,
13+
String reviewerNickname,
14+
String reviewImage,
15+
String content,
16+
Double rating,
17+
LocalDateTime createdAt
18+
) {
2019
}

src/main/java/com/threestar/trainus/domain/review/mapper/ReviewMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public static ReviewPageResponseDto toReviewPageResponseDto(Long userId, List<Re
4747

4848
public static ReviewPageWrapperDto toReviewPageWrapperDto(ReviewPageResponseDto reviewPageResponseDto) {
4949
return ReviewPageWrapperDto.builder()
50-
.reviews(reviewPageResponseDto.getReviews())
50+
.reviews(reviewPageResponseDto.reviews())
5151
.build();
5252
}
5353
}

src/main/java/com/threestar/trainus/domain/review/service/ReviewService.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ public ReviewCreateResponseDto createReview(ReviewCreateRequestDto reviewRequest
6363
.reviewer(findUser)
6464
.reviewee(lessonLeader)
6565
.lesson(findLesson)
66-
.content(reviewRequestDto.getContent())
67-
.rating(reviewRequestDto.getRating())
68-
.image(reviewRequestDto.getReviewImage())
66+
.content(reviewRequestDto.content())
67+
.rating(reviewRequestDto.rating())
68+
.image(reviewRequestDto.reviewImage())
6969
.build());
7070

71-
profileMetadataService.increaseReviewCountAndRating(lessonLeader.getId(), reviewRequestDto.getRating());
71+
profileMetadataService.increaseReviewCountAndRating(lessonLeader.getId(), reviewRequestDto.rating());
7272
return ReviewMapper.toReviewResponseDto(newReview);
7373
}
7474

0 commit comments

Comments
 (0)