Skip to content

Commit 0b2689e

Browse files
author
github-actions
committed
chore: Java 스타일 수정
1 parent e9a5a38 commit 0b2689e

File tree

10 files changed

+47
-39
lines changed

10 files changed

+47
-39
lines changed

backend/src/main/java/io/f1/backend/domain/game/app/GameService.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionStartResponse;
44
import static io.f1.backend.domain.quiz.mapper.QuizMapper.toGameStartResponse;
55

6-
import io.f1.backend.domain.game.dto.GameStartData;
76
import io.f1.backend.domain.game.dto.MessageType;
8-
import io.f1.backend.domain.game.dto.response.GameStartResponse;
9-
import io.f1.backend.domain.game.dto.response.QuestionStartResponse;
107
import io.f1.backend.domain.game.event.RoomUpdatedEvent;
118
import io.f1.backend.domain.game.model.Player;
129
import io.f1.backend.domain.game.model.Room;
@@ -21,7 +18,6 @@
2118
import io.f1.backend.global.exception.errorcode.GameErrorCode;
2219
import io.f1.backend.global.exception.errorcode.RoomErrorCode;
2320

24-
import java.time.Instant;
2521
import lombok.RequiredArgsConstructor;
2622

2723
import org.springframework.context.ApplicationEventPublisher;
@@ -44,7 +40,6 @@ public class GameService {
4440
private final RoomRepository roomRepository;
4541
private final ApplicationEventPublisher eventPublisher;
4642

47-
4843
public void gameStart(Long roomId, UserPrincipal principal) {
4944

5045
String destination = getDestination(roomId);
@@ -69,8 +64,10 @@ public void gameStart(Long roomId, UserPrincipal principal) {
6964
timerService.startTimer(room, START_DELAY);
7065

7166
messageSender.send(destination, MessageType.GAME_START, toGameStartResponse(questions));
72-
messageSender.send(destination, MessageType.QUESTION_START, toQuestionStartResponse(room, START_DELAY));
73-
67+
messageSender.send(
68+
destination,
69+
MessageType.QUESTION_START,
70+
toQuestionStartResponse(room, START_DELAY));
7471
}
7572

7673
private boolean validateReadyStatus(Room room) {

backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import static io.f1.backend.domain.game.mapper.RoomMapper.toGameSettingResponse;
66
import static io.f1.backend.domain.game.mapper.RoomMapper.toPlayerListResponse;
77
import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionResultResponse;
8-
import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionStartResponse;
98
import static io.f1.backend.domain.game.mapper.RoomMapper.toRankUpdateResponse;
109
import static io.f1.backend.domain.game.mapper.RoomMapper.toRoomResponse;
1110
import static io.f1.backend.domain.game.mapper.RoomMapper.toRoomSetting;
@@ -66,7 +65,6 @@ public class RoomService {
6665

6766
private final MessageSender messageSender;
6867

69-
7068
private static final int START_DELAY = 5;
7169
private static final int CONTINUE_DELAY = 3;
7270

@@ -263,7 +261,7 @@ public void chat(Long roomId, String sessionId, ChatMessage chatMessage) {
263261
timerService.cancelTimer(room);
264262

265263
// TODO : 게임 종료 로직 추가
266-
if(!timerService.validateCurrentRound(room)) {
264+
if (!timerService.validateCurrentRound(room)) {
267265
// 게임 종료 로직
268266
return;
269267
}
@@ -272,7 +270,6 @@ public void chat(Long roomId, String sessionId, ChatMessage chatMessage) {
272270

273271
// 타이머 추가하기
274272
timerService.startTimer(room, CONTINUE_DELAY);
275-
276273
}
277274

278275
private Player getRemovePlayer(Room room, String sessionId, UserPrincipal principal) {

backend/src/main/java/io/f1/backend/domain/game/app/TimerService.java

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,19 @@
33
import static io.f1.backend.domain.game.mapper.RoomMapper.ofPlayerEvent;
44
import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionResultResponse;
55
import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionStartResponse;
6-
import static io.f1.backend.domain.game.mapper.RoomMapper.toRankUpdateResponse;
76

87
import io.f1.backend.domain.game.dto.MessageType;
98
import io.f1.backend.domain.game.dto.RoomEventType;
109
import io.f1.backend.domain.game.model.Room;
1110
import io.f1.backend.domain.game.websocket.MessageSender;
12-
import java.util.concurrent.ScheduledFuture;
13-
import java.util.concurrent.TimeUnit;
11+
1412
import lombok.RequiredArgsConstructor;
13+
1514
import org.springframework.stereotype.Service;
1615

16+
import java.util.concurrent.ScheduledFuture;
17+
import java.util.concurrent.TimeUnit;
18+
1719
@Service
1820
@RequiredArgsConstructor
1921
public class TimerService {
@@ -26,20 +28,31 @@ public class TimerService {
2628
public void startTimer(Room room, int delaySec) {
2729
cancelTimer(room);
2830
ScheduledFuture<?> timer = room.getTimer();
29-
timer = room.getScheduler().schedule(() -> {
30-
handleTimeout(room);
31-
}, delaySec + room.getGameSetting().getTimeLimit(), TimeUnit.SECONDS);
31+
timer =
32+
room.getScheduler()
33+
.schedule(
34+
() -> {
35+
handleTimeout(room);
36+
},
37+
delaySec + room.getGameSetting().getTimeLimit(),
38+
TimeUnit.SECONDS);
3239
}
3340

3441
private void handleTimeout(Room room) {
3542

3643
String destination = getDestination(room.getId());
3744

38-
messageSender.send(destination, MessageType.QUESTION_RESULT, toQuestionResultResponse(NONE_CORRECT_USER, room.getCurrentQuestion().getAnswer()));
39-
messageSender.send(destination, MessageType.SYSTEM_NOTICE, ofPlayerEvent(NONE_CORRECT_USER, RoomEventType.TIMEOUT));
45+
messageSender.send(
46+
destination,
47+
MessageType.QUESTION_RESULT,
48+
toQuestionResultResponse(NONE_CORRECT_USER, room.getCurrentQuestion().getAnswer()));
49+
messageSender.send(
50+
destination,
51+
MessageType.SYSTEM_NOTICE,
52+
ofPlayerEvent(NONE_CORRECT_USER, RoomEventType.TIMEOUT));
4053

4154
// TODO : 게임 종료 로직
42-
if(!validateCurrentRound(room)){
55+
if (!validateCurrentRound(room)) {
4356
// 게임 종료 로직
4457
// GAME_SETTING, PLAYER_LIST, GAME_RESULT, ROOM_SETTING
4558
return;
@@ -49,11 +62,14 @@ private void handleTimeout(Room room) {
4962
room.increaseCurrentRound();
5063

5164
startTimer(room, CONTINUE_DELAY);
52-
messageSender.send(destination, MessageType.QUESTION_START, toQuestionStartResponse(room, CONTINUE_DELAY));
65+
messageSender.send(
66+
destination,
67+
MessageType.QUESTION_START,
68+
toQuestionStartResponse(room, CONTINUE_DELAY));
5369
}
5470

5571
public boolean validateCurrentRound(Room room) {
56-
if(room.getGameSetting().getRound() != room.getCurrentRound()) {
72+
if (room.getGameSetting().getRound() != room.getCurrentRound()) {
5773
return true;
5874
}
5975
cancelTimer(room);
@@ -64,7 +80,7 @@ public boolean validateCurrentRound(Room room) {
6480
public void cancelTimer(Room room) {
6581
// 정답 맞혔어요 ~ 타이머 캔슬 부탁
6682
ScheduledFuture<?> timer = room.getTimer();
67-
if(timer != null && !timer.isDone()) {
83+
if (timer != null && !timer.isDone()) {
6884
timer.cancel(false);
6985
}
7086
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.f1.backend.domain.game.dto;
22

33
public enum GameEventType {
4-
START, CONTINUE
4+
START,
5+
CONTINUE
56
}

backend/src/main/java/io/f1/backend/domain/game/dto/GameStartData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
import io.f1.backend.domain.game.dto.response.GameStartResponse;
44
import io.f1.backend.domain.game.dto.response.QuestionStartResponse;
55

6-
public record GameStartData(GameStartResponse gameStartResponse, QuestionStartResponse questionStartResponse) {
7-
}
6+
public record GameStartData(
7+
GameStartResponse gameStartResponse, QuestionStartResponse questionStartResponse) {}

backend/src/main/java/io/f1/backend/domain/game/dto/response/QuestionStartResponse.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,4 @@
22

33
import java.time.Instant;
44

5-
public record QuestionStartResponse(Long questionId, int round, Instant timestamp) {
6-
7-
}
5+
public record QuestionStartResponse(Long questionId, int round, Instant timestamp) {}

backend/src/main/java/io/f1/backend/domain/game/mapper/RoomMapper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.f1.backend.domain.game.mapper;
22

3-
import io.f1.backend.domain.game.dto.ChatMessage;
43
import io.f1.backend.domain.game.dto.Rank;
54
import io.f1.backend.domain.game.dto.RoomEventType;
65
import io.f1.backend.domain.game.dto.request.RoomCreateRequest;
@@ -115,7 +114,8 @@ public static RankUpdateResponse toRankUpdateResponse(Room room) {
115114

116115
public static QuestionStartResponse toQuestionStartResponse(Room room, int delay) {
117116
return new QuestionStartResponse(
118-
room.getCurrentQuestion().getId(), room.getCurrentRound(), Instant.now().plusSeconds(delay));
117+
room.getCurrentQuestion().getId(),
118+
room.getCurrentRound(),
119+
Instant.now().plusSeconds(delay));
119120
}
120-
121121
}

backend/src/main/java/io/f1/backend/domain/game/model/Room.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
import io.f1.backend.domain.question.entity.Question;
44

5-
import java.util.concurrent.Executors;
6-
import java.util.concurrent.ScheduledExecutorService;
7-
import java.util.concurrent.ScheduledFuture;
85
import lombok.Getter;
96

107
import java.time.LocalDateTime;
118
import java.util.ArrayList;
129
import java.util.List;
1310
import java.util.Map;
1411
import java.util.concurrent.ConcurrentHashMap;
12+
import java.util.concurrent.Executors;
13+
import java.util.concurrent.ScheduledExecutorService;
14+
import java.util.concurrent.ScheduledFuture;
1515

1616
@Getter
1717
public class Room {

backend/src/main/java/io/f1/backend/domain/game/websocket/GameSocketController.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import io.f1.backend.domain.game.app.GameService;
77
import io.f1.backend.domain.game.app.RoomService;
88
import io.f1.backend.domain.game.dto.ChatMessage;
9-
109
import io.f1.backend.domain.game.dto.request.DefaultWebSocketRequest;
1110
import io.f1.backend.domain.user.dto.UserPrincipal;
1211

@@ -49,15 +48,13 @@ public void gameStart(@DestinationVariable Long roomId, Message<?> message) {
4948
UserPrincipal principal = getSessionUser(message);
5049

5150
gameService.gameStart(roomId, principal);
52-
5351
}
5452

5553
@MessageMapping("room/chat/{roomId}")
5654
public void chat(
5755
@DestinationVariable Long roomId,
5856
Message<DefaultWebSocketRequest<ChatMessage>> message) {
5957

60-
6158
roomService.chat(roomId, getSessionId(message), message.getPayload().getMessage());
6259
}
6360

backend/src/test/java/io/f1/backend/domain/game/app/RoomServiceTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ class RoomServiceTests {
5252
@BeforeEach
5353
void setUp() {
5454
MockitoAnnotations.openMocks(this); // @Mock 어노테이션이 붙은 필드들을 초기화합니다.
55-
roomService = new RoomService(timerService, quizService, roomRepository, eventPublisher, messageSender);
55+
roomService =
56+
new RoomService(
57+
timerService, quizService, roomRepository, eventPublisher, messageSender);
5658

5759
SecurityContextHolder.clearContext();
5860
}

0 commit comments

Comments
 (0)