♻️ refactor : PR 리뷰 반영 (메서드 네이밍, static import, 빌더 패턴 삭제)

Author: silver-eunjoo

backend/src/main/java/io/f1/backend/domain/question/app/QuestionService.java

@@ -1,12 +1,13 @@
 package io.f1.backend.domain.question.app;
 
+import static io.f1.backend.domain.question.mapper.QuestionMapper.questionRequestToQuestion;
+import static io.f1.backend.domain.question.mapper.TextQuestionMapper.questionRequestToTextQuestion;
+
 import io.f1.backend.domain.question.dao.QuestionRepository;
 import io.f1.backend.domain.question.dao.TextQuestionRepository;
 import io.f1.backend.domain.question.dto.QuestionRequest;
 import io.f1.backend.domain.question.entity.Question;
 import io.f1.backend.domain.question.entity.TextQuestion;
-import io.f1.backend.domain.question.mapper.QuestionMapper;
-import io.f1.backend.domain.question.mapper.TextQuestionMapper;
 import io.f1.backend.domain.quiz.entity.Quiz;
 
 import lombok.RequiredArgsConstructor;
@@ -24,12 +25,12 @@ public class QuestionService {
     @Transactional
     public void saveQuestion(Quiz quiz, QuestionRequest request) {
 
-        Question question = QuestionMapper.questionRequestToQuestion(quiz, request);
+        Question question = questionRequestToQuestion(quiz, request);
         quiz.addQuestion(question);
         questionRepository.save(question);
 
         TextQuestion textQuestion =
-                TextQuestionMapper.questionRequestToTextQuestion(question, request.getContent());
+                questionRequestToTextQuestion(question, request.getContent());
         textQuestionRepository.save(textQuestion);
         question.addTextQuestion(textQuestion);
     }

backend/src/main/java/io/f1/backend/domain/quiz/app/QuizService.java

@@ -1,12 +1,14 @@
 package io.f1.backend.domain.quiz.app;
 
+import static io.f1.backend.domain.quiz.mapper.QuizMapper.quizCreateRequestToQuiz;
+import static io.f1.backend.domain.quiz.mapper.QuizMapper.quizToQuizCreateResponse;
+
 import io.f1.backend.domain.question.app.QuestionService;
 import io.f1.backend.domain.question.dto.QuestionRequest;
 import io.f1.backend.domain.quiz.dao.QuizRepository;
 import io.f1.backend.domain.quiz.dto.QuizCreateRequest;
 import io.f1.backend.domain.quiz.dto.QuizCreateResponse;
 import io.f1.backend.domain.quiz.entity.Quiz;
-import io.f1.backend.domain.quiz.mapper.QuizMapper;
 import io.f1.backend.domain.user.dao.UserRepository;
 import io.f1.backend.domain.user.entity.User;
 
@@ -41,25 +43,25 @@ public class QuizService {
     @Transactional
     public QuizCreateResponse saveQuiz(MultipartFile file, QuizCreateRequest request)
             throws IOException {
-        String imgUrl = defaultThumbnailPath;
+        String thumbnailPath = defaultThumbnailPath;
 
         if (file != null && !file.isEmpty()) {
             validateImageFile(file);
-            imgUrl = saveThumbnail(file);
+            thumbnailPath = convertToThumbnailPath(file);
         }
 
         // TODO : 시큐리티 구현 이후 삭제 (data.sql로 초기 저장해둔 유저 get), 나중엔 현재 로그인한 유저의 아이디를 받아오도록 수정
         User user = userRepository.findById(1L).orElseThrow(RuntimeException::new);
 
-        Quiz quiz = QuizMapper.quizCreateRequestToQuiz(request, imgUrl, user);
+        Quiz quiz = quizCreateRequestToQuiz(request, thumbnailPath, user);
 
         Quiz savedQuiz = quizRepository.save(quiz);
 
         for (QuestionRequest qRequest : request.getQuestions()) {
             questionService.saveQuestion(savedQuiz, qRequest);
         }
 
-        return QuizMapper.quizToQuizCreateResponse(savedQuiz);
+        return quizToQuizCreateResponse(savedQuiz);
     }
 
     private void validateImageFile(MultipartFile file) {
@@ -75,7 +77,7 @@ private void validateImageFile(MultipartFile file) {
         }
     }
 
-    private String saveThumbnail(MultipartFile file) throws IOException {
+    private String convertToThumbnailPath(MultipartFile file) throws IOException {
         String originalFilename = file.getOriginalFilename();
         String ext = getExtension(originalFilename);
         String savedFilename = UUID.randomUUID().toString() + "." + ext;

backend/src/main/java/io/f1/backend/domain/quiz/entity/Quiz.java

@@ -53,7 +53,6 @@ public class Quiz extends BaseEntity {
     @JoinColumn(name = "creator_id")
     private User creator;
 
-    @Builder
     public Quiz(
             String title,
             String description,

backend/src/main/java/io/f1/backend/domain/quiz/mapper/QuizMapper.java

@@ -11,13 +11,13 @@ public class QuizMapper {
     public static Quiz quizCreateRequestToQuiz(
             QuizCreateRequest quizCreateRequest, String imgUrl, User user) {
 
-        return Quiz.builder()
-                .title(quizCreateRequest.getTitle())
-                .description(quizCreateRequest.getDescription())
-                .quizType(quizCreateRequest.getQuizType())
-                .thumbnailUrl(imgUrl)
-                .creator(user) // TODO : 이후 creator에 들어갈 User은 현재 로그인 중인 유저를 가져오도록 변경
-                .build();
+        return new Quiz(
+            quizCreateRequest.getTitle(),
+            quizCreateRequest.getDescription(),
+            quizCreateRequest.getQuizType(),
+            imgUrl,
+            user // TODO : 이후 creator에 들어갈 User은 현재 로그인 중인 유저를 가져오도록 변경
+        );
     }
 
     public static QuizCreateResponse quizToQuizCreateResponse(Quiz quiz) {