♻️ refactor : 코드 리팩토링 (PR 리뷰 반영)

silver-eunjoo · silver-eunjoo · commit 1ceb939a7409 · 2025-07-18T15:28:04.000+09:00
diff --git a/backend/src/main/java/io/f1/backend/domain/question/app/QuestionService.java b/backend/src/main/java/io/f1/backend/domain/question/app/QuestionService.java
@@ -59,13 +59,10 @@ public void updateQuestionContent(Long questionId, String content) {
     }
 
     private static void verifyUserAuthority(Quiz quiz) {
-        if (SecurityUtils.getCurrentUserRole() == Role.USER) {
-            validateOwner(quiz.getCreator().getId());
+        if (SecurityUtils.getCurrentUserRole() == Role.ADMIN) {
+            return;
         }
-    }
-
-    private static void validateOwner(Long creatorId) {
-        if (!Objects.equals(SecurityUtils.getCurrentUserId(), creatorId)) {
+        if (!Objects.equals(SecurityUtils.getCurrentUserId(), quiz.getCreator().getId())) {
             throw new CustomException(AuthErrorCode.FORBIDDEN);
         }
     }
diff --git a/backend/src/main/java/io/f1/backend/domain/quiz/app/QuizService.java b/backend/src/main/java/io/f1/backend/domain/quiz/app/QuizService.java
@@ -138,13 +138,10 @@ public void deleteQuiz(Long quizId) {
     }
 
     private static void verifyUserAuthority(Quiz quiz) {
-        if (SecurityUtils.getCurrentUserRole() == Role.USER) {
-            validateOwner(quiz.getCreator().getId());
+        if (SecurityUtils.getCurrentUserRole() == Role.ADMIN) {
+            return;
         }
-    }
-
-    private static void validateOwner(Long creatorId) {
-        if (!Objects.equals(SecurityUtils.getCurrentUserId(), creatorId)) {
+        if (!Objects.equals(SecurityUtils.getCurrentUserId(), quiz.getCreator().getId())) {
             throw new CustomException(AuthErrorCode.FORBIDDEN);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -59,13 +59,10 @@ public void updateQuestionContent(Long questionId, String content) {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`private static void verifyUserAuthority(Quiz quiz) {`
`62`		`- if (SecurityUtils.getCurrentUserRole() == Role.USER) {`
`63`		`- validateOwner(quiz.getCreator().getId());`
	`62`	`+ if (SecurityUtils.getCurrentUserRole() == Role.ADMIN) {`
	`63`	`+ return;`
`64`	`64`	`}`
`65`		`- }`
`66`		`-`
`67`		`- private static void validateOwner(Long creatorId) {`
`68`		`- if (!Objects.equals(SecurityUtils.getCurrentUserId(), creatorId)) {`
	`65`	`+ if (!Objects.equals(SecurityUtils.getCurrentUserId(), quiz.getCreator().getId())) {`
`69`	`66`	`throw new CustomException(AuthErrorCode.FORBIDDEN);`
`70`	`67`	`}`
`71`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,13 +138,10 @@ public void deleteQuiz(Long quizId) {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`private static void verifyUserAuthority(Quiz quiz) {`
`141`		`- if (SecurityUtils.getCurrentUserRole() == Role.USER) {`
`142`		`- validateOwner(quiz.getCreator().getId());`
	`141`	`+ if (SecurityUtils.getCurrentUserRole() == Role.ADMIN) {`
	`142`	`+ return;`
`143`	`143`	`}`
`144`		`- }`
`145`		`-`
`146`		`- private static void validateOwner(Long creatorId) {`
`147`		`- if (!Objects.equals(SecurityUtils.getCurrentUserId(), creatorId)) {`
	`144`	`+ if (!Objects.equals(SecurityUtils.getCurrentUserId(), quiz.getCreator().getId())) {`
`148`	`145`	`throw new CustomException(AuthErrorCode.FORBIDDEN);`
`149`	`146`	`}`
`150`	`147`	`}`