Skip to content

Commit 45972ab

Browse files
committed
♻️ refactor: dto 이름 변경(StatWithNicknameAndUserId -> StatWithUserSummary)
1 parent d1d2df3 commit 45972ab

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

backend/src/main/java/io/f1/backend/domain/stat/dao/StatJpaRepository.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.f1.backend.domain.stat.dao;
22

33
import io.f1.backend.domain.stat.dto.StatWithNickname;
4-
import io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId;
4+
import io.f1.backend.domain.stat.dto.StatWithUserSummary;
55
import io.f1.backend.domain.stat.entity.Stat;
66

77
import org.springframework.data.domain.Page;
@@ -33,12 +33,12 @@ public interface StatJpaRepository extends JpaRepository<Stat, Long> {
3333
@Query(
3434
"""
3535
SELECT
36-
new io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId
36+
new io.f1.backend.domain.stat.dto.StatWithUserSummary
3737
(u.id, u.nickname, s.totalGames, s.winningGames, s.score)
3838
FROM
3939
Stat s JOIN s.user u
4040
""")
41-
List<StatWithNicknameAndUserId> findAllStatWithNicknameAndUserId();
41+
List<StatWithUserSummary> findAllStatWithUserSummary();
4242

4343
@Modifying
4444
@Query(
@@ -66,11 +66,11 @@ public interface StatJpaRepository extends JpaRepository<Stat, Long> {
6666

6767
@Query(
6868
"""
69-
SELECT new io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId(
69+
SELECT new io.f1.backend.domain.stat.dto.StatWithUserSummary(
7070
u.id, u.nickname, s.totalGames, s.winningGames, s.score
7171
)
7272
FROM Stat s JOIN s.user u
7373
WHERE u.id = :userId
7474
""")
75-
Optional<StatWithNicknameAndUserId> findByUserId(long userId);
75+
Optional<StatWithUserSummary> findStatWithUserSummary(long userId);
7676
}

backend/src/main/java/io/f1/backend/domain/stat/dao/StatRedisRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import io.f1.backend.domain.stat.dto.StatPageResponse;
66
import io.f1.backend.domain.stat.dto.StatResponse;
7-
import io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId;
7+
import io.f1.backend.domain.stat.dto.StatWithUserSummary;
88
import io.f1.backend.domain.user.dto.MyPageInfo;
99

1010
import lombok.RequiredArgsConstructor;
@@ -44,7 +44,7 @@ public void setup() {
4444
valueOps = redisTemplate.opsForValue();
4545
}
4646

47-
public void initialize(StatWithNicknameAndUserId stat) {
47+
public void initialize(StatWithUserSummary stat) {
4848
String statUserKey = getStatUserKey(stat.userId());
4949
String statNicknameKey = getStatNickname(stat.nickname());
5050

backend/src/main/java/io/f1/backend/domain/stat/dao/StatRepositoryAdapter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import io.f1.backend.domain.stat.dto.StatPageResponse;
66
import io.f1.backend.domain.stat.dto.StatWithNickname;
7-
import io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId;
7+
import io.f1.backend.domain.stat.dto.StatWithUserSummary;
88
import io.f1.backend.domain.user.dto.MyPageInfo;
99
import io.f1.backend.global.exception.CustomException;
1010
import io.f1.backend.global.exception.errorcode.RoomErrorCode;
@@ -56,7 +56,7 @@ public StatPageResponse getRanksByNickname(String nickname, int pageSize) {
5656

5757
@Override
5858
public void addUser(long userId, String nickname) {
59-
redisRepository.initialize(new StatWithNicknameAndUserId(userId, nickname, 0, 0, 0));
59+
redisRepository.initialize(new StatWithUserSummary(userId, nickname, 0, 0, 0));
6060
}
6161

6262
@Override
@@ -80,7 +80,7 @@ public void removeUser(long userId) {
8080
}
8181

8282
private void warmingRedis() {
83-
jpaRepository.findAllStatWithNicknameAndUserId().forEach(redisRepository::initialize);
83+
jpaRepository.findAllStatWithUserSummary().forEach(redisRepository::initialize);
8484
}
8585

8686
private Pageable getPageableFromNickname(String nickname, int pageSize) {
@@ -108,16 +108,16 @@ public MyPageInfo getMyPageByUserId(long userId) {
108108
log.error("Redis miss, fallback to MySQL for userId={}", userId, e);
109109
}
110110

111-
StatWithNicknameAndUserId stat = findStatByUserId(userId);
111+
StatWithUserSummary stat = findStatByUserId(userId);
112112
long rank = jpaRepository.countByScoreGreaterThan(stat.score()) + 1;
113113

114114
return new MyPageInfo(
115115
stat.nickname(), rank, stat.totalGames(), stat.winningGames(), stat.score());
116116
}
117117

118-
private StatWithNicknameAndUserId findStatByUserId(long userId) {
118+
private StatWithUserSummary findStatByUserId(long userId) {
119119
return jpaRepository
120-
.findByUserId(userId)
120+
.findStatWithUserSummary(userId)
121121
.orElseThrow(() -> new CustomException(UserErrorCode.USER_NOT_FOUND));
122122
}
123123
}
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
package io.f1.backend.domain.stat.dto;
22

3-
public record StatWithNicknameAndUserId(
3+
public record StatWithUserSummary(
44
long userId, String nickname, long totalGames, long winningGames, long score) {}

backend/src/test/java/io/f1/backend/domain/stat/RedisStatBrowserTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import io.f1.backend.domain.stat.dao.StatJpaRepository;
2727
import io.f1.backend.domain.stat.dao.StatRepositoryAdapter;
2828
import io.f1.backend.domain.stat.dto.StatWithNickname;
29-
import io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId;
29+
import io.f1.backend.domain.stat.dto.StatWithUserSummary;
3030
import io.f1.backend.domain.user.dao.UserRepository;
3131
import io.f1.backend.domain.user.dto.AuthenticationUser;
3232
import io.f1.backend.domain.user.dto.SignupRequest;
@@ -186,9 +186,9 @@ private MockHttpSession getMockSession(User user, boolean signup) {
186186
}
187187

188188
private void warmingRedisOneUser(User user) {
189-
StatWithNicknameAndUserId mockStat =
190-
new StatWithNicknameAndUserId(user.getId(), user.getNickname(), 10, 10, 100);
191-
given(statJpaRepository.findAllStatWithNicknameAndUserId()).willReturn(List.of(mockStat));
189+
StatWithUserSummary mockStat =
190+
new StatWithUserSummary(user.getId(), user.getNickname(), 10, 10, 100);
191+
given(statJpaRepository.findAllStatWithUserSummary()).willReturn(List.of(mockStat));
192192
statRepositoryAdapter.setup();
193193
}
194194
}

0 commit comments

Comments
 (0)