Skip to content

Commit 754a82b

Browse files
author
github-actions
committed
chore: Java 스타일 수정
1 parent 0f52704 commit 754a82b

File tree

4 files changed

+107
-104
lines changed

4 files changed

+107
-104
lines changed

backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java

Lines changed: 41 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,20 @@
3131
import io.f1.backend.domain.game.store.RoomRepository;
3232
import io.f1.backend.domain.quiz.app.QuizService;
3333
import io.f1.backend.domain.quiz.entity.Quiz;
34-
import java.util.List;
35-
import java.util.Map;
36-
import java.util.Optional;
37-
import java.util.concurrent.ConcurrentHashMap;
38-
import java.util.concurrent.atomic.AtomicLong;
34+
3935
import lombok.RequiredArgsConstructor;
4036
import lombok.extern.slf4j.Slf4j;
37+
4138
import org.hibernate.boot.model.naming.IllegalIdentifierException;
4239
import org.springframework.context.ApplicationEventPublisher;
4340
import org.springframework.stereotype.Service;
4441

42+
import java.util.List;
43+
import java.util.Map;
44+
import java.util.Optional;
45+
import java.util.concurrent.ConcurrentHashMap;
46+
import java.util.concurrent.atomic.AtomicLong;
47+
4548
@Slf4j
4649
@Service
4750
@RequiredArgsConstructor
@@ -69,7 +72,7 @@ public RoomCreateResponse saveRoom(RoomCreateRequest request) {
6972

7073
Room room = new Room(newId, roomSetting, gameSetting, host);
7174

72-
room.getUserIdSessionMap().put(host.id,PENDING_SESSION_ID);
75+
room.getUserIdSessionMap().put(host.id, PENDING_SESSION_ID);
7376

7477
roomRepository.saveRoom(room);
7578

@@ -85,7 +88,6 @@ public void enterRoom(RoomValidationRequest request) {
8588
Object lock = roomLocks.computeIfAbsent(roomId, k -> new Object());
8689

8790
synchronized (lock) {
88-
8991
Room room = findRoom(request.roomId());
9092

9193
if (room.getState().equals(RoomState.PLAYING)) {
@@ -99,7 +101,7 @@ public void enterRoom(RoomValidationRequest request) {
99101
}
100102

101103
if (room.getRoomSetting().locked()
102-
&& !room.getRoomSetting().password().equals(request.password())) {
104+
&& !room.getRoomSetting().password().equals(request.password())) {
103105
throw new IllegalArgumentException("401 비밀번호가 일치하지 않습니다.");
104106
}
105107

@@ -129,26 +131,25 @@ public RoomInitialData initializeRoomSocket(Long roomId, String sessionId) {
129131
Quiz quiz = quizService.getQuizById(quizId);
130132

131133
GameSettingResponse gameSettingResponse =
132-
toGameSettingResponse(room.getGameSetting(), quiz);
134+
toGameSettingResponse(room.getGameSetting(), quiz);
133135

134136
PlayerListResponse playerListResponse = toPlayerListResponse(room);
135137

136138
SystemNoticeResponse systemNoticeResponse = ofPlayerEvent(player, RoomEventType.ENTER);
137139

138140
return new RoomInitialData(
139-
getDestination(roomId),
140-
roomSettingResponse,
141-
gameSettingResponse,
142-
playerListResponse,
143-
systemNoticeResponse);
141+
getDestination(roomId),
142+
roomSettingResponse,
143+
gameSettingResponse,
144+
playerListResponse,
145+
systemNoticeResponse);
144146
}
145147

146148
public RoomExitData exitRoom(Long roomId, String sessionId) {
147149

148150
Object lock = roomLocks.computeIfAbsent(roomId, k -> new Object());
149151

150152
synchronized (lock) {
151-
152153
Room room = findRoom(roomId);
153154

154155
Map<String, Player> playerSessionMap = room.getPlayerSessionMap();
@@ -157,10 +158,10 @@ public RoomExitData exitRoom(Long roomId, String sessionId) {
157158

158159
Player removePlayer = playerSessionMap.get(sessionId);
159160

160-
if (removePlayer == null) {
161-
room.getUserIdSessionMap().remove(getCurrentUserId());
162-
throw new IllegalIdentifierException("404 세션 없음 비정상적인 퇴장 요청");
163-
}
161+
if (removePlayer == null) {
162+
room.getUserIdSessionMap().remove(getCurrentUserId());
163+
throw new IllegalIdentifierException("404 세션 없음 비정상적인 퇴장 요청");
164+
}
164165

165166
/* 방 삭제 */
166167
if (playerSessionMap.size() == 1 && playerSessionMap.containsKey(sessionId)) {
@@ -173,15 +174,17 @@ public RoomExitData exitRoom(Long roomId, String sessionId) {
173174
/* 방장 변경 */
174175
if (room.getHost().getId().equals(removePlayer.getId())) {
175176

176-
Optional<String> nextHostSessionId = playerSessionMap.keySet().stream()
177-
.filter(key -> !key.equals(sessionId)).findFirst();
177+
Optional<String> nextHostSessionId =
178+
playerSessionMap.keySet().stream()
179+
.filter(key -> !key.equals(sessionId))
180+
.findFirst();
178181

179182
Player nextHost =
180-
playerSessionMap.get(
181-
nextHostSessionId.orElseThrow(
182-
() ->
183-
new IllegalArgumentException(
184-
"방장 교체 불가 - 404 해당 세션 플레이어는 존재하지않습니다.")));
183+
playerSessionMap.get(
184+
nextHostSessionId.orElseThrow(
185+
() ->
186+
new IllegalArgumentException(
187+
"방장 교체 불가 - 404 해당 세션 플레이어는 존재하지않습니다.")));
185188

186189
room.updateHost(nextHost);
187190
log.info("user_id:{} 방장 변경 완료 ", nextHost.getId());
@@ -191,7 +194,7 @@ public RoomExitData exitRoom(Long roomId, String sessionId) {
191194
playerSessionMap.remove(sessionId);
192195

193196
SystemNoticeResponse systemNoticeResponse =
194-
ofPlayerEvent(removePlayer, RoomEventType.EXIT);
197+
ofPlayerEvent(removePlayer, RoomEventType.EXIT);
195198

196199
PlayerListResponse playerListResponse = toPlayerListResponse(room);
197200

@@ -202,15 +205,15 @@ public RoomExitData exitRoom(Long roomId, String sessionId) {
202205
public RoomListResponse getAllRooms() {
203206
List<Room> rooms = roomRepository.findAll();
204207
List<RoomResponse> roomResponses =
205-
rooms.stream()
206-
.map(
207-
room -> {
208-
Long quizId = room.getGameSetting().getQuizId();
209-
Quiz quiz = quizService.getQuizById(quizId);
210-
211-
return toRoomResponse(room, quiz);
212-
})
213-
.toList();
208+
rooms.stream()
209+
.map(
210+
room -> {
211+
Long quizId = room.getGameSetting().getQuizId();
212+
Quiz quiz = quizService.getQuizById(quizId);
213+
214+
return toRoomResponse(room, quiz);
215+
})
216+
.toList();
214217
return new RoomListResponse(roomResponses);
215218
}
216219

@@ -224,9 +227,7 @@ private Player createPlayer() {
224227

225228
private Room findRoom(Long roomId) {
226229
return roomRepository
227-
.findRoom(roomId)
228-
.orElseThrow(() -> new IllegalArgumentException("404 존재하지 않는 방입니다."));
230+
.findRoom(roomId)
231+
.orElseThrow(() -> new IllegalArgumentException("404 존재하지 않는 방입니다."));
229232
}
230-
231-
232233
}

backend/src/main/java/io/f1/backend/domain/game/model/Room.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class Room {
2727

2828
private Map<String, Player> playerSessionMap = new ConcurrentHashMap<>();
2929

30-
private Map<Long,String> userIdSessionMap = new ConcurrentHashMap<>();
30+
private Map<Long, String> userIdSessionMap = new ConcurrentHashMap<>();
3131

3232
private final LocalDateTime createdAt = LocalDateTime.now();
3333

@@ -36,7 +36,6 @@ public Room(Long id, RoomSetting roomSetting, GameSetting gameSetting, Player ho
3636
this.roomSetting = roomSetting;
3737
this.gameSetting = gameSetting;
3838
this.host = host;
39-
4039
}
4140

4241
public void updateHost(Player nextHost) {

backend/src/main/java/io/f1/backend/domain/game/websocket/GameSocketController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public void initializeRoomSocket(@DestinationVariable Long roomId, Message<?> me
2525

2626
String websocketSessionId = getSessionId(message);
2727

28-
RoomInitialData roomInitialData = roomService.initializeRoomSocket(roomId, websocketSessionId);
28+
RoomInitialData roomInitialData =
29+
roomService.initializeRoomSocket(roomId, websocketSessionId);
2930
String destination = roomInitialData.destination();
3031

3132
messageSender.send(

backend/src/test/java/io/f1/backend/domain/game/app/RoomServiceTests.java

Lines changed: 63 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,9 @@
1313
import io.f1.backend.domain.quiz.app.QuizService;
1414
import io.f1.backend.domain.user.entity.User;
1515
import io.f1.backend.global.util.SecurityUtils;
16-
import java.time.LocalDateTime;
17-
import java.util.ArrayList;
18-
import java.util.List;
19-
import java.util.Optional;
20-
import java.util.concurrent.CountDownLatch;
21-
import java.util.concurrent.ExecutorService;
22-
import java.util.concurrent.Executors;
16+
2317
import lombok.extern.slf4j.Slf4j;
18+
2419
import org.junit.jupiter.api.AfterEach;
2520
import org.junit.jupiter.api.BeforeEach;
2621
import org.junit.jupiter.api.DisplayName;
@@ -32,22 +27,26 @@
3227
import org.springframework.context.ApplicationEventPublisher;
3328
import org.springframework.security.core.context.SecurityContextHolder;
3429

30+
import java.time.LocalDateTime;
31+
import java.util.ArrayList;
32+
import java.util.List;
33+
import java.util.Optional;
34+
import java.util.concurrent.CountDownLatch;
35+
import java.util.concurrent.ExecutorService;
36+
import java.util.concurrent.Executors;
37+
3538
@Slf4j
3639
@ExtendWith(MockitoExtension.class)
3740
class RoomServiceTests {
3841

3942
private RoomService roomService;
4043

41-
@Mock
42-
private RoomRepository roomRepository;
43-
@Mock
44-
private QuizService quizService;
45-
@Mock
46-
private ApplicationEventPublisher eventPublisher;
47-
44+
@Mock private RoomRepository roomRepository;
45+
@Mock private QuizService quizService;
46+
@Mock private ApplicationEventPublisher eventPublisher;
4847

4948
@BeforeEach
50-
void setUp(){
49+
void setUp() {
5150
MockitoAnnotations.openMocks(this); // @Mock 어노테이션이 붙은 필드들을 초기화합니다.
5251
roomService = new RoomService(quizService, roomRepository, eventPublisher);
5352

@@ -84,30 +83,33 @@ void enterRoom_synchronized() throws Exception {
8483
String provider = "provider +" + i;
8584
String providerId = "providerId" + i;
8685
LocalDateTime lastLogin = LocalDateTime.now();
87-
executorService.submit(() -> {
88-
try {
89-
User user = User.builder()
90-
.provider(provider)
91-
.provider(providerId).lastLogin(lastLogin).build();
92-
93-
user.setId(userId);
94-
95-
SecurityUtils.setAuthentication(user);
96-
97-
roomService.enterRoom(roomValidationRequest);
98-
} catch (Exception e) {
99-
//e.printStackTrace();
100-
} finally {
101-
SecurityContextHolder.clearContext();
102-
countDownLatch.countDown();
103-
}
104-
});
86+
executorService.submit(
87+
() -> {
88+
try {
89+
User user =
90+
User.builder()
91+
.provider(provider)
92+
.provider(providerId)
93+
.lastLogin(lastLogin)
94+
.build();
95+
96+
user.setId(userId);
97+
98+
SecurityUtils.setAuthentication(user);
99+
100+
roomService.enterRoom(roomValidationRequest);
101+
} catch (Exception e) {
102+
// e.printStackTrace();
103+
} finally {
104+
SecurityContextHolder.clearContext();
105+
countDownLatch.countDown();
106+
}
107+
});
105108
}
106109
countDownLatch.await();
107110
assertThat(room.getUserIdSessionMap()).hasSize(room.getRoomSetting().maxUserCount());
108111
}
109112

110-
111113
@Test
112114
@DisplayName("exitRoom_동시성_테스트")
113115
void exitRoom_synchronized() throws Exception {
@@ -121,22 +123,21 @@ void exitRoom_synchronized() throws Exception {
121123
GameSetting gameSetting = new GameSetting(quizId, 10, 60);
122124

123125
List<Player> players = new ArrayList<>();
124-
for (int i = 1; i <=threadCount; i++) {
126+
for (int i = 1; i <= threadCount; i++) {
125127
Long id = i + 1L;
126128
String nickname = "nickname " + i;
127129

128130
Player player = new Player(id, nickname);
129131
players.add(player);
130-
131132
}
132133
Player host = players.getFirst();
133134
Room room = new Room(roomId, roomSetting, gameSetting, host);
134135

135-
for (int i = 1; i <=threadCount; i++) {
136+
for (int i = 1; i <= threadCount; i++) {
136137
String sessionId = "sessionId" + i;
137138
Player player = players.get(i - 1);
138-
room.getPlayerSessionMap().put(sessionId,player);
139-
room.getUserIdSessionMap().put(player.getId(),sessionId);
139+
room.getPlayerSessionMap().put(sessionId, player);
140+
room.getUserIdSessionMap().put(player.getId(), sessionId);
140141
}
141142

142143
log.info("room.getPlayerSessionMap().size() = {}", room.getPlayerSessionMap().size());
@@ -153,29 +154,30 @@ void exitRoom_synchronized() throws Exception {
153154
String provider = "provider +" + i;
154155
String providerId = "providerId" + i;
155156
LocalDateTime lastLogin = LocalDateTime.now();
156-
executorService.submit(() -> {
157-
try {
158-
User user = User.builder()
159-
.provider(provider)
160-
.provider(providerId).lastLogin(lastLogin).build();
161-
user.setId(userId);
162-
SecurityUtils.setAuthentication(user);
163-
164-
log.info("userId = {}", userId);
165-
log.info("room.getHost().getId() = {}", room.getHost().getId());
166-
roomService.exitRoom(roomId, sessionId);
167-
} catch (Exception e) {
168-
e.printStackTrace();
169-
} finally {
170-
SecurityContextHolder.clearContext();
171-
countDownLatch.countDown();
172-
}
173-
});
157+
executorService.submit(
158+
() -> {
159+
try {
160+
User user =
161+
User.builder()
162+
.provider(provider)
163+
.provider(providerId)
164+
.lastLogin(lastLogin)
165+
.build();
166+
user.setId(userId);
167+
SecurityUtils.setAuthentication(user);
168+
169+
log.info("userId = {}", userId);
170+
log.info("room.getHost().getId() = {}", room.getHost().getId());
171+
roomService.exitRoom(roomId, sessionId);
172+
} catch (Exception e) {
173+
e.printStackTrace();
174+
} finally {
175+
SecurityContextHolder.clearContext();
176+
countDownLatch.countDown();
177+
}
178+
});
174179
}
175180
countDownLatch.await();
176181
assertThat(room.getUserIdSessionMap()).hasSize(1);
177182
}
178-
179-
180-
181-
}
183+
}

0 commit comments

Comments
 (0)