Skip to content

Commit c874fe5

Browse files
committed
♻️ refactor: 매직 스트링 제거
1 parent 85d19c9 commit c874fe5

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

backend/src/main/java/io/f1/backend/domain/user/app/CustomOAuthUserService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package io.f1.backend.domain.user.app;
22

3+
import static io.f1.backend.domain.user.constants.SessionKeys.*;
4+
35
import io.f1.backend.domain.stat.entity.Stat;
46
import io.f1.backend.domain.user.dao.UserRepository;
57
import io.f1.backend.domain.user.dto.AuthenticationUser;
@@ -37,7 +39,7 @@ public OAuth2User loadUser(OAuth2UserRequest userRequest) throws OAuth2Authentic
3739
.map(this::updateLastLogin)
3840
.orElseGet(() -> createNewUser(provider, providerId));
3941

40-
httpSession.setAttribute("OAuthUser", AuthenticationUser.from(user));
42+
httpSession.setAttribute(OAUTH_USER, AuthenticationUser.from(user));
4143
return new UserPrincipal(user, oAuth2User.getAttributes());
4244
}
4345

backend/src/main/java/io/f1/backend/domain/user/app/UserService.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package io.f1.backend.domain.user.app;
22

3+
import static io.f1.backend.domain.user.constants.SessionKeys.OAUTH_USER;
4+
import static io.f1.backend.domain.user.constants.SessionKeys.USER;
35
import static io.f1.backend.domain.user.mapper.UserMapper.toSignupResponse;
46

57
import io.f1.backend.domain.user.dao.UserRepository;
@@ -36,7 +38,7 @@ public SignupResponseDto signup(HttpSession session, SignupRequestDto signupRequ
3638

3739
private AuthenticationUser extractSessionUser(HttpSession session) {
3840
AuthenticationUser authenticationUser = (AuthenticationUser) session.getAttribute(
39-
"OAuthUser");
41+
OAUTH_USER);
4042
if (authenticationUser == null) {
4143
throw new RuntimeException("E401001: 로그인이 필요합니다.");
4244
}
@@ -73,7 +75,7 @@ public User updateUserNickname(Long userId, String nickname) {
7375
}
7476

7577
private void updateSessionAfterSignup(HttpSession session, User user) {
76-
session.removeAttribute("OAuthUser");
77-
session.setAttribute("user", AuthenticationUser.from(user));
78+
session.removeAttribute(OAUTH_USER);
79+
session.setAttribute(USER, AuthenticationUser.from(user));
7880
}
7981
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package io.f1.backend.domain.user.constants;
2+
3+
public final class SessionKeys {
4+
5+
private SessionKeys() {
6+
}
7+
8+
public static final String OAUTH_USER = "OAuthUser";
9+
public static final String USER = "user";
10+
}

0 commit comments

Comments
 (0)