♻️ refactor : PR 리뷰 반영(stream().allMatch, gameSetting 내부 메서드)

Author: silver-eunjoo

backend/src/main/java/io/f1/backend/domain/game/app/GameService.java

@@ -57,9 +57,7 @@ private Integer checkGameSetting(Room room, Long quizId) {
 
         GameSetting gameSetting = room.getGameSetting();
 
-        Long roomQuizId = gameSetting.getQuizId();
-
-        if (!roomQuizId.equals(quizId)) {
+        if (!gameSetting.checkQuizId(quizId)) {
             throw new IllegalArgumentException("E409002 : 게임 설정이 다릅니다. (게임을 시작할 수 없습니다.)");
         }
 
@@ -70,12 +68,8 @@ private boolean validateReadyStatus(Room room) {
 
         Map<String, Player> playerSessionMap = room.getPlayerSessionMap();
 
-        for (Player player : playerSessionMap.values()) {
-            if (!player.isReady()) {
-                return false;
-            }
-        }
-        return true;
+        return playerSessionMap.values().stream().allMatch(Player::isReady);
+
     }
 
     private static String getDestination(Long roomId) {

backend/src/main/java/io/f1/backend/domain/game/model/GameSetting.java

@@ -10,4 +10,11 @@ public class GameSetting {
     private Long quizId;
     private Integer round; // 게임 변경 시 해당 게임의 총 문제 수로 설정
     private int timeLimit = 60;
+
+    public boolean checkQuizId(Long quizId) {
+        if(this.quizId != null && this.quizId.equals(quizId)) {
+            return false;
+        }
+        return true;
+    }
 }

backend/src/main/java/io/f1/backend/domain/game/model/Room.java

@@ -57,4 +57,5 @@ public void removeUserId(Long id) {
     public void removeSessionId(String sessionId) {
         this.playerSessionMap.remove(sessionId);
     }
+
 }