Skip to content

Commit f8ab68e

Browse files
author
github-actions
committed
chore: Java 스타일 수정
1 parent 37f12dd commit f8ab68e

File tree

16 files changed

+627
-640
lines changed

16 files changed

+627
-640
lines changed

‎backend/src/main/java/io/f1/backend/domain/stat/api/StatController.java‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66

77
import lombok.RequiredArgsConstructor;
88

9-
import org.apache.commons.lang3.StringUtils;
109
import org.springframework.data.domain.Pageable;
1110
import org.springframework.data.domain.Sort.Direction;
1211
import org.springframework.data.web.PageableDefault;
1312
import org.springframework.http.ResponseEntity;
14-
import org.springframework.security.core.parameters.P;
1513
import org.springframework.web.bind.annotation.GetMapping;
16-
import org.springframework.web.bind.annotation.PathVariable;
1714
import org.springframework.web.bind.annotation.RequestMapping;
1815
import org.springframework.web.bind.annotation.RequestParam;
1916
import org.springframework.web.bind.annotation.RestController;
@@ -28,7 +25,7 @@ public class StatController {
2825
@LimitPageSize
2926
@GetMapping("/rankings")
3027
public ResponseEntity<StatPageResponse> getRankings(
31-
@RequestParam(required = false) String nickname,
28+
@RequestParam(required = false) String nickname,
3229
@PageableDefault(sort = "score", direction = Direction.DESC) Pageable pageable) {
3330
return ResponseEntity.ok().body(statService.getRanks(pageable, nickname));
3431
}

‎backend/src/main/java/io/f1/backend/domain/stat/app/StatService.java‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import io.f1.backend.domain.stat.dao.StatRepository;
44
import io.f1.backend.domain.stat.dto.StatPageResponse;
5-
65
import io.f1.backend.global.exception.CustomException;
76
import io.f1.backend.global.exception.errorcode.RoomErrorCode;
7+
88
import lombok.RequiredArgsConstructor;
99

1010
import org.apache.commons.lang3.StringUtils;
@@ -21,35 +21,35 @@ public class StatService {
2121

2222
@Transactional(readOnly = true)
2323
public StatPageResponse getRanks(Pageable pageable, String nickname) {
24-
StatPageResponse response;
24+
StatPageResponse response;
2525

26-
if (StringUtils.isBlank(nickname)) {
27-
response = statRepository.getRanks(pageable);
28-
} else {
29-
response = statRepository.getRanksByNickname(nickname, pageable.getPageSize());
30-
}
26+
if (StringUtils.isBlank(nickname)) {
27+
response = statRepository.getRanks(pageable);
28+
} else {
29+
response = statRepository.getRanksByNickname(nickname, pageable.getPageSize());
30+
}
3131

32-
if (response.totalElements() == 0) {
33-
throw new CustomException(RoomErrorCode.PLAYER_NOT_FOUND);
34-
}
32+
if (response.totalElements() == 0) {
33+
throw new CustomException(RoomErrorCode.PLAYER_NOT_FOUND);
34+
}
3535

36-
return response;
36+
return response;
3737
}
3838

39-
// TODO: 게임 종료 후 호출 필요
40-
public void updateRank(long userId, boolean win, int deltaScore) {
41-
statRepository.updateRank(userId, win, deltaScore);
42-
}
39+
// TODO: 게임 종료 후 호출 필요
40+
public void updateRank(long userId, boolean win, int deltaScore) {
41+
statRepository.updateRank(userId, win, deltaScore);
42+
}
4343

44-
public void addUser(long userId, String nickname) {
45-
statRepository.addUser(userId, nickname);
46-
}
44+
public void addUser(long userId, String nickname) {
45+
statRepository.addUser(userId, nickname);
46+
}
4747

48-
public void removeUser(long userId) {
49-
statRepository.removeUser(userId);
50-
}
48+
public void removeUser(long userId) {
49+
statRepository.removeUser(userId);
50+
}
5151

52-
public void updateNickname(long userId, String newNickname) {
53-
statRepository.updateNickname(userId, newNickname);
54-
}
52+
public void updateNickname(long userId, String newNickname) {
53+
statRepository.updateNickname(userId, newNickname);
54+
}
5555
}

‎backend/src/main/java/io/f1/backend/domain/stat/dao/StatJpaRepository.java‎

Lines changed: 32 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,14 @@
44
import io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId;
55
import io.f1.backend.domain.stat.entity.Stat;
66

7-
import io.f1.backend.domain.user.entity.User;
8-
import java.util.List;
97
import org.springframework.data.domain.Page;
108
import org.springframework.data.domain.Pageable;
119
import org.springframework.data.jpa.repository.JpaRepository;
1210
import org.springframework.data.jpa.repository.Modifying;
1311
import org.springframework.data.jpa.repository.Query;
1412

13+
import java.util.List;
1514
import java.util.Optional;
16-
import org.springframework.transaction.annotation.Transactional;
1715

1816
public interface StatJpaRepository extends JpaRepository<Stat, Long> {
1917

@@ -32,37 +30,37 @@ public interface StatJpaRepository extends JpaRepository<Stat, Long> {
3230

3331
long countByScoreGreaterThan(Long score);
3432

35-
@Query(
36-
"""
37-
SELECT
38-
new io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId
39-
(u.id, u.nickname, s.totalGames, s.winningGames, s.score)
40-
FROM
41-
Stat s JOIN s.user u
42-
""")
43-
List<StatWithNicknameAndUserId> findAllStatWithNicknameAndUserId();
33+
@Query(
34+
"""
35+
SELECT
36+
new io.f1.backend.domain.stat.dto.StatWithNicknameAndUserId
37+
(u.id, u.nickname, s.totalGames, s.winningGames, s.score)
38+
FROM
39+
Stat s JOIN s.user u
40+
""")
41+
List<StatWithNicknameAndUserId> findAllStatWithNicknameAndUserId();
4442

45-
@Modifying
46-
@Query(
47-
"""
48-
UPDATE
49-
Stat s
50-
SET
51-
s.totalGames = s.totalGames + 1, s.winningGames = s.winningGames + 1, s.score = s.score + :deltaScore
52-
WHERE
53-
s.user.id = :userId
54-
""")
55-
void updateStatByUserIdCaseWin(long deltaScore, long userId);
43+
@Modifying
44+
@Query(
45+
"""
46+
UPDATE
47+
Stat s
48+
SET
49+
s.totalGames = s.totalGames + 1, s.winningGames = s.winningGames + 1, s.score = s.score + :deltaScore
50+
WHERE
51+
s.user.id = :userId
52+
""")
53+
void updateStatByUserIdCaseWin(long deltaScore, long userId);
5654

57-
@Modifying
58-
@Query(
59-
"""
60-
UPDATE
61-
Stat s
62-
SET
63-
s.totalGames = s.totalGames + 1, s.score = s.score + :deltaScore
64-
WHERE
65-
s.user.id = :userId
66-
""")
67-
void updateStatByUserIdCaseLose(long deltaScore, long userId);
55+
@Modifying
56+
@Query(
57+
"""
58+
UPDATE
59+
Stat s
60+
SET
61+
s.totalGames = s.totalGames + 1, s.score = s.score + :deltaScore
62+
WHERE
63+
s.user.id = :userId
64+
""")
65+
void updateStatByUserIdCaseLose(long deltaScore, long userId);
6866
}

0 commit comments

Comments
 (0)