Skip to content

Commit 87963ab

Browse files
authored
fix: 답변 기능 수정 (#128)
* fix: 답변 조회 수정 * test: 답변 조회 테스트 수정
1 parent e3d9687 commit 87963ab

File tree

3 files changed

+18
-23
lines changed

3 files changed

+18
-23
lines changed

src/main/java/com/oronaminc/join/answer/service/AnswerReader.java

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
package com.oronaminc.join.answer.service;
22

3-
import com.oronaminc.join.answer.dao.AnswerRepository;
4-
import com.oronaminc.join.answer.domain.Answer;
5-
import com.oronaminc.join.global.exception.ErrorCode;
6-
import com.oronaminc.join.global.exception.ErrorException;
73
import java.time.LocalDateTime;
84
import java.util.List;
95
import java.util.Optional;
10-
import lombok.RequiredArgsConstructor;
6+
117
import org.springframework.data.domain.Pageable;
128
import org.springframework.stereotype.Component;
139

10+
import com.oronaminc.join.answer.dao.AnswerRepository;
11+
import com.oronaminc.join.answer.domain.Answer;
12+
import com.oronaminc.join.global.exception.ErrorCode;
13+
import com.oronaminc.join.global.exception.ErrorException;
14+
15+
import lombok.RequiredArgsConstructor;
16+
1417
@Component
1518
@RequiredArgsConstructor
1619
public class AnswerReader {
@@ -31,11 +34,6 @@ public List<Answer> getAnswerByQuestionIdWithCursor(Long questionId,
3134
pageable);
3235
}
3336

34-
public Answer getByQuestionId(Long questionId) {
35-
return answerRepository.findByQuestionId(questionId)
36-
.orElseThrow(() -> new ErrorException(ErrorCode.NOT_FOUND_EXIST_ANSWER));
37-
}
38-
3937
public Answer getById(Long answerId) {
4038
return findById(answerId)
4139
.orElseThrow(() -> new ErrorException(ErrorCode.NOT_FOUND_ANSWER));

src/main/java/com/oronaminc/join/answer/service/AnswerService.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
package com.oronaminc.join.answer.service;
22

3+
import java.time.LocalDateTime;
4+
import java.util.List;
5+
import java.util.Set;
6+
7+
import org.springframework.data.domain.PageRequest;
8+
import org.springframework.data.domain.Pageable;
9+
import org.springframework.data.domain.Slice;
10+
import org.springframework.stereotype.Service;
11+
import org.springframework.transaction.annotation.Transactional;
312

413
import com.oronaminc.join.answer.dao.AnswerRepository;
514
import com.oronaminc.join.answer.domain.Answer;
@@ -16,15 +25,8 @@
1625
import com.oronaminc.join.question.service.QuestionReader;
1726
import com.oronaminc.join.room.domain.Room;
1827
import com.oronaminc.join.room.service.RoomReader;
19-
import java.time.LocalDateTime;
20-
import java.util.List;
21-
import java.util.Set;
28+
2229
import lombok.RequiredArgsConstructor;
23-
import org.springframework.data.domain.PageRequest;
24-
import org.springframework.data.domain.Pageable;
25-
import org.springframework.data.domain.Slice;
26-
import org.springframework.stereotype.Service;
27-
import org.springframework.transaction.annotation.Transactional;
2830

2931
@Service
3032
@Transactional(readOnly = true)
@@ -65,7 +67,6 @@ public Slice<AnswerGetResponse> getAnswers(
6567
memberReader.getById(memberId);
6668
roomReader.getById(roomId);
6769
questionReader.getByIdAndRoomId(questionId, roomId);
68-
answerReader.getByQuestionId(questionId);
6970

7071
Pageable pageable = PageRequest.of(0, size + 1);
7172

src/test/java/com/oronaminc/join/answer/service/AnswerServiceTests.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ void getAnswers_firstPage_success() {
152152
given(memberReader.getById(1L)).willReturn(mockMember);
153153
given(roomReader.getById(1L)).willReturn(mockRoom);
154154
given(questionReader.getByIdAndRoomId(1L, 1L)).willReturn(mockQuestion);
155-
given(answerReader.getByQuestionId(1L)).willReturn(null);
156155
given(answerReader.getFirstPageByQuestionId(eq(1L), any())).willReturn(answers);
157156
given(emojiReader.findTargetIdsByMemberAndTargetTypeInBatch(1L, TargetType.ANSWER,
158157
List.of(100L, 99L)))
@@ -174,7 +173,6 @@ void getAnswers_cursorPaging_success() {
174173
given(memberReader.getById(1L)).willReturn(mockMember);
175174
given(roomReader.getById(1L)).willReturn(mockRoom);
176175
given(questionReader.getByIdAndRoomId(1L, 1L)).willReturn(mockQuestion);
177-
given(answerReader.getByQuestionId(1L)).willReturn(null);
178176
given(answerReader.getAnswerByQuestionIdWithCursor(eq(1L), any(), any(), any())).willReturn(
179177
answers);
180178
given(emojiReader.findTargetIdsByMemberAndTargetTypeInBatch(1L, TargetType.ANSWER,
@@ -198,7 +196,6 @@ void getAnswers_containsEmojiedAnswers() {
198196
given(memberReader.getById(1L)).willReturn(mockMember);
199197
given(roomReader.getById(1L)).willReturn(mockRoom);
200198
given(questionReader.getByIdAndRoomId(1L, 1L)).willReturn(mockQuestion);
201-
given(answerReader.getByQuestionId(1L)).willReturn(null);
202199
given(answerReader.getFirstPageByQuestionId(eq(1L), any())).willReturn(answers);
203200
given(emojiReader.findTargetIdsByMemberAndTargetTypeInBatch(1L, TargetType.ANSWER,
204201
List.of(1L, 2L)))
@@ -220,7 +217,6 @@ void getAnswers_emptyList_noError() {
220217
given(memberReader.getById(1L)).willReturn(mockMember);
221218
given(roomReader.getById(1L)).willReturn(mockRoom);
222219
given(questionReader.getByIdAndRoomId(1L, 1L)).willReturn(mockQuestion);
223-
given(answerReader.getByQuestionId(1L)).willReturn(null);
224220
given(answerReader.getFirstPageByQuestionId(eq(1L), any())).willReturn(List.of());
225221

226222
// when

0 commit comments

Comments
 (0)