feat: 질문 생성 rate limiting (#65)

* feat: 질문 dto validation 추가

* feat: 질문 rate limit 적용

* feat: bucket 조건 변경

* feat: enum type 이름 변경

* feat: valid 추가

Author: chcch529

src/main/java/com/oronaminc/join/global/exception/ErrorCode.java

@@ -39,6 +39,7 @@ public enum ErrorCode {
     NOT_FOUND_QUESTION("QUESTION-002", "질문을 찾을 수 없습니다.", NOT_FOUND),
     UNAUTHORIZED_EDIT_QUESTION("QUESTION-003", "작성자만 질문을 수정할 수 있습니다.", UNAUTHORIZED),
     UNAUTHORIZED_DELETE_QUESTION("QUESTION-004", "작성자 및 관리자만 질문을 삭제할 수 있습니다.", UNAUTHORIZED),
+    TOO_MANY_REQUESTS_QUESTION("QUESTION-005", "잠시 후 다시 시도해주세요.", TOO_MANY_REQUESTS),
 
     UNAUTHORIZED_ROLE_ANSWER("ANSWER-001", "팀원 또는 발표자만 댓글을 작성할 수 있습니다.", UNAUTHORIZED),
     NOT_FOUND_EXIST_ANSWER("ANSWER-002", "해당 질문에 대한 답변이 존재하지 않습니다.", NOT_FOUND),

src/main/java/com/oronaminc/join/global/ratelimit/RateLimitType.java

@@ -6,6 +6,13 @@
 import lombok.Getter;
 
 public enum RateLimitType {
+    CREATE_QUESTION(
+        "CREATE_QUESTION:{}:{}",
+        Bandwidth.builder()
+            .capacity(3)
+            .refillIntervally(3, Duration.ofSeconds(15))
+            .build()
+    ),
     EMOJI(
         "EMOJI:{}:{}:{}",
         Bandwidth.builder()

src/main/java/com/oronaminc/join/question/domain/Question.java

@@ -2,7 +2,7 @@
 
 import com.oronaminc.join.global.entity.BaseEntity;
 import com.oronaminc.join.member.domain.Member;
-import com.oronaminc.join.question.dto.QuestionCreateRequest;
+import com.oronaminc.join.question.dto.QuestionRequest;
 import com.oronaminc.join.room.domain.Room;
 import jakarta.persistence.Entity;
 import jakarta.persistence.FetchType;
@@ -50,7 +50,7 @@ public class Question extends BaseEntity {
     @Version
     private Integer version;
 
-    public static Question create(Room room, Member member, QuestionCreateRequest requestDto) {
+    public static Question create(Room room, Member member, QuestionRequest requestDto) {
         return Question.builder()
             .room(room)
             .member(member)

src/main/java/com/oronaminc/join/question/dto/QuestionCreateRequest.java

@@ -0,0 +1,15 @@
+package com.oronaminc.join.question.dto;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+import jakarta.validation.constraints.NotBlank;
+import jakarta.validation.constraints.Size;
+
+@Schema(description = "질문 생성/수정 요청 DTO")
+public record QuestionRequest(
+    @Schema(description = "질문 내용", example = "질문있습니다. 질문생성DTO가 맞나요?")
+    @NotBlank(message = "질문 내용을 입력해주시기 바랍니다.")
+    @Size(max = 500, message = "질문 내용은 최대 500자까지 입력할 수 있습니다.")
+    String content
+) {
+
+}

src/main/java/com/oronaminc/join/question/dto/QuestionRequest.java

@@ -12,7 +12,7 @@
 import com.oronaminc.join.question.domain.Question;
 import com.oronaminc.join.question.domain.QuestionSort;
 import com.oronaminc.join.question.dto.QuestionAssembleResponse;
-import com.oronaminc.join.question.dto.QuestionCreateRequest;
+import com.oronaminc.join.question.dto.QuestionRequest;
 import com.oronaminc.join.question.dto.QuestionFlatResponse;
 import com.oronaminc.join.question.util.QuestionMapper;
 import com.oronaminc.join.room.domain.Room;
@@ -39,7 +39,7 @@ public class QuestionService {
     private final ParticipantReader participantReader;
 
     @Transactional
-    public Question create(Long roomId, Long memberId, QuestionCreateRequest requestDto) {
+    public Question create(Long roomId, Long memberId, QuestionRequest requestDto) {
 
         Member member = memberReader.getById(memberId);
 
@@ -78,8 +78,7 @@ public Slice<QuestionAssembleResponse> getQuestions(
     }
 
     @Transactional
-    public Question update(Long memberId, Long roomId, Long questionId,
-        QuestionCreateRequest request) {
+    public Question update(Long memberId, Long roomId, Long questionId, QuestionRequest request) {
         Question question = questionReader.getByIdAndRoomId(questionId, roomId);
 
         // 참여자가 아님

src/main/java/com/oronaminc/join/question/service/QuestionService.java

@@ -4,7 +4,7 @@
 import com.oronaminc.join.global.dto.WriterDto;
 import com.oronaminc.join.member.domain.Member;
 import com.oronaminc.join.question.domain.Question;
-import com.oronaminc.join.question.dto.QuestionCreateRequest;
+import com.oronaminc.join.question.dto.QuestionRequest;
 import com.oronaminc.join.question.dto.QuestionCreateResponse;
 import com.oronaminc.join.question.dto.QuestionDeleteResponse;
 import com.oronaminc.join.question.dto.QuestionFlatResponse;
@@ -19,7 +19,7 @@
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class QuestionMapper {
 
-    public static Question toQuestion(Room room, Member member, QuestionCreateRequest request) {
+    public static Question toQuestion(Room room, Member member, QuestionRequest request) {
         return Question.create(room, member, request);
     }
 

src/main/java/com/oronaminc/join/question/util/QuestionMapper.java

@@ -47,7 +47,7 @@ public EmojiResponse createEmoji(
     @SendTo("/topic/rooms/{roomId}/emojis")
     public EmojiResponse deleteEmoji(
         @DestinationVariable Long roomId,
-        @Payload EmojiRequest emojiRequest,
+        @Payload @Valid EmojiRequest emojiRequest,
         Principal principal
     ) {
         Long memberId = Long.valueOf(principal.getName());

src/main/java/com/oronaminc/join/websocket/api/EmojiWebsocketController.java

@@ -1,22 +1,25 @@
 package com.oronaminc.join.websocket.api;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.oronaminc.join.member.security.MemberDetails;
+import com.oronaminc.join.global.exception.ErrorCode;
+import com.oronaminc.join.global.exception.ErrorException;
+import com.oronaminc.join.global.ratelimit.RateLimitService;
+import com.oronaminc.join.global.ratelimit.RateLimitType;
 import com.oronaminc.join.question.domain.Question;
-import com.oronaminc.join.question.dto.QuestionCreateRequest;
 import com.oronaminc.join.question.dto.QuestionCreateResponse;
 import com.oronaminc.join.question.dto.QuestionDeleteResponse;
+import com.oronaminc.join.question.dto.QuestionRequest;
 import com.oronaminc.join.question.dto.QuestionUpdateResponse;
-import com.oronaminc.join.question.util.QuestionMapper;
 import com.oronaminc.join.question.service.QuestionService;
+import com.oronaminc.join.question.util.QuestionMapper;
+import io.github.bucket4j.Bucket;
+import jakarta.validation.Valid;
 import java.security.Principal;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.messaging.handler.annotation.DestinationVariable;
 import org.springframework.messaging.handler.annotation.MessageMapping;
 import org.springframework.messaging.handler.annotation.Payload;
 import org.springframework.messaging.handler.annotation.SendTo;
-import org.springframework.security.core.Authentication;
 import org.springframework.stereotype.Controller;
 
 @Slf4j
@@ -25,18 +28,23 @@
 public class QuestionWebsocketController {
 
     private final QuestionService questionService;
-    private final ObjectMapper objectMapper;
+    private final RateLimitService rateLimitService;
 
     @MessageMapping("/rooms/{roomId}/questions/create")
     @SendTo("/topic/rooms/{roomId}/questions")
-    public QuestionCreateResponse create(
+    public QuestionCreateResponse createQuestion(
         @DestinationVariable Long roomId,
-        @Payload QuestionCreateRequest request,
+        @Payload @Valid QuestionRequest request,
         Principal principal
     ) {
-
         Long memberId = Long.valueOf(principal.getName());
 
+        Bucket bucket = rateLimitService.getBucket(RateLimitType.CREATE_QUESTION, roomId, memberId);
+
+        if (!bucket.tryConsume(1)) {
+            throw new ErrorException(ErrorCode.TOO_MANY_REQUESTS_QUESTION);
+        }
+
         Question question = questionService.create(roomId, memberId, request);
 
         log.info("수신한 메시지 = {}", request.content());
@@ -46,13 +54,12 @@ public QuestionCreateResponse create(
 
     @MessageMapping("/rooms/{roomId}/questions/{questionId}/update")
     @SendTo("/topic/rooms/{roomId}/questions")
-    public QuestionUpdateResponse update(
+    public QuestionUpdateResponse updateQuestion(
         @DestinationVariable Long roomId,
         @DestinationVariable Long questionId,
-        @Payload QuestionCreateRequest request,
+        @Payload @Valid QuestionRequest request,
         Principal principal
     ) {
-
         Long memberId = Long.valueOf(principal.getName());
 
         Question updated = questionService.update(memberId, roomId, questionId, request);
@@ -62,12 +69,11 @@ public QuestionUpdateResponse update(
 
     @MessageMapping("rooms/{roomId}/questions/{questionId}/delete")
     @SendTo("/topic/rooms/{roomId}/questions")
-    public QuestionDeleteResponse delete(
+    public QuestionDeleteResponse deleteQuestion(
         @DestinationVariable Long roomId,
         @DestinationVariable Long questionId,
         Principal principal
     ) {
-
         Long memberId = Long.valueOf(principal.getName());
 
         Long deletedId = questionService.delete(memberId, roomId, questionId);

src/main/java/com/oronaminc/join/websocket/api/QuestionWebsocketController.java

@@ -21,8 +21,8 @@
 import com.oronaminc.join.question.domain.Question;
 import com.oronaminc.join.question.domain.QuestionSort;
 import com.oronaminc.join.question.dto.QuestionAssembleResponse;
-import com.oronaminc.join.question.dto.QuestionCreateRequest;
 import com.oronaminc.join.question.dto.QuestionFlatResponse;
+import com.oronaminc.join.question.dto.QuestionRequest;
 import com.oronaminc.join.room.domain.Room;
 import com.oronaminc.join.room.domain.RoomStatus;
 import com.oronaminc.join.room.service.RoomReader;
@@ -66,7 +66,7 @@ class QuestionServiceTests {
 
     private Room mockRoom;
     private Member mockMember;
-    private QuestionCreateRequest request;
+    private QuestionRequest request;
     private QuestionFlatResponse mockQ1;
     private QuestionFlatResponse mockQ2;
 
@@ -93,7 +93,7 @@ void setUp() {
             .roomStatus(RoomStatus.STARTED)
             .build();
 
-        request = new QuestionCreateRequest("질문입니다");
+        request = new QuestionRequest("질문입니다");
 
         mockQ1 = QuestionFlatResponse.builder()
             .questionId(1L)