Feat: 스터디룸 로직 보완 및 테스트 코드 작성 (#56) (#85)

* feat: dto 도입과 스터디룸 설정 외부화

* feat: 상태 검증, n+1 문제 해결, 동시성 제어 추가

* refactor: 스터디룸 레퍼지토리 쿼리dsl 타입으로 안정성 추가

* refactor: 스터디름 스웨거 어노테이션 추가

* Test: 지금까지 만들어왔던 테스트코드 정리

* Test: 테스트 룸 컨트롤러단에서 SecurityConfig 제외

* Test:룸 컨트롤러 webMvcTest제거, 단위테스트로 진행

* fix: 코드리뷰 받은 문서파일 제거

Author: loseminho

build.gradle.kts

@@ -28,6 +28,7 @@ dependencies {
     // Spring
     implementation("org.springframework.boot:spring-boot-starter-web")
     implementation("org.springframework.boot:spring-boot-starter-websocket")
+    implementation("org.springframework.boot:spring-boot-starter-validation")
 
     // Database & JPA
     implementation("org.springframework.boot:spring-boot-starter-data-jpa")

src/main/java/com/back/domain/studyroom/config/StudyRoomProperties.java

@@ -0,0 +1,31 @@
+package com.back.domain.studyroom.config;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.stereotype.Component;
+
+@Getter
+@Setter
+@Component
+@ConfigurationProperties(prefix = "studyroom")
+public class StudyRoomProperties {
+    
+    private Heartbeat heartbeat = new Heartbeat();
+    private Default defaultSettings = new Default();
+    
+    @Getter
+    @Setter
+    public static class Heartbeat {
+        private int timeoutMinutes = 5;
+    }
+    
+    @Getter
+    @Setter
+    public static class Default {
+        private int maxParticipants = 10;
+        private boolean allowCamera = true;
+        private boolean allowAudio = true;
+        private boolean allowScreenShare = true;
+    }
+}

src/main/java/com/back/domain/studyroom/controller/RoomController.java

@@ -0,0 +1,26 @@
+package com.back.domain.studyroom.dto;
+
+import jakarta.validation.constraints.*;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+@Getter
+@NoArgsConstructor
+@AllArgsConstructor
+public class CreateRoomRequest {
+    @NotBlank(message = "방 제목은 필수입니다")
+    @Size(max = 100, message = "방 제목은 100자를 초과할 수 없습니다")
+    private String title;
+    
+    @Size(max = 500, message = "방 설명은 500자를 초과할 수 없습니다")
+    private String description;
+    
+    private Boolean isPrivate = false;
+    
+    private String password;
+    
+    @Min(value = 2, message = "최소 2명 이상이어야 합니다")
+    @Max(value = 100, message = "최대 100명까지 가능합니다")
+    private Integer maxParticipants = 10;
+}

src/main/java/com/back/domain/studyroom/dto/CreateRoomRequest.java

@@ -0,0 +1,12 @@
+package com.back.domain.studyroom.dto;
+
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+@Getter
+@NoArgsConstructor
+@AllArgsConstructor
+public class JoinRoomRequest {
+    private String password;
+}

src/main/java/com/back/domain/studyroom/dto/JoinRoomRequest.java

@@ -0,0 +1,26 @@
+package com.back.domain.studyroom.dto;
+
+import com.back.domain.studyroom.entity.RoomMember;
+import com.back.domain.studyroom.entity.RoomRole;
+import lombok.Builder;
+import lombok.Getter;
+
+import java.time.LocalDateTime;
+
+@Getter
+@Builder
+public class JoinRoomResponse {
+    private Long roomId;
+    private Long userId;
+    private RoomRole role;
+    private LocalDateTime joinedAt;
+    
+    public static JoinRoomResponse from(RoomMember member) {
+        return JoinRoomResponse.builder()
+                .roomId(member.getRoom().getId())
+                .userId(member.getUser().getId())
+                .role(member.getRole())
+                .joinedAt(member.getJoinedAt())
+                .build();
+    }
+}

src/main/java/com/back/domain/studyroom/dto/JoinRoomResponse.java

@@ -0,0 +1,35 @@
+package com.back.domain.studyroom.dto;
+
+import com.back.domain.studyroom.entity.Room;
+import com.back.domain.studyroom.entity.RoomRole;
+import com.back.domain.studyroom.entity.RoomStatus;
+import lombok.Builder;
+import lombok.Getter;
+
+import java.time.LocalDateTime;
+
+@Getter
+@Builder
+public class MyRoomResponse {
+    private Long roomId;
+    private String title;
+    private String description;
+    private int currentParticipants;
+    private int maxParticipants;
+    private RoomStatus status;
+    private RoomRole myRole;
+    private LocalDateTime createdAt;
+    
+    public static MyRoomResponse of(Room room, RoomRole myRole) {
+        return MyRoomResponse.builder()
+                .roomId(room.getId())
+                .title(room.getTitle())
+                .description(room.getDescription() != null ? room.getDescription() : "")
+                .currentParticipants(room.getCurrentParticipants())
+                .maxParticipants(room.getMaxParticipants())
+                .status(room.getStatus())
+                .myRole(myRole)
+                .createdAt(room.getCreatedAt())
+                .build();
+    }
+}

src/main/java/com/back/domain/studyroom/dto/MyRoomResponse.java

@@ -0,0 +1,45 @@
+package com.back.domain.studyroom.dto;
+
+import com.back.domain.studyroom.entity.Room;
+import com.back.domain.studyroom.entity.RoomStatus;
+import lombok.Builder;
+import lombok.Getter;
+
+import java.time.LocalDateTime;
+import java.util.List;
+
+@Getter
+@Builder
+public class RoomDetailResponse {
+    private Long roomId;
+    private String title;
+    private String description;
+    private boolean isPrivate;
+    private int maxParticipants;
+    private int currentParticipants;
+    private RoomStatus status;
+    private boolean allowCamera;
+    private boolean allowAudio;
+    private boolean allowScreenShare;
+    private String createdBy;
+    private LocalDateTime createdAt;
+    private List<RoomMemberResponse> members;
+    
+    public static RoomDetailResponse of(Room room, List<RoomMemberResponse> members) {
+        return RoomDetailResponse.builder()
+                .roomId(room.getId())
+                .title(room.getTitle())
+                .description(room.getDescription() != null ? room.getDescription() : "")
+                .isPrivate(room.isPrivate())
+                .maxParticipants(room.getMaxParticipants())
+                .currentParticipants(room.getCurrentParticipants())
+                .status(room.getStatus())
+                .allowCamera(room.isAllowCamera())
+                .allowAudio(room.isAllowAudio())
+                .allowScreenShare(room.isAllowScreenShare())
+                .createdBy(room.getCreatedBy().getNickname())
+                .createdAt(room.getCreatedAt())
+                .members(members)
+                .build();
+    }
+}

src/main/java/com/back/domain/studyroom/dto/RoomDetailResponse.java

@@ -0,0 +1,30 @@
+package com.back.domain.studyroom.dto;
+
+import com.back.domain.studyroom.entity.RoomMember;
+import com.back.domain.studyroom.entity.RoomRole;
+import lombok.Builder;
+import lombok.Getter;
+
+import java.time.LocalDateTime;
+
+@Getter
+@Builder
+public class RoomMemberResponse {
+    private Long userId;
+    private String nickname;
+    private RoomRole role;
+    private boolean isOnline;
+    private LocalDateTime joinedAt;
+    private LocalDateTime lastActiveAt;
+    
+    public static RoomMemberResponse from(RoomMember member) {
+        return RoomMemberResponse.builder()
+                .userId(member.getUser().getId())
+                .nickname(member.getUser().getNickname())
+                .role(member.getRole())
+                .isOnline(member.isOnline())
+                .joinedAt(member.getJoinedAt())
+                .lastActiveAt(member.getLastActiveAt() != null ? member.getLastActiveAt() : member.getJoinedAt())
+                .build();
+    }
+}

src/main/java/com/back/domain/studyroom/dto/RoomMemberResponse.java

@@ -0,0 +1,34 @@
+package com.back.domain.studyroom.dto;
+
+import com.back.domain.studyroom.entity.Room;
+import com.back.domain.studyroom.entity.RoomStatus;
+import lombok.Builder;
+import lombok.Getter;
+
+import java.time.LocalDateTime;
+
+@Getter
+@Builder
+public class RoomResponse {
+    private Long roomId;
+    private String title;
+    private String description;
+    private int currentParticipants;
+    private int maxParticipants;
+    private RoomStatus status;
+    private String createdBy;
+    private LocalDateTime createdAt;
+    
+    public static RoomResponse from(Room room) {
+        return RoomResponse.builder()
+                .roomId(room.getId())
+                .title(room.getTitle())
+                .description(room.getDescription() != null ? room.getDescription() : "")
+                .currentParticipants(room.getCurrentParticipants())
+                .maxParticipants(room.getMaxParticipants())
+                .status(room.getStatus())
+                .createdBy(room.getCreatedBy().getNickname())
+                .createdAt(room.getCreatedAt())
+                .build();
+    }
+}