Skip to content

Commit 0691dd6

Browse files
authored
fix : partyMissionCreateRequest 수정 (#112)
* 미션 코드 전체 수정 * ëãN+1 ë 문제 해결 * 미션 필요없는 메소드 삭제 * mission 리팩토링 & test 작성 * fix : partyMissionCreateRequest 수ì 정 * fix : partyMissionCreateRequest 수정
1 parent 77efdc4 commit 0691dd6

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

backend/src/main/java/com/back/domain/mission/dto/request/PartyMissionCreateRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.back.domain.mission.enums.MissionCategory;
44
import com.back.domain.mission.enums.MissionType;
5+
import com.fasterxml.jackson.annotation.JsonIgnore;
6+
import com.fasterxml.jackson.annotation.JsonProperty;
57
import jakarta.validation.constraints.*;
68
import lombok.*;
79

@@ -30,12 +32,15 @@ public class PartyMissionCreateRequest {
3032
@Max(value = 5, message = "최대 5명")
3133
private Integer maxMembers; // 1 = 개인미션, 2~5 = 파티미션
3234

35+
@JsonProperty("isPublic")
3336
private boolean isPublic = false; // 파티 공개 여부 (파티모집 게시판)
3437

3538

3639
//검증 어노테이션
40+
41+
@JsonIgnore
3742
@AssertTrue(message = "커스텀 미션은 카테고리가 필수입니다")
38-
public boolean isCategoryValid() {
43+
public boolean validateCategory() {
3944
return type != MissionType.CUSTOM || category != null;
4045
}
4146

backend/src/test/java/com/back/domain/mission/service/MissionServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ void createMission_CustomWithoutCategory_ThrowsException() {
557557
.maxMembers(1)
558558
.build();
559559

560-
assertThat(request.isCategoryValid()).isFalse();
560+
assertThat(request.validateCategory()).isFalse();
561561
}
562562

563563
@Test

0 commit comments

Comments
 (0)