Skip to content

Commit 513619c

Browse files
committed
refactor: Job 도메인 엔티티 @Setter 제거
1 parent 3eae4a5 commit 513619c

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

back/src/main/java/com/back/domain/job/job/entity/Job.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
import jakarta.persistence.*;
55
import lombok.Getter;
66
import lombok.NoArgsConstructor;
7-
import lombok.Setter;
87

8+
import java.util.ArrayList;
99
import java.util.List;
1010

1111
@Entity
1212
@Table(name = "job")
13-
@Getter @Setter
13+
@Getter
1414
@NoArgsConstructor
1515
public class Job extends BaseEntity {
1616
@Column(name = "name", nullable = false, unique = true)
@@ -20,15 +20,19 @@ public class Job extends BaseEntity {
2020
private String description;
2121

2222
@OneToMany(mappedBy = "job", cascade = CascadeType.ALL)
23-
private List<JobAlias> aliases;
23+
private List<JobAlias> aliases = new ArrayList<>();
2424

2525
public Job(String name, String description) {
2626
this.name = name;
2727
this.description = description;
28+
this.aliases = new ArrayList<>();
2829
}
2930

3031
public void addAlias(JobAlias alias) {
32+
if (aliases == null) {
33+
aliases = new ArrayList<>();
34+
}
3135
aliases.add(alias);
32-
alias.setJob(this);
36+
alias.linkToJob(this);
3337
}
3438
}

back/src/main/java/com/back/domain/job/job/entity/JobAlias.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
import jakarta.persistence.*;
55
import lombok.Getter;
66
import lombok.NoArgsConstructor;
7-
import lombok.Setter;
87

98
@Entity
109
@Table(name = "job_alias")
11-
@Getter @Setter
10+
@Getter
1211
@NoArgsConstructor
1312
public class JobAlias extends BaseEntity {
1413
@Column(name = "name", nullable = false, unique = true)
@@ -22,4 +21,12 @@ public JobAlias(String name) {
2221
this.name = name;
2322
this.job = null; // 기본적으로 연결된 Job이 없음 (pending 상태)
2423
}
24+
25+
public void linkToJob(Job job) {
26+
this.job = job;
27+
}
28+
29+
public boolean isPending() {
30+
return this.job == null;
31+
}
2532
}

back/src/main/java/com/back/domain/job/job/service/JobService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public Job create(String name, String description) {
2828
@Transactional
2929
public JobAlias createAlias(Job job, String aliasName) {
3030
JobAlias alias = new JobAlias(aliasName);
31-
alias.setJob(job);
31+
job.addAlias(alias);
3232
return jobAliasRepository.save(alias);
3333
}
3434
}

0 commit comments

Comments
 (0)