Skip to content

Commit 58c4eee

Browse files
authored
Merge pull request #284 from prgrms-web-devcourse-final-project/develop
Fix/274 (#283)
2 parents 63ec9fe + 25df2ee commit 58c4eee

File tree

6 files changed

+28
-16
lines changed

6 files changed

+28
-16
lines changed

back/src/main/java/com/back/domain/file/video/controller/VideoController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public RsData<UploadUrlGetResponse> getUploadUrl(@RequestParam String filename)
3131
uuid = matcher.group(1);
3232
}
3333

34-
UploadUrlGetResponse response = new UploadUrlGetResponse(uuid, uploadUrl.expiresAt());
34+
UploadUrlGetResponse response = new UploadUrlGetResponse(uploadUrl.url().toString(), uuid, uploadUrl.expiresAt());
3535
return new RsData<>("200", "업로드용 URL 요청완료", response);
3636
}
3737

back/src/main/java/com/back/domain/file/video/dto/controller/UploadUrlGetResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.time.LocalDateTime;
44

55
public record UploadUrlGetResponse(
6+
String url,
67
String uuid,
78
LocalDateTime expiresAt
89
) {

back/src/main/java/com/back/domain/member/member/dto/MemberMeResponse.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ public record MemberMeResponse(
1010
String nickname,
1111
String role,
1212
Long mentorId,
13-
Long menteeId
13+
Long menteeId,
14+
String job // 직업명 추가
1415
) {
15-
public static MemberMeResponse of(Member member, Long mentorId, Long menteeId) {
16+
public static MemberMeResponse of(Member member, Long mentorId, Long menteeId, String job) {
1617
return new MemberMeResponse(
1718
member.getId(),
1819
member.getPublicId(),
@@ -21,7 +22,8 @@ public static MemberMeResponse of(Member member, Long mentorId, Long menteeId) {
2122
member.getNickname(),
2223
member.getRole().name(),
2324
mentorId,
24-
menteeId
25+
menteeId,
26+
job
2527
);
2628
}
2729
}

back/src/main/java/com/back/domain/member/member/service/MemberService.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -162,18 +162,23 @@ public MemberMeResponse getMemberMe(Member actor) {
162162

163163
Long mentorId = null;
164164
Long menteeId = null;
165+
String job = null;
165166

166167
if (actor.getRole() == Member.Role.MENTOR) {
167-
mentorId = mentorRepository.findByMemberId(actor.getId())
168-
.map(Mentor::getId)
169-
.orElse(null);
168+
Mentor mentor = mentorRepository.findByMemberIdWithMember(actor.getId()).orElse(null);
169+
if (mentor != null) {
170+
mentorId = mentor.getId();
171+
job = mentor.getJob() != null ? mentor.getJob().getName() : null;
172+
}
170173
} else if (actor.getRole() == Member.Role.MENTEE) {
171-
menteeId = menteeRepository.findByMemberId(actor.getId())
172-
.map(Mentee::getId)
173-
.orElse(null);
174+
Mentee mentee = menteeRepository.findByMemberId(actor.getId()).orElse(null);
175+
if (mentee != null) {
176+
menteeId = mentee.getId();
177+
job = mentee.getJob() != null ? mentee.getJob().getName() : null;
178+
}
174179
}
175180

176-
return MemberMeResponse.of(actor, mentorId, menteeId);
181+
return MemberMeResponse.of(actor, mentorId, menteeId, job);
177182
}
178183

179184
public Member refreshAccessToken(String refreshToken) {
@@ -203,7 +208,7 @@ public Member refreshAccessToken(String refreshToken) {
203208
}
204209

205210
public MenteeMyPageResponse getMenteeMyPage(Member currentUser) {
206-
Mentee mentee = menteeRepository.findByMemberId(currentUser.getId())
211+
Mentee mentee = menteeRepository.findByMemberIdWithMember(currentUser.getId())
207212
.orElseThrow(() -> new ServiceException("404-2", "멘티 정보를 찾을 수 없습니다."));
208213

209214
return MenteeMyPageResponse.from(currentUser, mentee);
@@ -223,7 +228,7 @@ public void updateMentee(Member currentUser, MenteeUpdateRequest request) {
223228

224229
// Mentee 정보 업데이트 (interestedField)
225230
if (request.interestedField() != null) {
226-
Mentee mentee = menteeRepository.findByMemberId(currentUser.getId())
231+
Mentee mentee = menteeRepository.findByMemberIdWithMember(currentUser.getId())
227232
.orElseThrow(() -> new ServiceException("404-2", "멘티 정보를 찾을 수 없습니다."));
228233

229234
Job job = jobRepository.findByName(request.interestedField())

back/src/main/java/com/back/domain/member/mentee/repository/MenteeRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public interface MenteeRepository extends JpaRepository<Mentee, Long> {
1212
@Query("SELECT m FROM Mentee m WHERE m.member.id = :memberId AND m.isDeleted = false")
1313
Optional<Mentee> findByMemberId(@Param("memberId") Long memberId);
1414

15-
@Query("SELECT m FROM Mentee m JOIN FETCH m.member WHERE m.member.id = :memberId AND m.isDeleted = false")
15+
@Query("SELECT m FROM Mentee m JOIN FETCH m.member LEFT JOIN FETCH m.job WHERE m.member.id = :memberId AND m.isDeleted = false")
1616
Optional<Mentee> findByMemberIdWithMember(@Param("memberId") Long memberId);
1717

1818
@Query("SELECT m FROM Mentee m WHERE m.id = :id AND m.isDeleted = false")

back/src/test/java/com/back/domain/member/member/controller/MemberAuthControllerTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,9 @@ void t5() throws Exception {
282282
.andExpect(jsonPath("$.data.email").value(email))
283283
.andExpect(jsonPath("$.data.nickname").value("멘티닉네임"))
284284
.andExpect(jsonPath("$.data.mentorId").isEmpty())
285-
.andExpect(jsonPath("$.data.menteeId").isNotEmpty());
285+
.andExpect(jsonPath("$.data.menteeId").isNotEmpty())
286+
.andExpect(jsonPath("$.data.job").isNotEmpty());
287+
286288
}
287289

288290
@Test
@@ -320,7 +322,9 @@ void t5_1() throws Exception {
320322
.andExpect(jsonPath("$.data.email").value(email))
321323
.andExpect(jsonPath("$.data.nickname").value("멘토닉네임"))
322324
.andExpect(jsonPath("$.data.mentorId").isNotEmpty())
323-
.andExpect(jsonPath("$.data.menteeId").isEmpty());
325+
.andExpect(jsonPath("$.data.menteeId").isEmpty())
326+
.andExpect(jsonPath("$.data.job").isNotEmpty());
327+
324328
}
325329

326330
@Test

0 commit comments

Comments
 (0)