Skip to content

Commit e3f8c37

Browse files
authored
Merge pull request #301 from prgrms-web-devcourse-final-project/develop
메인 머지(10/14)
2 parents 101c0c7 + 74129d9 commit e3f8c37

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

back/src/main/java/com/back/domain/mentoring/reservation/service/ReservationService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,11 @@ public ReservationResponse getReservation(Member member, Long reservationId) {
5656
Reservation reservation = reservationRepository.findByIdAndMember(reservationId, member.getId())
5757
.orElseThrow(() -> new ServiceException(ReservationErrorCode.RESERVATION_NOT_ACCESSIBLE));
5858

59-
MentoringSession mentoringSession = mentoringSessionService.getMentoringSessionByReservation(reservation);
59+
Optional<MentoringSession> mentoringSession = mentoringSessionService.findMentoringSessionByReservation(reservation);
6060

61-
return ReservationResponse.from(reservation, mentoringSession);
61+
return mentoringSession
62+
.map(session -> ReservationResponse.from(reservation, session))
63+
.orElseGet(() -> ReservationResponse.from(reservation));
6264
}
6365

6466
@Transactional

back/src/main/java/com/back/domain/mentoring/session/service/MentoringSessionService.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
import lombok.RequiredArgsConstructor;
99
import org.springframework.stereotype.Service;
1010

11+
import java.util.Optional;
12+
1113
@Service
1214
@RequiredArgsConstructor
1315
public class MentoringSessionService {
@@ -28,6 +30,10 @@ public MentoringSession getMentoringSessionByReservation(Reservation reservation
2830
.orElseThrow(() -> new ServiceException("404", "해당 예약의 세션이 없습니다."));
2931
}
3032

33+
public Optional<MentoringSession> findMentoringSessionByReservation(Reservation reservation) {
34+
return mentoringSessionRepository.findByReservation((reservation));
35+
}
36+
3137
public MentoringSession getMentoringSessionByMentoring(Mentoring mentoring) {
3238
return mentoringSessionRepository.findByMentoring(mentoring)
3339
.orElseThrow(() -> new ServiceException("404", "해당 멘토링의 세션이 없습니다."));

back/src/main/java/com/back/global/initData/RoadmapProdInitData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void runInitData() {
6666
log.info(">>> Step 3: JobRoadmap 샘플 데이터 생성 완료");
6767
} catch (Exception e) {
6868
log.error("JobRoadmap 샘플 데이터 생성 실패", e);
69-
throw e;
69+
//throw e;
7070
}
7171

7272
// 통합 로직 테스트

back/src/test/java/com/back/domain/mentoring/reservation/service/ReservationServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ void getReservation() {
135135
when(reservationRepository.findByIdAndMember(reservationId, mentor.getMember().getId()))
136136
.thenReturn(Optional.of(reservation));
137137
MentoringSession session = MentoringSessionFixture.create(reservation);
138-
when(mentoringSessionService.getMentoringSessionByReservation(reservation)).thenReturn(session);
138+
when(mentoringSessionService.findMentoringSessionByReservation(reservation)).thenReturn(Optional.ofNullable(session));
139139

140140
// when
141141
ReservationResponse response = reservationService.getReservation(

0 commit comments

Comments
 (0)