Skip to content

Commit 02d0bc5

Browse files
authored
refactor: s3 prefix separation (#131)
* refactor: S3 prefix 환경변수 분리 및 server 프로파일 설정 추가 * fix: cd 오타 수정 * fix : docker run 주석 없앰
1 parent 4725a91 commit 02d0bc5

File tree

3 files changed

+9
-24
lines changed

3 files changed

+9
-24
lines changed

.github/workflows/prod-server.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,37 +86,28 @@ jobs:
8686
-e SPRING_DATASOURCE_URL="${{secrets.PROD_DB_URL}}" \
8787
-e SPRING_DATASOURCE_USERNAME="${{secrets.PROD_DB_USERNAME}}" \
8888
-e SPRING_DATASOURCE_PASSWORD="${{secrets.PROD_DB_PASSWORD}}" \
89-
# AWS
9089
-e AWS_ACCESS_KEY_ID="${{secrets.AWS_ACCESS_KEY_ID}}" \
9190
-e AWS_SECRET_ACCESS_KEY="${{secrets.AWS_SECRET_ACCESS_KEY}}" \
9291
-e AWS_S3_BUCKET_NAME="${{secrets.AWS_S3_BUCKET_NAME}}" \
93-
# RabbitMQ
92+
-e AWS_S3_PREFIX="${{secrets.PROD_AWS_S3_PREFIX}}" \
9493
-e SPRING_RABBITMQ_HOST="${{secrets.PROD_RABBITMQ_HOST}}" \
9594
-e SPRING_RABBITMQ_USERNAME="${{secrets.PROD_RABBITMQ_USERNAME}}" \
9695
-e SPRING_RABBITMQ_PASSWORD="${{secrets.PROD_RABBITMQ_PASSWORD}}" \
97-
# Redis
9896
-e REDIS_HOST="${{secrets.PROD_REDIS_HOST}}" \
9997
-e REDIS_PASSWORD="${{secrets.PROD_REDIS_PASSWORD}}" \
100-
# OAuth2
10198
-e KAKAO_CLIENT_ID="${{secrets.OAUTH_KAKAO_CLIENT_ID}}" \
10299
-e GOOGLE_CLIENT_ID="${{secrets.OAUTH_GOOGLE_CLIENT_ID}}" \
103100
-e GOOGLE_CLIENT_SECRET="${{secrets.OAUTH_GOOGLE_CLIENT_SECRET}}" \
104-
-e KAKAO_REDIRECT_URI="${{PROD_OAUTH_KAKAO_REDIRECT_URI}}" \
105-
-e GOOGLE_REDIRECT_URI="${{PROD_OAUTH_GOOGLE_REDIRECT_URI}}" \
106-
# Sentry
101+
-e KAKAO_REDIRECT_URI="${{secrets.PROD_OAUTH_KAKAO_REDIRECT_URI}}" \
102+
-e GOOGLE_REDIRECT_URI="${{secrets.PROD_OAUTH_GOOGLE_REDIRECT_URI}}" \
107103
-e SENTRY_DSN="${{secrets.SENTRY_DSN}}" \
108-
# OpenAI
109104
-e OPENAI_API_KEY="${{secrets.OPENAI_API_KEY}}" \
110-
# Liveblocks
111105
-e LIVEBLOCKS_SECRET_KEY="${{secrets.LIVEBLOCKS_SECRET_KEY}}" \
112-
# naver
113106
-e NAVER_CLIENT_ID="${{secrets.NAVER_CLIENT_ID}}" \
114107
-e NAVER_CLIENT_SECRET="${{secrets.NAVER_CLIENT_SECRET}}" \
115-
# JWT
116108
-e JWT_SECRET_KEY="${{secrets.JWT_SECRET_KEY}}" \
117109
-e JWT_ACCESS_TOKEN_VALIDITY="${{secrets.JWT_ACCESS_TOKEN_VALIDITY}}" \
118110
-e JWT_REFRESH_TOKEN_VALIDITY="${{secrets.JWT_REFRESH_TOKEN_VALIDITY}}" \
119-
# Front
120111
-e FRONT_REDIRECT_DOMAIN="${{secrets.FRONT_REDIRECT_DOMAIN}}" \
121112
ghcr.io/${{ github.repository }}/zoopzoop:latest
122113

.github/workflows/test-server-cd.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,41 +60,31 @@ jobs:
6060
--name $NEW_CONTAINER \
6161
--network common \
6262
-e SPRING_PROFILES_ACTIVE=server \
63-
# DB
6463
-e SPRING_DATASOURCE_URL="${{secrets.TEST_DB_URL}}" \
6564
-e SPRING_DATASOURCE_USERNAME="${{secrets.TEST_DB_USERNAME}}" \
6665
-e SPRING_DATASOURCE_PASSWORD="${{secrets.TEST_DB_PASSWORD}}" \
67-
# AWS
6866
-e AWS_ACCESS_KEY_ID="${{secrets.AWS_ACCESS_KEY_ID}}" \
6967
-e AWS_SECRET_ACCESS_KEY="${{secrets.AWS_SECRET_ACCESS_KEY}}" \
70-
-e AWS_S3_BUCKET_NAME="${{secrets.AWS_S3_BUCKET_NAME}}" \
71-
# RabbitMQ
68+
-e AWS_S3_BUCKECT_NAME="${{secrets.AWS_S3_BUCKET_NAME}}" \
69+
-e AWS_S3_PREFIX="${{secrets.TEST_AWS_S3_PREFIX}}" \
7270
-e SPRING_RABBITMQ_HOST="${{secrets.TEST_RABBITMQ_HOST}}" \
7371
-e SPRING_RABBITMQ_USERNAME="${{secrets.TEST_RABBITMQ_USERNAME}}" \
7472
-e SPRING_RABBITMQ_PASSWORD="${{secrets.TEST_RABBITMQ_PASSWORD}}" \
75-
# Redis
7673
-e REDIS_HOST="${{secrets.TEST_REDIS_HOST}}" \
7774
-e REDIS_PASSWORD="${{secrets.TEST_REDIS_PASSWORD}}" \
78-
# OAuth2
7975
-e KAKAO_CLIENT_ID="${{secrets.OAUTH_KAKAO_CLIENT_ID}}" \
8076
-e GOOGLE_CLIENT_ID="${{secrets.OAUTH_GOOGLE_CLIENT_ID}}" \
8177
-e GOOGLE_CLIENT_SECRET="${{secrets.OAUTH_GOOGLE_CLIENT_SECRET}}" \
8278
-e KAKAO_REDIRECT_URI="${{secrets.TEST_OAUTH_KAKAO_REDIRECT_URI}}" \
8379
-e GOOGLE_REDIRECT_URI="${{secrets.TEST_OAUTH_GOOGLE_REDIRECT_URI}}" \
84-
# Sentry
8580
-e SENTRY_DSN="${{secrets.SENTRY_DSN}}" \
86-
# OpenAI
8781
-e OPENAI_API_KEY="${{secrets.OPENAI_API_KEY}}" \
88-
# Liveblocks
8982
-e LIVEBLOCKS_SECRET_KEY="${{secrets.LIVEBLOCKS_SECRET_KEY}}" \
90-
# naver
9183
-e NAVER_CLIENT_ID="${{secrets.NAVER_CLIENT_ID}}" \
9284
-e NAVER_CLIENT_SECRET="${{secrets.NAVER_CLIENT_SECRET}}" \
93-
# JWT
9485
-e JWT_SECRET_KEY="${{secrets.JWT_SECRET_KEY}}" \
9586
-e JWT_ACCESS_TOKEN_VALIDITY="${{secrets.JWT_ACCESS_TOKEN_VALIDITY}}" \
9687
-e JWT_REFRESH_TOKEN_VALIDITY="${{secrets.JWT_REFRESH_TOKEN_VALIDITY}}" \
97-
# Front
9888
-e FRONT_REDIRECT_DOMAIN="${{secrets.FRONT_REDIRECT_DOMAIN}}" \
9989
ghcr.io/${{ github.repository }}/zoopzoop:latest
10090

src/main/resources/application-server.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,7 @@ sentry:
4040
environment: prod
4141
traces-sample-rate: 0.2
4242

43+
cloud:
44+
aws:
45+
s3:
46+
prefix: ${AWS_S3_PREFIX}

0 commit comments

Comments
 (0)