Skip to content

Commit db480d6

Browse files
EpicFnEpicFn
andauthored
fix : 스페이스, 사용자 목록 반환 시 항상 id 오름차순 정렬 (#94)
Co-authored-by: EpicFn <[email protected]>
1 parent 389cbf2 commit db480d6

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

src/main/java/org/tuna/zoopzoop/backend/domain/space/membership/repository/MembershipRepository.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@
1414
public interface MembershipRepository extends JpaRepository<Membership, Integer> {
1515
boolean existsByMemberAndSpace(Member member, Space space);
1616

17-
Page<Membership> findAllByMemberAndAuthority(Member member, Authority authority, Pageable pageable);
18-
Page<Membership> findAllByMemberAndAuthorityIsNot(Member member, Authority authority, Pageable pageable);
19-
Page<Membership> findAllByMember(Member member, Pageable pageable);
17+
Page<Membership> findAllByMemberAndAuthorityOrderById(Member member, Authority authority, Pageable pageable);
18+
Page<Membership> findAllByMemberAndAuthorityIsNotOrderById(Member member, Authority authority, Pageable pageable);
19+
Page<Membership> findAllByMemberOrderById(Member member, Pageable pageable);
2020

2121
List<Membership> findAllByMemberAndAuthority(Member member, Authority authority);
22+
List<Membership> findAllByMemberAndAuthorityOrderById(Member member, Authority authority);
2223
List<Membership> findAllByMemberAndAuthorityIsNot(Member member, Authority authority);
24+
List<Membership> findAllByMemberAndAuthorityIsNotOrderById(Member member, Authority authority);
2325
List<Membership> findAllByMember(Member member);
26+
List<Membership> findAllByMemberOrderById(Member member);
2427

2528
boolean existsByMemberAndSpaceAndAuthorityIsNot(Member member, Space space, Authority authority);
2629

@@ -29,8 +32,12 @@ public interface MembershipRepository extends JpaRepository<Membership, Integer>
2932
Optional<Membership> findByMemberAndSpace(Member member, Space space);
3033

3134
List<Membership> findAllBySpaceAndAuthority(Space space, Authority authority);
35+
List<Membership> findAllBySpaceAndAuthorityOrderById(Space space, Authority authority);
3236

3337
List<Membership> findAllBySpaceAndAuthorityIsNot(Space space, Authority authority);
38+
List<Membership> findAllBySpaceAndAuthorityIsNotOrderById(Space space, Authority authority);
3439

3540
long countBySpaceAndAuthority(Space space, Authority authority);
41+
42+
3643
}

src/main/java/org/tuna/zoopzoop/backend/domain/space/membership/service/MembershipService.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ public Membership findByMemberAndSpace(Member member, Space space) {
6060
*/
6161
public Page<Membership> findByMember(Member member, String state, Pageable pageable) {
6262
if (state.equalsIgnoreCase("PENDING")) {
63-
return membershipRepository.findAllByMemberAndAuthority(member, Authority.PENDING, pageable);
63+
return membershipRepository.findAllByMemberAndAuthorityOrderById(member, Authority.PENDING, pageable);
6464
} else if (state.equalsIgnoreCase("JOINED")) {
65-
return membershipRepository.findAllByMemberAndAuthorityIsNot(member, Authority.PENDING, pageable);
65+
return membershipRepository.findAllByMemberAndAuthorityIsNotOrderById(member, Authority.PENDING, pageable);
6666
} else {
67-
return membershipRepository.findAllByMember(member, pageable);
67+
return membershipRepository.findAllByMemberOrderById(member, pageable);
6868
}
6969
}
7070

@@ -76,11 +76,12 @@ public Page<Membership> findByMember(Member member, String state, Pageable pagea
7676
*/
7777
public List<Membership> findByMember(Member member, String state) {
7878
if (state.equalsIgnoreCase("PENDING")) {
79-
return membershipRepository.findAllByMemberAndAuthority(member, Authority.PENDING);
79+
return membershipRepository.findAllByMemberAndAuthorityOrderById(member, Authority.PENDING);
8080
} else if (state.equalsIgnoreCase("JOINED")) {
81-
return membershipRepository.findAllByMemberAndAuthorityIsNot(member, Authority.PENDING);
81+
return membershipRepository.findAllByMemberAndAuthorityIsNotOrderById(member, Authority.PENDING);
8282
} else {
83-
return membershipRepository.findAllByMember(member);
83+
List<Membership> memberships = membershipRepository.findAllByMemberOrderById(member);
84+
return memberships;
8485
}
8586
}
8687

@@ -90,7 +91,7 @@ public List<Membership> findByMember(Member member, String state) {
9091
* @return 해당 스페이스에 속한 초대 상태(PENDING)인 멤버십 목록
9192
*/
9293
public List<Membership> findInvitationsBySpace(Space space) {
93-
return membershipRepository.findAllBySpaceAndAuthority(space, Authority.PENDING);
94+
return membershipRepository.findAllBySpaceAndAuthorityOrderById(space, Authority.PENDING);
9495
}
9596

9697
/**
@@ -99,7 +100,7 @@ public List<Membership> findInvitationsBySpace(Space space) {
99100
* @return 해당 스페이스에 속한 가입 상태(JOINED)인 멤버십 목록
100101
*/
101102
public List<Membership> findMembersBySpace(Space space) {
102-
return membershipRepository.findAllBySpaceAndAuthorityIsNot(space, Authority.PENDING);
103+
return membershipRepository.findAllBySpaceAndAuthorityIsNotOrderById(space, Authority.PENDING);
103104
}
104105

105106
// ======================== 권한 조회 ======================== //

0 commit comments

Comments
 (0)