Skip to content

Commit 824bd3c

Browse files
committed
drop the mac build for now
1 parent fdfd747 commit 824bd3c

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

.github/workflows/build.yaml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,18 @@ jobs:
5454
mkdir -p dist/Interactive-BG-Remover/Models
5555
mv Models/place_models_here.txt dist/Interactive-BG-Remover/Models/
5656
57-
- name: Build executable (macOS)
58-
if: runner.os == 'macOS'
59-
run: |
60-
# mac has issues with --onedir. this is a cpu only build so we can use onefile as it produces smaller binaries than CUDA etc.
61-
pyinstaller --clean build_mac.spec
62-
mkdir -p dist/mac-bundle/Models
63-
mv dist/Interactive-BG-Remover dist/mac-bundle/
64-
cp Models/place_models_here.txt dist/mac-bundle/Models/
65-
mv dist/mac-bundle dist/Interactive-BG-Remover
57+
# dropped for now as i can't test, and splash screens don't work,
58+
# so i'm not sure how to let user know that pymatting is compiling, and the app hasn't crashed on first run
59+
#
60+
# - name: Build executable (macOS)
61+
# if: runner.os == 'macOS'
62+
# run: |
63+
# # mac has issues with --onedir. this is a cpu only build so we can use onefile as it produces smaller binaries than CUDA etc.
64+
# pyinstaller --clean build_mac.spec
65+
# mkdir -p dist/mac-bundle/Models
66+
# mv dist/Interactive-BG-Remover dist/mac-bundle/
67+
# cp Models/place_models_here.txt dist/mac-bundle/Models/
68+
# mv dist/mac-bundle dist/Interactive-BG-Remover
6669

6770
- name: Upload artifacts
6871
uses: actions/upload-artifact@v4

build_mac.spec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# -*- mode: python ; coding: utf-8 -*-
22

3+
# dropped for now because splash screens don't work
4+
# pymatting needs to compile on first run, and i'm unsure how to let user know this without a splash screen
5+
# compilation can take a minute or two
36

47
a = Analysis(
58
['backgroundremoval.py'],

build_win_linux.spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ exe = EXE(
3232
splash,
3333
[],
3434
exclude_binaries=True,
35-
name='Interactive-BG-Remover-onedir',
35+
name='Interactive-BG-Remover',
3636
debug=False,
3737
bootloader_ignore_signals=False,
3838
strip=False,

0 commit comments

Comments
 (0)