Memory Leak in BaseComponent

[LoaderB0T]

Describe the bug

3 months ago, a previously fixed memory leak in the BaseComponent of all primeng controls was reintroduced.

This leads to raising memory & degraded performance over time, especially in large applications.

Pull Request Link

#19250

Reason for not contributing a PR

• Lack of time
• Unsure how to implement the fix/feature
• Difficulty understanding the codebase
• Other

Other Reason

No response

Reproducer

https://primeng.org (can be reproduced everywhere, follow repro stept)

Environment

The (at the time of writing) latest main branch has the issue and the released v21 version aswell.
The issue was reintroduced here: 9b5c3c7#diff-315219ce5e29cd6185c317544d0a096d9f46f310d322405400a1fdd72f0737f8

Angular version

21.0.5

PrimeNG version

v21

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

The issue can be easily reproduced on the primeng docs page.

My repro steps:

1. serve the app locally (for unobfuscaded code)
2. open the docs at http://localhost:4200/colorpicker
3. reload the page for clean memory
4. open the dev tools
5. navigate to the memory in dev tools and force a garbage collection
6. create a heap snapshot
7. in the primeng docs navigate to the datepicker section, wait until it has loaded & then navigate back to the color picker
8. in the devtools force anther garbace collection
9. take another heap snapshot
10. compare snapshot one with two (objects allocated between snapshot 1 and snapshot 2)
11. Search for "date"

The result will show 33 retained instances of the datepicker component, including their DOM nodes.

Expected behavior

With my fix, no component instances are retained anymore:

[rosenthalj]

I believe this is a duplicate of issue fix #19215 pull request #19220 will fix this issue.

[LoaderB0T]

Hi @rosenthalj
It seems so, yes! I did not find your issue & PR because it specifically mentioned the accordion, but the issue affects all components, though.
Also, my proposed fix seems a bit more minimal / true to the previous code & the previously merged fix: #17645

[rosenthalj]

@LoaderB0T
In the body of Issue #19215 I mention that there may be other memory leaks and I tested a few components and found that table had a memory leak. My PR #19220 confirms this is an issue throughout PrimeNG components. Your issue has a much better title. If "I were in your shoes" I probably would have created a new issue.

Taking a quick look at your PR #19250, I believe that your changes probably fixes the issue (I did not verify). Unlike my proposed fix #19220, there is the possibility that duplicate listeners could be created.

Regardless, I am happy with any code change that fixes this problem. I was hoping a fix would have been implemented a few weeks ago.

[LoaderB0T]

I favor the solution of @rosenthalj #19220 and closed my pr.

[rosenthalj]

@mertsincan

Please don't forget about issue: v21 DynamicDialog Memory Leak #19227. This is also a memory leak but is independent of this issue.

Note: PR #19228 fixes the DynamicDialog Memory

[Viktor-Ivliev]

It would be cool to add this:
https://github.com/orgs/primefaces/discussions/4577

[LoaderB0T]

@Viktor-Ivliev did you mean to add this comment here? Can't see how these are related.