Removing v2 color mode css variable fallbacks (#1579)

jonrohan · web-flow · commit c3b4a0c36302 · 2021-09-09T10:11:45.000+09:00
* Removing v2 color mode fallbacks

* Create shaggy-shirts-camp.md
diff --git a/.changeset/shaggy-shirts-camp.md b/.changeset/shaggy-shirts-camp.md
@@ -0,0 +1,5 @@
+---
+"@primer/css": minor
+---
+
+Removing v2 color mode css var fallbacks. `var(--color-v2, var(--color-v1))` becomes `var(--color-v2)`
diff --git a/src/forms/form-control.scss b/src/forms/form-control.scss
@@ -130,7 +130,7 @@ textarea.form-control {
       // stylelint-disable-next-line primer/spacing
       padding: 2px $spacer-1;
       font-style: normal;
-      background: var(--color-attention-subtle, var(--color-auto-yellow-1));
+      background: var(--color-attention-subtle);
       border-radius: $border-radius;
     }
   }
diff --git a/src/progress/progress.scss b/src/progress/progress.scss
@@ -4,7 +4,7 @@
   display: flex;
   height: 8px;
   overflow: hidden;
-  background-color: var(--color-neutral-muted, var(--color-auto-gray-2));
+  background-color: var(--color-neutral-muted);
   border-radius: $border-radius;
   outline: 1px solid transparent; // Support Firefox custom colors
 }
diff --git a/src/timeline/timeline-item.scss b/src/timeline/timeline-item.scss
@@ -41,8 +41,8 @@
   flex-shrink: 0;
 
   &--success {
-    color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback
-    background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback
+    color: var(--color-fg-on-emphasis);
+    background-color: var(--color-success-emphasis);
     border: $border-width $border-style transparent;
   }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@primer/css": minor
 +---
++
 +Removing v2 color mode css var fallbacks. `var(--color-v2, var(--color-v1))` becomes `var(--color-v2)`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ textarea.form-control {`
`130`	`130`	`// stylelint-disable-next-line primer/spacing`
`131`	`131`	`padding: 2px $spacer-1;`
`132`	`132`	`font-style: normal;`
`133`		`- background: var(--color-attention-subtle, var(--color-auto-yellow-1));`
	`133`	`+ background: var(--color-attention-subtle);`
`134`	`134`	`border-radius: $border-radius;`
`135`	`135`	`}`
`136`	`136`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`display: flex;`
`5`	`5`	`height: 8px;`
`6`	`6`	`overflow: hidden;`
`7`		`- background-color: var(--color-neutral-muted, var(--color-auto-gray-2));`
	`7`	`+ background-color: var(--color-neutral-muted);`
`8`	`8`	`border-radius: $border-radius;`
`9`	`9`	`outline: 1px solid transparent; // Support Firefox custom colors`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,8 @@`
`41`	`41`	`flex-shrink: 0;`
`42`	`42`
`43`	`43`	`&--success {`
`44`		`- color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback`
`45`		`- background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback`
	`44`	`+ color: var(--color-fg-on-emphasis);`
	`45`	`+ background-color: var(--color-success-emphasis);`
`46`	`46`	`border: $border-width $border-style transparent;`
`47`	`47`	`}`
`48`	`48`	`}`