Skip to content

Commit e9b7606

Browse files
authored
Merge pull request #453 from primer/release-10.4.0
Release 10.4.0
2 parents 81825ff + b6c9841 commit e9b7606

File tree

13 files changed

+46
-21
lines changed

13 files changed

+46
-21
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.
88

9-
Before you do, would you mind reading [this license agreement](CLA.md)? If you open a PR, we'll assume you agree to it. If you have any hesitation or disagreement, please do open a PR still, but note your concerns as well.
10-
119
## Using the issue tracker
1210

1311
The issue tracker is the preferred channel for [bug reports](#bug-reports), [features requests](#feature-requests) and [submitting pull requests](#pull-requests), but please respect the following restrictions:
@@ -28,7 +26,7 @@ Guidelines for bug reports:
2826

2927
2. **Check if the issue has been fixed** — try to reproduce it using the latest `master` or development branch in the repository.
3028

31-
3. **Isolate the problem** — ideally create a [reduced test case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
29+
3. **Isolate the problem** — ideally create a [reduced test case](https://css-tricks.com/reduced-test-cases/) and a live example.
3230

3331
A good bug report shouldn't leave others needing to chase you up for more information. Please try to be as detailed as possible in your report. What is your environment? What steps will reproduce the issue? What browser(s) and OS experience the problem? Do other browsers show the bug differently? What would you expect to be the outcome? All these details will help people to fix any potential bugs.
3432

@@ -59,7 +57,7 @@ Good pull requests—patches, improvements, new features—are a fantastic help.
5957

6058
### Updating Primer modules
6159

62-
Anyone can open a pull request on Primer. You do not need to work at GitHub or be a member of the org to open a pull request.
60+
Anyone can open a pull request on Primer. You do not need to work at GitHub or be a member of the org to open a pull request.
6361

6462
1. Fork and clone [this repository](https://github.com/primer/primer).
6563
2. Configure and install the dependencies: `npm install`

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# 10.4.0 (2018-03-14)
2+
3+
#### :rocket: Enhancement
4+
* [#456](https://github.com/primer/primer/pull/456) Adding height-fit utility class. ([@jonrohan](https://github.com/jonrohan))
5+
6+
#### :memo: Documentation
7+
* [#455](https://github.com/primer/primer/pull/455) Add colorizeTooltip deprecation warning. ([@jonrohan](https://github.com/jonrohan))
8+
* [#452](https://github.com/primer/primer/pull/452) Update dead links in CONTRIBUTING.md. ([@agisilaos](https://github.com/agisilaos))
9+
10+
#### Committers: 3
11+
- Agisilaos Tsaraboulidis ([agisilaos](https://github.com/agisilaos))
12+
- Jon Rohan ([jonrohan](https://github.com/jonrohan))
13+
- [muan](https://github.com/muan)
14+
115
# 10.3.0 (2018-01-17)
216

317
#### :rocket: Enhancement

modules/primer-base/lib/base.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,6 @@ details {
7373

7474
&:not([open]) {
7575
// Set details content hidden by default for browsers that don't do this
76-
> *:not(summary) { display: none; }
76+
> *:not(summary) { display: none !important; }
7777
}
7878
}

modules/primer-base/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.6.3",
2+
"version": "1.7.0",
33
"name": "primer-base",
44
"description": "CSS to reset the browsers default styles",
55
"homepage": "http://primer.github.io/",

modules/primer-core/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "6.7.0",
2+
"version": "6.8.0",
33
"name": "primer-core",
44
"description": "Primer's core modules",
55
"homepage": "http://primer.github.io/",
@@ -27,7 +27,7 @@
2727
"lint": "../../script/lint-scss"
2828
},
2929
"dependencies": {
30-
"primer-base": "1.6.3",
30+
"primer-base": "1.7.0",
3131
"primer-box": "2.5.5",
3232
"primer-breadcrumb": "1.5.1",
3333
"primer-buttons": "2.5.3",
@@ -36,8 +36,8 @@
3636
"primer-navigation": "1.5.3",
3737
"primer-support": "4.5.2",
3838
"primer-table-object": "1.4.5",
39-
"primer-tooltips": "1.5.2",
39+
"primer-tooltips": "1.5.3",
4040
"primer-truncate": "1.4.5",
41-
"primer-utilities": "4.8.5"
41+
"primer-utilities": "4.9.0"
4242
}
4343
}

modules/primer-tooltips/lib/tooltips.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,3 +311,4 @@
311311
border-left-color: $background-color;
312312
}
313313
}
314+
@warn "the colorizeTooltip mixin will be deprecated in version 11.";

modules/primer-tooltips/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.5.2",
2+
"version": "1.5.3",
33
"name": "primer-tooltips",
44
"description": "Add tooltips built entirely in CSS to nearly any element.",
55
"homepage": "http://primer.github.io/",

modules/primer-utilities/docs/layout.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,16 @@ Use `.width-full` to set width to 100%.
156156
</div>
157157
```
158158

159+
Use `.height-fit` to set max-height 100%.
160+
161+
```html
162+
<div class="one-fourth column" style="height: 100px; overflow: auto;">
163+
<div class="p-3 height-fit border">
164+
Bacon ipsum dolor amet meatball flank beef tail pig boudin ham hock chicken capicola. Shoulder ham spare ribs turducken pork tongue. Bresaola corned beef sausage jowl ribeye kielbasa tenderloin andouille leberkas tongue. Ribeye tri-tip tenderloin pig, chuck ground round chicken tongue corned beef biltong.
165+
</div>
166+
</div>
167+
```
168+
159169
Use `.height-full` to set height to 100%.
160170

161171
```html

modules/primer-utilities/lib/layout.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@
7676
.width-fit { max-width: 100% !important; }
7777
/* Set the width to 100% */
7878
.width-full { width: 100% !important; }
79+
/* Max height 100% */
80+
.height-fit { max-height: 100% !important; }
7981
/* Set the height to 100% */
8082
.height-full { height: 100% !important; }
8183

modules/primer-utilities/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "4.8.5",
2+
"version": "4.9.0",
33
"name": "primer-utilities",
44
"description": "Immutable, atomic CSS classes to rapidly build product",
55
"homepage": "http://primer.github.io/",

0 commit comments

Comments
 (0)