Skip to content

Commit 0369cb8

Browse files
authored
no-system-props: Add position as allowed prop for Dialog (#145)
* Add position as allowed prop for Dialog * Create short-kings-tease.md
1 parent 0e46b07 commit 0369cb8

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.changeset/short-kings-tease.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"eslint-plugin-primer-react": patch
3+
---
4+
5+
no-system-props: Add `position` as allowed prop for `Dialog`

src/rules/no-system-props.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const excludedComponentProps = new Map([
2121
['Blankslate', new Set(['border'])],
2222
['Button', new Set(['alignContent'])],
2323
['CircleOcticon', new Set(['size'])],
24-
['Dialog', new Set(['width', 'height'])],
24+
['Dialog', new Set(['width', 'height', 'position'])],
2525
['IssueLabelToken', new Set(['size'])],
2626
['Overlay', new Set(['width', 'height', 'maxHeight', 'position', 'top', 'right', 'bottom', 'left'])],
2727
['ProgressBar', new Set(['bg'])],

0 commit comments

Comments
 (0)