Merge pull request #22 from primer/dmarcey/ignore-non-literal-non-string-args

Ignore non-literal, non-string arguments to `themeGet` in `no-deprecated-colors` rule

Author: dmarcey

.changeset/friendly-months-hope.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-primer-react": patch
+---
+
+Ignore non-literal, non-string arguments to `themeGet` in `no-deprecated-colors` rule

src/rules/__tests__/no-deprecated-colors.test.js

@@ -31,6 +31,8 @@ ruleTester.run('no-deprecated-colors', rule, {
     `import {Box} from "@primer/components"; <Box color="fg.default">Hello</Box>`,
     `import {hello} from "@primer/components"; hello("colors.text.primary")`,
     `import {themeGet} from "@primer/components"; themeGet("space.text.primary")`,
+    `import {themeGet} from "@primer/components"; themeGet(props.backgroundColorThemeValue)`,
+    `import {themeGet} from "@primer/components"; themeGet(2)`,
     `import {themeGet} from "@other/design-system"; themeGet("colors.text.primary")`,
     `import {get} from "@other/constants"; get("space.text.primary")`,
     `import {Box} from '@primer/components'; <Box sx={styles}>Hello</Box>`,

src/rules/no-deprecated-colors.js

@@ -118,11 +118,18 @@ module.exports = {
           return
         }
 
-        const [key, ...path] = node.arguments[0].value.split('.')
+        const argument = node.arguments[0]
+        // Skip if the argument is not a Literal (themeGet(props.backgroundColor))
+        // or a string themeGet(2)
+        if (argument.type !== 'Literal' || typeof argument.value !== 'string') {
+          return
+        }
+
+        const [key, ...path] = argument.value.split('.')
         const name = path.join('.')
 
         if (['colors', 'shadows'].includes(key) && Object.keys(deprecations).includes(name)) {
-          replaceDeprecatedColor(context, node.arguments[0], name, str => [key, str].join('.'))
+          replaceDeprecatedColor(context, argument, name, str => [key, str].join('.'))
         }
       }
     }