Merge branch 'main' into bs/rule-for-tooltip-v2

Author: broccolinisoup

.github/CODEOWNERS

@@ -1,2 +1,2 @@
 # All changes should be reviewed by a member of the @react-reviewers team
-* @primer/react-reviewers
+* @primer/engineer-reviewers

.github/workflows/release_canary.yml

@@ -49,7 +49,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Output canary version number
-        uses: actions/github-script@v6.4.1
+        uses: actions/github-script@v7.0.1
         with:
           script: |
             const package = require(`${process.env.GITHUB_WORKSPACE}/package.json`)

.github/workflows/release_candidate.yml

@@ -44,7 +44,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Output release candidate version number
-        uses: actions/github-script@v6.4.1
+        uses: actions/github-script@v7.0.1
         with:
           script: |
             const package = require(`${process.env.GITHUB_WORKSPACE}/package.json`)

CHANGELOG.md

@@ -1,5 +1,41 @@
 # eslint-plugin-primer-react
 
+## 5.0.0
+
+### Major Changes
+
+- [#174](https://github.com/primer/eslint-plugin-primer-react/pull/174) [`d9832b8`](https://github.com/primer/eslint-plugin-primer-react/commit/d9832b850cbcf808ddcdfd3efbbab7d2bf913ccd) Thanks [@langermank](https://github.com/langermank)! - - Remove `no-deprecated-colors` plugin
+
+  - Remove dependency on `primer/primitives`
+
+- [#172](https://github.com/primer/eslint-plugin-primer-react/pull/172) [`8e24d66`](https://github.com/primer/eslint-plugin-primer-react/commit/8e24d660065b3c690a14d826580c793d7b305068) Thanks [@langermank](https://github.com/langermank)! - [Breaking] Remove `new-color-css-vars-have-fallback`
+
+## 4.2.0
+
+### Minor Changes
+
+- [#156](https://github.com/primer/eslint-plugin-primer-react/pull/156) [`15cfbb4`](https://github.com/primer/eslint-plugin-primer-react/commit/15cfbb4a261c44418404249cc33e279bce25b2b7) Thanks [@broccolinisoup](https://github.com/broccolinisoup)! - Add no-deprecated-props rule
+
+### Patch Changes
+
+- [#166](https://github.com/primer/eslint-plugin-primer-react/pull/166) [`4c3d9b4`](https://github.com/primer/eslint-plugin-primer-react/commit/4c3d9b4e761733ac52f4d624a94996a4379c37ca) Thanks [@chadfawcett](https://github.com/chadfawcett)! - Move eslint-plugin-github to dependencies
+
+- [#152](https://github.com/primer/eslint-plugin-primer-react/pull/152) [`7baeb96`](https://github.com/primer/eslint-plugin-primer-react/commit/7baeb9684cc5f84847f004fee282a3362517d7d0) Thanks [@siddharthkp](https://github.com/siddharthkp)! - no-system-props: Add option to ignore specific component names
+
+## 4.1.2
+
+### Patch Changes
+
+- [#148](https://github.com/primer/eslint-plugin-primer-react/pull/148) [`523e169`](https://github.com/primer/eslint-plugin-primer-react/commit/523e169a3c6c801750d451e875c83f52e383c772) Thanks [@siddharthkp](https://github.com/siddharthkp)! - no-system-props: skip html elements
+
+- [#149](https://github.com/primer/eslint-plugin-primer-react/pull/149) [`ca14bb6`](https://github.com/primer/eslint-plugin-primer-react/commit/ca14bb695ad296903bfe7598b4eb81291796245a) Thanks [@siddharthkp](https://github.com/siddharthkp)! - no-system-props: allow maxWidth prop for Truncate
+
+## 4.1.1
+
+### Patch Changes
+
+- [#145](https://github.com/primer/eslint-plugin-primer-react/pull/145) [`0369cb8`](https://github.com/primer/eslint-plugin-primer-react/commit/0369cb857dd49945ac7929444ffacb2ecc02a2ed) Thanks [@siddharthkp](https://github.com/siddharthkp)! - no-system-props: Add `position` as allowed prop for `Dialog`
+
 ## 4.1.0
 
 ### Minor Changes

README.md

@@ -32,8 +32,8 @@ ESLint rules for Primer React
 ## Rules
 
 - [direct-slot-children](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/direct-slot-children.md)
-- [no-deprecated-colors](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-colors.md)
 - [no-system-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-system-props.md)
 - [a11y-tooltip-interactive-trigger](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-tooltip-interactive-trigger.md)
 - [a11y-explicit-heading](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-explicit-heading.md)
 - [new-css-color-vars](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/new-css-color-vars.md)
+- [no-deprecated-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-props.md)

docs/rules/new-color-css-vars-have-fallback.md

@@ -2,7 +2,7 @@
 
 CSS variables are allowed within the `sx` prop in Primer React components. However, the legacy color CSS variables are
 deprecated in favor of the new CSS variables introduced in Primitives v8. This rule will warn you if you are using the
-deprecated color CSS variables in the `sx` prop, and autofix it including a fallback to the old value.
+deprecated color CSS variables in the `sx` prop, and autofix it.
 
 ## Rule Details
 
@@ -36,5 +36,5 @@ one based on the property. We only check `sx` because `stylelint` is used to lin
 👍 Examples of **correct** code for this rule:
 
 ```jsx
-<Button sx={{color: 'var(--fgColor-muted, var(--color-fg-muted))'}}>Test</Button>
+<Button sx={{color: 'var(--fgColor-muted)'}}>Test</Button>
 ```

docs/rules/new-css-color-vars.md

@@ -0,0 +1,48 @@
+## Rule Details
+
+This rule enforces to use the recommended API (`ActionList.GroupHeading`) component over the deprecated prop (`title` prop on `ActionList.Group`) for ActionList component.
+
+👎 Examples of **incorrect** code for this rule:
+
+```jsx
+/* eslint primer-react/no-deprecated-props: "error" */
+import {ActionList} from '@primer/react'
+
+const App = () => (
+  <ActionList>
+    <ActionList.Group title="Group heading">
+      <ActionList.Item>Item 1</ActionList.Item>
+    </ActionList.Group>
+  </ActionList>
+)
+```
+
+👍 Examples of **correct** code for this rule:
+
+```jsx
+/* eslint primer-react/no-deprecated-props: "error" */
+import {ActionList} from '@primer/react'
+
+const App = () => (
+  <ActionList>
+    <ActionList.Group>
+      <ActionList.GroupHeading as="h2">Group heading</ActionList.GroupHeading>
+      <ActionList.Item>Item 1</ActionList.Item>
+    </ActionList.Group>
+  </ActionList>
+)
+```
+
+```jsx
+/* eslint primer-react/no-deprecated-props: "error" */
+import {ActionList} from '@primer/react'
+
+const App = () => (
+  <ActionList role="lisbox">
+    <ActionList.Group>
+      <ActionList.GroupHeading>Group heading</ActionList.GroupHeading>
+      <ActionList.Item>Item 1</ActionList.Item>
+    </ActionList.Group>
+  </ActionList>
+)
+```