Skip to content

Commit 898944d

Browse files
code review feedback
1 parent a65aa32 commit 898944d

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,4 @@ ESLint rules for Primer React
3232
- [direct-slot-children](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/direct-slot-children.md)
3333
- [no-deprecated-colors](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-colors.md)
3434
- [no-system-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-system-props.md)
35+
- [a11y-tooltip-non-interactive-trigger](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-tooltip-non-interactive-trigger.md)

docs/rules/a11y-tooltip-non-interactive-trigger.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
<!-- Write a readme for the non interactive trigger rule -->
2-
31
## Rule Details
42

53
This rule enforces to use interactive elements as tooltip triggers. Interactive elements can be Primer `Button`, `IconButton` and `Link` components or native elements like `button`, `a` with an `href` attribute, `select`, `textarea`, `summary` and `input` (that is not a `hidden` type).

src/configs/recommended.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ module.exports = {
1010
rules: {
1111
'primer-react/direct-slot-children': 'error',
1212
'primer-react/no-deprecated-colors': 'warn',
13-
'primer-react/no-system-props': 'warn'
13+
'primer-react/no-system-props': 'warn',
14+
'primer-react/a11y-tooltip-non-interactive-trigger': 'error'
1415
},
1516
settings: {
1617
github: {

src/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ module.exports = {
22
rules: {
33
'direct-slot-children': require('./rules/direct-slot-children'),
44
'no-deprecated-colors': require('./rules/no-deprecated-colors'),
5-
'no-system-props': require('./rules/no-system-props')
5+
'no-system-props': require('./rules/no-system-props'),
6+
'a11y-tooltip-non-interactive-trigger': require('./rules/a11y-tooltip-non-interactive-trigger')
67
},
78
configs: {
89
recommended: require('./configs/recommended')

src/rules/a11y-tooltip-non-interactive-trigger.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,6 @@ const checkTriggerElement = jsxNode => {
124124
module.exports = {
125125
meta: {
126126
type: 'problem',
127-
docs: {
128-
url:
129-
'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-noninteractive-element-interactions.md',
130-
description: 'Non-interactive elements should not be assigned mouse or keyboard event listeners.'
131-
},
132127
schema: [
133128
{
134129
properties: {

0 commit comments

Comments
 (0)