Skip to content

Commit ad1531b

Browse files
committed
Update message
1 parent a5d1f8e commit ad1531b

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/rules/__tests__/no-deprecated-experimental-components.test.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,16 @@ ruleTester.run('no-deprecated-experimental-components', rule, {
2929
// Single experimental import
3030
{
3131
code: `import {SelectPanel} from '@primer/react/experimental'`,
32-
errors: ['SelectPanelV2 is deprecated. Please import SelectPanelV1 from `@primer/react`'],
32+
errors: [
33+
'SelectPanel is deprecated. Please import them from the stable entrypoint (@primer/react) if available.',
34+
],
3335
},
3436
// Multiple experimental import
3537
{
3638
code: `import {SelectPanel, DataTable, ActionBar} from '@primer/react/experimental'`,
37-
errors: ['SelectPanelV2 is deprecated. Please import SelectPanelV1 from `@primer/react`'],
39+
errors: [
40+
'SelectPanel is deprecated. Please import them from the stable entrypoint (@primer/react) if available.',
41+
],
3842
},
3943
],
4044
})

src/rules/no-deprecated-experimental-components.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,20 @@ module.exports = {
4545
return entrypoint.has(specifier.imported.name)
4646
})
4747

48+
const components = experimental.map(specifier => specifier.imported.name)
49+
4850
if (experimental.length === 0) {
4951
return
5052
}
5153

52-
// All imports are deprecated
5354
if (experimental.length > 0) {
55+
const message = `${components.join(', ')} ${
56+
components.length > 1 ? 'are' : 'is'
57+
} deprecated. Please import them from the stable entrypoint (@primer/react) if available.`
58+
5459
context.report({
5560
node,
56-
message: 'SelectPanelV2 is deprecated. Please import SelectPanelV1 from `@primer/react`',
61+
message,
5762
})
5863
}
5964
},

0 commit comments

Comments
 (0)