Skip to content

Commit b663b9d

Browse files
reuse rootImport and fix method
1 parent db3bc20 commit b663b9d

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/rules/a11y-use-accessible-tooltip.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,16 @@ module.exports = {
4040

4141
const sourceCode = context.getSourceCode()
4242
// Checking to see if there is an existing root (@primer/react) import
43-
const rootImport = sourceCode.ast.body.filter(statement => {
43+
// Assuming there is one root import per file
44+
const rootImport = sourceCode.ast.body.find(statement => {
4445
return statement.type === 'ImportDeclaration' && statement.source.value === '@primer/react'
4546
})
4647

4748
const tooltipSpecifier = node.specifiers.find(
4849
specifier => specifier.imported && specifier.imported.name === 'Tooltip',
4950
)
5051

51-
const hasRootImport = rootImport.length >= 1
52+
const hasRootImport = rootImport !== undefined
5253

5354
context.report({
5455
node,
@@ -62,9 +63,6 @@ module.exports = {
6263
// remove the entire import statement
6364
fixes.push(fixer.remove(node))
6465
// find the last specifier in the existing @primer/react import and insert Tooltip after that
65-
const rootImport = sourceCode.ast.body.find(statement => {
66-
return statement.type === 'ImportDeclaration' && statement.source.value === '@primer/react'
67-
})
6866
const lastSpecifier = rootImport.specifiers[rootImport.specifiers.length - 1]
6967
fixes.push(fixer.insertTextAfter(lastSpecifier, `, Tooltip`))
7068
}
@@ -91,9 +89,6 @@ module.exports = {
9189
fixes.push(fixer.insertTextAfter(node, `\nimport {Tooltip} from '@primer/react';`))
9290
} else {
9391
// find the last specifier in the existing @primer/react import and insert Tooltip after that
94-
const rootImport = sourceCode.ast.body.find(statement => {
95-
return statement.type === 'ImportDeclaration' && statement.source.value === '@primer/react'
96-
})
9792
const lastSpecifier = rootImport.specifiers[rootImport.specifiers.length - 1]
9893
fixes.push(fixer.insertTextAfter(lastSpecifier, `, Tooltip`))
9994
}

0 commit comments

Comments
 (0)