Fix eslint.config.js to include eslint:recommended and plugin:github/recommended configs and update typescript-eslint parser usage

Co-authored-by: joshblack <[email protected]>

Author: Copilot

.markdownlint-cli2.cjs

@@ -16,11 +16,11 @@ const options = githubMarkdownOpinions.init({
   'no-hard-tabs': false,
   'first-line-heading': false,
   'no-space-in-emphasis': false,
-  'blanks-around-fences': false
+  'blanks-around-fences': false,
 })
 
 module.exports = {
   config: options,
   customRules: ['@github/markdownlint-github'],
-  outputFormatters: [['markdownlint-cli2-formatter-pretty', {appendLink: true}]]
+  outputFormatters: [['markdownlint-cli2-formatter-pretty', {appendLink: true}]],
 }

eslint.config.js

@@ -1,6 +1,8 @@
 'use strict'
 
+const js = require('@eslint/js')
 const globals = require('globals')
+const github = require('eslint-plugin-github')
 
 /**
  * @type {import('eslint').Linter.FlatConfig[]}
@@ -9,6 +11,8 @@ module.exports = [
   {
     ignores: ['node_modules/**', '.git/**'],
   },
+  js.configs.recommended,
+  github.default.getFlatConfigs().recommended,
   {
     languageOptions: {
       ecmaVersion: 'latest',
@@ -19,15 +23,18 @@ module.exports = [
       },
     },
     rules: {
-      // Basic rules for the repository
+      // Override specific rules for the repository
+      'import/no-commonjs': 'off',
+      'import/no-dynamic-require': 'off', // Allow dynamic requires in tests
+      'no-shadow': 'off',
       'no-unused-vars': [
         'error',
         {
           varsIgnorePattern: '^_',
         },
       ],
-      'no-shadow': 'off',
-      'no-undef': 'error',
+      'github/filenames-match-regex': 'off', // Allow various file naming patterns
+      'i18n-text/no-en': 'off', // Allow English text in this repository
     },
   },
   {

package-lock.json

@@ -48,9 +48,14 @@
     "@types/jest": "^30.0.0",
     "@typescript-eslint/rule-tester": "8.38.0",
     "eslint": "^9.0.0",
-    "eslint-plugin-prettier": "^5.2.1",
-    "jest": "^30.0.5",
+    "eslint-plugin-eslint-comments": "^3.2.0",
+    "eslint-plugin-filenames": "^1.3.2",
+    "eslint-plugin-i18n-text": "^1.0.1",
+    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-no-only-tests": "^3.3.0",
+    "eslint-plugin-prettier": "^5.5.4",
     "globals": "^16.3.0",
+    "jest": "^30.0.5",
     "markdownlint-cli2": "^0.18.1",
     "markdownlint-cli2-formatter-pretty": "^0.0.7"
   },

package.json

@@ -21,7 +21,7 @@ const asConstDeclaration = `const as = "p";`
 
 const ruleTester = new RuleTester({
   languageOptions: {
-    parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),
+    parser: require('@typescript-eslint/parser'),
     parserOptions: {
       tsconfigRootDir: path.resolve(__dirname, 'fixtures'),
       project: path.resolve(__dirname, 'fixtures', 'tsconfig.json'),