Merge pull request #31 from primer/colebemis-patch-2

no-system-props: Always ignore size prop

Author: colebemis

.changeset/tender-humans-rest.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-primer-react": patch
+---
+
+`no-system-props`: Always ignore `size` prop 

src/rules/__tests__/no-system-props.test.js

@@ -19,7 +19,8 @@ ruleTester.run('no-system-props', rule, {
     `import {Box} from '@primer/react'; <Box width={200} />`,
     `import {ProgressBar} from '@primer/react'; <ProgressBar bg="howdy" />`,
     `import {Button} from '@primer/react'; <Button {...someExpression()} />`,
-    `import {Button} from '@primer/react'; <Button variant="large" />`
+    `import {Button} from '@primer/react'; <Button variant="large" />`,
+    `import {Button} from '@primer/react'; <Button size="large" />`,
   ],
   invalid: [
     {

src/rules/no-system-props.js

@@ -13,15 +13,12 @@ const utilityComponents = new Set(['Box', 'Text'])
 // Components for which we allow a set of prop names
 const excludedComponentProps = new Map([
   ['AnchoredOverlay', new Set(['width', 'height'])],
-  ['Avatar', new Set(['size'])],
   ['Dialog', new Set(['width', 'height'])],
   ['ProgressBar', new Set(['bg'])],
-  ['Spinner', new Set(['size'])],
-  ['StyledOcticon', new Set(['size'])],
   ['PointerBox', new Set(['bg'])]
 ])
 
-const alwaysExcludedProps = new Set(['variant'])
+const alwaysExcludedProps = new Set(['variant', 'size'])
 
 module.exports = {
   meta: {