From 8844f26345ee647468558b3ac71604924cfca846 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Thu, 10 Oct 2024 10:30:21 -0500 Subject: [PATCH 1/2] fix(no-wildcard-imports): remove migration for TokenSizeKeys --- src/rules/__tests__/no-wildcard-imports.test.js | 12 ------------ src/rules/no-wildcard-imports.js | 10 ---------- 2 files changed, 22 deletions(-) diff --git a/src/rules/__tests__/no-wildcard-imports.test.js b/src/rules/__tests__/no-wildcard-imports.test.js index 8c730e25..adf7d5f8 100644 --- a/src/rules/__tests__/no-wildcard-imports.test.js +++ b/src/rules/__tests__/no-wildcard-imports.test.js @@ -270,18 +270,6 @@ import {type ButtonBaseProps} from '@primer/react/experimental'`, }, ], }, - { - code: `import type {TokenSizeKeys} from '@primer/react/lib-esm/Token/TokenBase'`, - output: `import {type TokenSizeKeys} from '@primer/react'`, - errors: [ - { - messageId: 'wildcardMigration', - data: { - wildcardEntrypoint: '@primer/react/lib-esm/Token/TokenBase', - }, - }, - ], - }, { code: `import type {ItemProps} from '@primer/react/lib-esm/deprecated/ActionList'`, output: `import {type ActionListItemProps as ItemProps} from '@primer/react/deprecated'`, diff --git a/src/rules/no-wildcard-imports.js b/src/rules/no-wildcard-imports.js index c9c7eba4..b649b658 100644 --- a/src/rules/no-wildcard-imports.js +++ b/src/rules/no-wildcard-imports.js @@ -96,16 +96,6 @@ const wildcardImports = new Map([ }, ], ], - [ - '@primer/react/lib-esm/Token/TokenBase', - [ - { - type: 'type', - name: 'TokenSizeKeys', - from: '@primer/react', - }, - ], - ], [ '@primer/react/lib-esm/deprecated/ActionList', [ From 8a8638a7f8c62a343e6108e73ed0ae6606b53a64 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Thu, 10 Oct 2024 10:30:48 -0500 Subject: [PATCH 2/2] chore: add changeset --- .changeset/short-garlics-kiss.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/short-garlics-kiss.md diff --git a/.changeset/short-garlics-kiss.md b/.changeset/short-garlics-kiss.md new file mode 100644 index 00000000..fca733b6 --- /dev/null +++ b/.changeset/short-garlics-kiss.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-primer-react': patch +--- + +Update no-wildcard-imports rule to no longer migrate the TokenSizeKeys import