From 834ed317aaada6a109e6706008a5cf2212c57988 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 24 Apr 2025 12:58:27 -0400 Subject: [PATCH 1/5] Update recommended.js --- src/configs/recommended.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/configs/recommended.js b/src/configs/recommended.js index 1d4a9f33..61cd07cc 100644 --- a/src/configs/recommended.js +++ b/src/configs/recommended.js @@ -22,8 +22,6 @@ module.exports = { 'primer-react/a11y-use-accessible-tooltip': 'error', 'primer-react/no-unnecessary-components': 'error', 'primer-react/prefer-action-list-item-onselect': 'error', - 'primer-react/enforce-css-module-identifier-casing': 'error', - 'primer-react/enforce-css-module-default-import': ['error', {enforceName: '(^classes$|Classes$)'}], }, settings: { github: { From 07b6b34d16736aa49b87af7c9ca4f274588c9d92 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 24 Apr 2025 17:00:48 +0000 Subject: [PATCH 2/5] update rule message --- package-lock.json | 4 ++-- .../__tests__/no-deprecated-experimental-components.test.js | 4 ++-- src/rules/no-deprecated-experimental-components.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index b0282a88..164274ac 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "eslint-plugin-primer-react", - "version": "6.1.6", + "version": "7.0.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "eslint-plugin-primer-react", - "version": "6.1.6", + "version": "7.0.0", "license": "MIT", "dependencies": { "@styled-system/props": "^5.1.5", diff --git a/src/rules/__tests__/no-deprecated-experimental-components.test.js b/src/rules/__tests__/no-deprecated-experimental-components.test.js index 3488328a..bcdc0358 100644 --- a/src/rules/__tests__/no-deprecated-experimental-components.test.js +++ b/src/rules/__tests__/no-deprecated-experimental-components.test.js @@ -30,14 +30,14 @@ ruleTester.run('no-deprecated-experimental-components', rule, { { code: `import {SelectPanel} from '@primer/react/experimental'`, errors: [ - 'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.', + 'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.', ], }, // Multiple experimental import { code: `import {SelectPanel, DataTable, ActionBar} from '@primer/react/experimental'`, errors: [ - 'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.', + 'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.', ], }, ], diff --git a/src/rules/no-deprecated-experimental-components.js b/src/rules/no-deprecated-experimental-components.js index 3746c9fa..46ac7edb 100644 --- a/src/rules/no-deprecated-experimental-components.js +++ b/src/rules/no-deprecated-experimental-components.js @@ -52,7 +52,7 @@ module.exports = { } if (experimental.length > 0) { - const message = `${components.join(', ')} ${ + const message = `The experimental ${components.join(', ')} ${ components.length > 1 ? 'are' : 'is' } deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.` From deb2582e783ae8db6790d66b7c8037cf25f7b674 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:03:03 -0400 Subject: [PATCH 3/5] Create honest-adults-add.md --- .changeset/honest-adults-add.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/honest-adults-add.md diff --git a/.changeset/honest-adults-add.md b/.changeset/honest-adults-add.md new file mode 100644 index 00000000..9293092a --- /dev/null +++ b/.changeset/honest-adults-add.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-primer-react": patch +--- + +Removes primer-react/enforce-css-module-identifier-casing, primer-react/enforce-css-module-default-import from recommended set of rules. From 76be78049487dfd9d794fc6cef8be59fd4ee2820 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:03:27 -0400 Subject: [PATCH 4/5] Create eighty-tips-deliver.md --- .changeset/eighty-tips-deliver.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eighty-tips-deliver.md diff --git a/.changeset/eighty-tips-deliver.md b/.changeset/eighty-tips-deliver.md new file mode 100644 index 00000000..debe7004 --- /dev/null +++ b/.changeset/eighty-tips-deliver.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-primer-react": patch +--- + +Update message for no-deprecated-experimental-components rule From af830166624fa39f56d1a15cfa9b03a72ff6f2ac Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 24 Apr 2025 17:06:22 +0000 Subject: [PATCH 5/5] disable lint rule --- src/rules/no-deprecated-experimental-components.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/no-deprecated-experimental-components.js b/src/rules/no-deprecated-experimental-components.js index 46ac7edb..2abe522d 100644 --- a/src/rules/no-deprecated-experimental-components.js +++ b/src/rules/no-deprecated-experimental-components.js @@ -52,6 +52,7 @@ module.exports = { } if (experimental.length > 0) { + // eslint-disable-next-line i18n-text/no-en const message = `The experimental ${components.join(', ')} ${ components.length > 1 ? 'are' : 'is' } deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.`