Skip to content

Update repository to Node.js v20 #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 7, 2025

This PR updates the repository to use Node.js v20 across all configurations and workflows.

Changes Made

  • Updated .nvmrc: Changed from v18 to v20 to specify the recommended Node.js version for local development
  • Updated GitHub Actions workflows: All workflows now use Node.js 20 instead of the previous mix of v14, v14.x, and v18:
    • ci.yml: Updated all three jobs (format, test, lint) from Node.js 18 to 20
    • release.yml: Updated from Node.js 14 to 20
    • release_canary.yml: Updated from Node.js 14.x to 20
    • release_candidate.yml: Updated from Node.js 14.x to 20
  • Added engines field to package.json: Added "node": ">=20" to specify the minimum required Node.js version

Verification

All existing functionality continues to work as expected:

  • ✅ All 286 tests pass across 20 test suites
  • ✅ ESLint passes without any issues
  • ✅ Prettier format check passes
  • ✅ No code changes were required - the existing JavaScript code is fully compatible with Node.js v20

This is a configuration-only update that modernizes the project's Node.js requirements while maintaining full backward compatibility of the actual ESLint plugin functionality.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: dfa2d32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Copilot Copilot AI changed the title [WIP] Can you update this repository to be node v20? Update repository to Node.js v20 Aug 7, 2025
@Copilot Copilot AI requested a review from jonrohan August 7, 2025 01:11
Copilot finished work on behalf of jonrohan August 7, 2025 01:11
@jonrohan jonrohan marked this pull request as ready for review August 7, 2025 01:12
@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 01:12
@jonrohan jonrohan requested a review from a team as a code owner August 7, 2025 01:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the repository's Node.js version requirements by upgrading from a mix of Node.js v14 and v18 to a standardized Node.js v20 across all configurations.

  • Updated all GitHub Actions workflows to use Node.js 20 consistently
  • Set .nvmrc to specify v20 for local development
  • Added engines field to package.json requiring Node.js >=20

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Added engines field requiring Node.js >=20
.nvmrc Updated from v18 to v20 for local development
.github/workflows/release_candidate.yml Updated Node.js version from 14.x to 20
.github/workflows/release_canary.yml Updated Node.js version from 14.x to 20
.github/workflows/release.yml Updated Node.js version from 14 to 20
.github/workflows/ci.yml Updated Node.js version from 18 to 20 across all jobs

@jonrohan jonrohan merged commit d42d5c0 into main Aug 7, 2025
9 checks passed
@jonrohan jonrohan deleted the copilot/fix-85a05642-b43c-4c77-ba74-6ee8ea0f4d53 branch August 7, 2025 02:29
@primer-css primer-css mentioned this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants