Add exception for height and width for SkeletonBox in no-system-props rule #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 036d575 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds exceptions for height and width props on SkeletonBox components in the no-system-props ESLint rule. The change allows these specific system props to be used with SkeletonBox without triggering linting errors, aligning with the documented usage patterns for this component.
- Added
SkeletonBoxto the excluded component props map withwidthandheightexceptions
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
TylerJDev
approved these changes
Aug 13, 2025
llastflowers
deleted the
llastflowers/5445/no-system-props-SkeletonBox-exceptions
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/primer/issues/5445
Explanation of Changes
Added exception for
heightandwidthforSkeletonBoxinno-system-propslint rule, since our docs advise use of those props withSkeletonBox. After releasing this change, we will test the usage in dotcom to make sure the issue is resolved.