Added error alerts and removed debugging code

- Added alerts to let the user know about API connection failures and other errors
- Removed some code for debugging reasons

Author: primetime43

GAPS 2.py

@@ -80,8 +80,6 @@ def save_tmdb_key():
 
 @app.route('/link_plex_account', methods=['POST'])
 def link_plex_account():
-    print("link_plex_account")
-
     try:
         headers = {'X-Plex-Client-Identifier': app.config['PLEX_CLIENT_IDENTIFIER']}
         pinlogin = MyPlexPinLogin(headers=headers, oauth=True)
@@ -96,17 +94,13 @@ def link_plex_account():
             resources = [resource for resource in plex_account.resources() if resource.owned and resource.connections]
             servers = [f"{resource.name} ({resource.connections[0].address})" for resource in resources if resource.connections]
 
-            print(f"servers: {servers}")
- 
             # Store tokens in the dictionary
             for resource in resources:
                 if resource.connections:
                     server_name = f"{resource.name} ({resource.connections[0].address})"
                     tokens[server_name] = pinlogin.token
-                    print("server name: " + server_name + " token: " + pinlogin.token) 
                     plex_data.add_token(server_name, pinlogin.token)
 
-            print(f'Logged In As {username}')
             plex_data.set_servers(servers)
 
             # Store the PlexAccountData object in the array
@@ -115,41 +109,38 @@ def link_plex_account():
             # Return the JSON response with servers and token
             return jsonify(servers=servers, token=pinlogin.token)
         else:
-            print('Error', 'Could not log in to Plex account')
+            return jsonify({'message': app.config['RESPONSE_MESSAGES']['plex_account_error'], 'servers': [], 'token': None})
     except Exception as e:
-        print('Error', f'Could not log in to Plex account: {str(e)}')
-    
-    # Return an empty JSON response if there was an error
-    return jsonify(servers=[], token=None)
+        return jsonify({'message': app.config['RESPONSE_MESSAGES']['plex_account_error'], 'servers': [], 'token': None})
 
 @app.route('/fetch_libraries/<serverName>')
 def fetch_libraries(serverName):
     # Find the PlexAccountData object with the matching serverName
     plex_data = next((data for data in plex_data_array if serverName in data.tokens), None)
 
     if plex_data is None:
-        print("PlexAccountData not found")
-        return jsonify(error="PlexAccountData not found"), 404
+        #print("PlexAccountData not found")
+        return {'message': app.config['RESPONSE_MESSAGES']['plex_data_not_found']}
 
     token = plex_data.tokens.get(serverName)
 
-    print("Token: " + token)
+    #print("Token: " + token)
     plex_account = MyPlexAccount(token=token)
 
     server = None
     for resource in plex_account.resources():
         if f"{resource.name} ({resource.connections[0].address})" == serverName:
-            print(f"Attempting to connect to server {serverName}")
+            #print(f"Attempting to connect to server {serverName}")
             server = resource.connect()
             break
 
     if server is None:
-        print("Server not found")
+        #print("Server not found")
         return jsonify(error=app.config['RESPONSE_MESSAGES']['server_not_found']), 404
 
     libraries = [section.title for section in server.library.sections()]
 
-    print(f"Libraries: {libraries}")
+    #print(f"Libraries: {libraries}")
 
     plex_data.set_libraries(libraries)
 
@@ -205,7 +196,7 @@ def save_plex_data():
 def get_active_server():
     try:
         global currentActiveServer
-        print(f"get_active_server libraries: {currentActiveServer.libraries}")
+        #print(f"get_active_server libraries: {currentActiveServer.libraries}")
         if currentActiveServer:
             return jsonify(server=currentActiveServer.selected_server, token=currentActiveServer.token, libraries=currentActiveServer.libraries)
         else:
@@ -233,7 +224,7 @@ def get_movies_from_plex_library():
         resources = [resource for resource in plex_account.resources() if resource.owned]
         for resource in resources:
             if f"{resource.name} ({resource.connections[0].address})" == currentActiveServer.selected_server:
-                print(f"resource: {resource.name} ({resource.connections[0].address}) == {currentActiveServer.selected_server}")
+                #print(f"resource: {resource.name} ({resource.connections[0].address}) == {currentActiveServer.selected_server}")
                 server_resource = resource
                 break
 
@@ -291,10 +282,15 @@ def get_recommendations():
     global global_recommendations
     movie_id = request.args.get('movieId', default = 11, type = int) 
     api_key = request.args.get('apiKey', default = "", type = str)
+
     url = f"{app.config['TMDB_BASE_URL']}/movie/{movie_id}/recommendations"
     params = {"api_key": api_key}
 
     response = requests.get(url, params=params)
+
+    if response.status_code != 200:
+        return {'message': 'API request failed with status code ' + str(response.status_code)}, response.status_code
+
     data = response.json()
 
     base_image_url = "https://image.tmdb.org/t/p/w500"
@@ -328,4 +324,4 @@ def get_recommendated_movies():
 moviesFromSelectedLibrary = {}
 
 if __name__ == '__main__':
-    app.run(debug=True)
+    app.run(debug=False)

templates/configuration.html

@@ -229,17 +229,23 @@ <h4 class="alert-heading">Error!</h4>
                     $('#loading').show();
 
                     $.post('/link_plex_account', function (response) {
-                        // Update the dropdown options with the server data
-                        var servers = response.servers; // No need to parse JSON, Flask's jsonify already does this.
-                        var dropdown = $('#server');
-                        dropdown.empty();
-                        servers.forEach(function (server) {
-                            dropdown.append($('<option>').text(server).attr('value', server));
-                        });
-
-                        // Set the Plex token
-                        var token = response.token; // Assuming the response has a "token" key
-                        $('#plexToken').val(token);
+                        // Check if there's a message in the response
+                        if (response.message) {
+                            // Show an alert with the message
+                            alert(response.message);
+                        } else {
+                            // Update the dropdown options with the server data
+                            var servers = response.servers;
+                            var dropdown = $('#server');
+                            dropdown.empty();
+                            servers.forEach(function (server) {
+                                dropdown.append($('<option>').text(server).attr('value', server));
+                            });
+
+                            // Set the Plex token
+                            var token = response.token;
+                            $('#plexToken').val(token);
+                        }
 
                         // Hide the loading text/spinner
                         $('#loading').hide();

templates/libraries.html

@@ -125,12 +125,20 @@ <h5 class="card-title">Your movies are really missing</h5>
 
     <script>
         function getRecommendations(movieId) {
-            //alert(movieId)
             var apiKey = localStorage.getItem('tmdbApiKey');
             fetch('/recommendations?movieId=' + movieId + '&apiKey=' + apiKey)
                 .then(response => response.json())
                 .then(data => {
-                    window.location.href = '/recommended';
+                    if (data.error) {
+                        // If there's an error in the response, show an alert
+                        alert(data.error);
+                    } else if (data.message) {
+                        // If there's a message in the response, show an alert
+                        alert(data.message);
+                    } else {
+                        // If there's no error or message, redirect as usual
+                        window.location.href = '/recommended';
+                    }
                 })
                 .catch((error) => {
                     console.error('Error:', error);

templates/recommended.html

@@ -135,12 +135,20 @@ <h5 class="card-title">${movie.name} (${movie.year})</h5>
         }
 
         function getRecommendations(movieId) {
-            //alert(movieId)
             var apiKey = localStorage.getItem('tmdbApiKey');
             fetch('/recommendations?movieId=' + movieId + '&apiKey=' + apiKey)
                 .then(response => response.json())
                 .then(data => {
-                    window.location.href = '/recommended';
+                    if (data.error) {
+                        // If there's an error in the response, show an alert
+                        alert(data.error);
+                    } else if (data.message) {
+                        // If there's a message in the response, show an alert
+                        alert(data.message);
+                    } else {
+                        // If there's no error or message, redirect as usual
+                        window.location.href = '/recommended';
+                    }
                 })
                 .catch((error) => {
                     console.error('Error:', error);