feat: allow disabling default resolvers (#437)

closes #350

Author: Jason Kuhrt

docs/01-configuration.md

@@ -14,6 +14,7 @@ The configuration file must be called **`graphqlgen.yml`**.
 - `resolver-scaffolding`: An object with two properties
   - `output`: Specifies where the scaffolded resolvers should be located. Must point to a **directory**.
   - `layout`: Specifies the [_layout_](#layouts) for the generated files. Possible values: `file-per-type` (more layouts [coming soon](https://github.com/prisma/graphqlgen/issues/106): `single-file`, `file-per-type-classes`, `single-file-classes`).
+- `default-resolvers`: A boolean dictating if default resolvers will be generated or not. Defaults to `true`.
 
 Whether a property is required or not depends on whether you're doing [Generation](#generation) or [Scaffolding](#scaffolding).
 

packages/graphqlgen-json-schema/src/definition.ts

@@ -5,6 +5,7 @@ export interface GraphQLGenDefinition {
   models: Models
   output: string
   ['resolver-scaffolding']?: ResolverScaffolding
+  ['default-resolvers']?: boolean
 }
 
 export interface Models {

packages/graphqlgen/package.json

@@ -44,7 +44,7 @@
     "glob": "^7.1.3",
     "graphql": "^0.13.0 || ^14.0.0",
     "graphql-import": "0.7.1",
-    "graphqlgen-json-schema": "0.2.12",
+    "graphqlgen-json-schema": "0.6.0-rc3",
     "js-yaml": "3.12.1",
     "mkdirp": "0.5.1",
     "prettier": "1.16.2",

packages/graphqlgen/src/generators/flow/generator.ts

@@ -171,7 +171,11 @@ function renderNamespace(
 
   return `\
     // Types for ${typeName}
-    ${renderDefaultResolvers(type, args, `${typeName}_defaultResolvers`)}
+    ${
+      args.defaultResolversEnabled
+        ? renderDefaultResolvers(type, args, `${typeName}_defaultResolvers`)
+        : ''
+    }
 
     ${renderInputTypeInterfaces(
       type,

packages/graphqlgen/src/generators/flow/scaffolder.ts

@@ -92,11 +92,15 @@ function renderResolvers(
   const modelFields = fieldsFromModelDefinition(model.definition)
   const upperTypeName = upperFirst(type.name)
   const code = `/* @flow */
-import { ${upperTypeName}_defaultResolvers } from '[TEMPLATE-INTERFACES-PATH]'
+${
+  args.defaultResolversEnabled
+    ? `import { ${upperTypeName}_defaultResolvers } from '[TEMPLATE-INTERFACES-PATH]'`
+    : ''
+}
 import type { ${upperTypeName}_Resolvers } from '[TEMPLATE-INTERFACES-PATH]'
 
 export const ${type.name}: ${upperTypeName}_Resolvers = {
-  ...${upperTypeName}_defaultResolvers,
+  ${args.defaultResolversEnabled ? `...${upperTypeName}_defaultResolvers,` : ''}
   ${type.fields
     .filter(graphQLField =>
       shouldScaffoldFieldResolver(graphQLField, modelFields, args),

packages/graphqlgen/src/generators/typescript/generator.ts

@@ -299,7 +299,11 @@ function renderNamespace(
   return `\
     export namespace ${graphQLTypeObject.name}Resolvers {
 
-    ${renderDefaultResolvers(graphQLTypeObject, args, 'defaultResolvers')}
+    ${
+      args.defaultResolversEnabled
+        ? renderDefaultResolvers(graphQLTypeObject, args, 'defaultResolvers')
+        : ''
+    }
 
     ${renderInputTypeInterfaces(
       graphQLTypeObject,

packages/graphqlgen/src/generators/typescript/scaffolder.ts

@@ -26,7 +26,11 @@ function renderResolvers(
   import { ${type.name}Resolvers } from '[TEMPLATE-INTERFACES-PATH]'
 
   export const ${type.name}: ${type.name}Resolvers.Type = {
-    ...${type.name}Resolvers.defaultResolvers,
+    ${
+      args.defaultResolversEnabled
+        ? `...${type.name}Resolvers.defaultResolvers,`
+        : ''
+    }
     ${type.fields
       .filter(field => shouldScaffoldFieldResolver(field, modelFields, args))
       .map(
@@ -57,15 +61,22 @@ function renderPolyResolvers(
   return { path: `${type.name}.ts`, force: false, code }
 }
 
-function renderParentResolvers(type: GraphQLTypeObject): CodeFileLike {
+function renderParentResolvers(
+  type: GraphQLTypeObject,
+  args: GenerateArgs,
+): CodeFileLike {
   const code = `\
   // This resolver file was scaffolded by github.com/prisma/graphqlgen, DO NOT EDIT.
   // Please do not import this file directly but copy & paste to your application code.
 
   import { ${type.name}Resolvers } from '[TEMPLATE-INTERFACES-PATH]'
 
   export const ${type.name}: ${type.name}Resolvers.Type = {
-    ...${type.name}Resolvers.defaultResolvers,
+    ${
+      args.defaultResolversEnabled
+        ? `...${type.name}Resolvers.defaultResolvers,`
+        : ''
+    }
     ${type.fields.map(field => {
       if (type.name === 'Subscription') {
         return `${field.name}: {
@@ -126,7 +137,7 @@ export function generate(args: GenerateArgs): CodeFileLike[] {
     args.types
       .filter(type => type.type.isObject)
       .filter(type => isParentType(type.name))
-      .map(renderParentResolvers),
+      .map(type => renderParentResolvers(type, args)),
   )
 
   files.push({

packages/graphqlgen/src/index.ts

@@ -91,19 +91,23 @@ type CodeGenResult = {
 }
 
 export function generateCode(codeGenArgs: CodeGenArgs): CodeGenResult {
-  const { schema } = codeGenArgs
-
   const generateArgs: GenerateArgs = {
-    ...schema,
+    enums: codeGenArgs.schema.enums,
+    interfaces: codeGenArgs.schema.interfaces,
+    types: codeGenArgs.schema.types,
+    unions: codeGenArgs.schema.unions,
+    modelMap: codeGenArgs.modelMap!,
     context: parseContext(
       codeGenArgs.config.context,
       codeGenArgs.config.output,
     ),
-    modelMap: codeGenArgs.modelMap!,
+    defaultResolversEnabled:
+      typeof codeGenArgs.config['default-resolvers'] === 'boolean'
+        ? codeGenArgs.config['default-resolvers']
+        : true,
   }
 
   const generatedTypes = generateTypes(generateArgs, codeGenArgs)
-
   const generatedResolvers = codeGenArgs.config['resolver-scaffolding']
     ? generateResolvers(generateArgs, codeGenArgs)
     : undefined

packages/graphqlgen/src/types.ts

@@ -14,6 +14,7 @@ export interface GenerateArgs {
   unions: GraphQLUnionObject[]
   context?: ContextDefinition
   modelMap: ModelMap
+  defaultResolversEnabled: boolean
 }
 
 export interface ModelMap {

packages/graphqlgen/tests/generation.ts

@@ -137,7 +137,7 @@ export async function testGeneration(config: GraphQLGenDefinition) {
     config.output,
     config.language,
   )
-  const { generatedTypes, generatedResolvers } = generateCode({
+  const { generatedTypes, generatedResolvers = [] } = generateCode({
     schema,
     language: config.language,
     config,