fix: modernize and fix Deno tests #5958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
force-pushed
the
push-orxruxlylkuw
branch
4 times, most recently
from
8ba4e09 to
24e35e5
Compare
aqrln
force-pushed
the
push-orxruxlylkuw
branch
13 times, most recently
from
fea5bda to
87ecb9a
Compare
FGoessler
approved these changes
Apr 8, 2025
Contributor
FGoessler
left a comment
FGoessler
left a comment
There was a problem hiding this comment.
This also switches the test to deno 2.x. Are we "breaking" deno 1.x functionality?
Member
Author
We never officially supported it (despite having the ecosystem tests) so I guess it's fine either way. I believe Deno 1.x should probably still work, the tests were mainly broken because they accidentally relied on the auto-installation functionality (which is going to be restored to fix other ecosystem tests), but it's more important for us to test Deno 2.x with ESM client rather than obsolete Deno 1.x with the old client (so this PR also contributes to https://linear.app/prisma-company/issue/ORM-683/e2e-tests-esm). |
- Switch from Deno 1.x to Deno 2.x - Switch from `prisma-client-js` to `prisma-client-ts` generator - Use `deno.json` instead of `package.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prisma-client-jstoprisma-client-tsgenerator.deno.jsoninstead ofpackage.json.binary.mjsbundle, at least on Deno. We should take a look into it before GAing the new generator.Closes: https://linear.app/prisma-company/issue/ORM-843/fix-deno-ecosystem-tests