Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Commit 097031d

Browse files
a sure place to dedup create account
1 parent 968df85 commit 097031d

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

zkevm-circuits/src/evm_circuit/util/common_gadget.rs

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -492,15 +492,6 @@ impl<F: Field> TransferWithGasFeeGadget<F> {
492492
) -> Self {
493493
let sender_sub_fee = cb.decrease_balance(sender_address.to_word(), gas_fee, None);
494494
let value_is_zero = cb.is_zero_word(&value);
495-
// If receiver doesn't exist, create it
496-
TransferToGadget::create_account(
497-
cb,
498-
receiver_address.clone(),
499-
receiver_exists.clone(),
500-
must_create.clone(),
501-
value_is_zero.expr(),
502-
Some(reversion_info),
503-
);
504495
// Skip transfer if value == 0
505496
let sender_sub_value = cb.condition(not::expr(value_is_zero.expr()), |cb| {
506497
cb.decrease_balance(sender_address, value.clone(), Some(reversion_info))
@@ -512,7 +503,7 @@ impl<F: Field> TransferWithGasFeeGadget<F> {
512503
must_create,
513504
value,
514505
Some(reversion_info),
515-
false,
506+
true,
516507
);
517508

518509
Self {
@@ -607,15 +598,6 @@ impl<F: Field> TransferGadget<F> {
607598
reversion_info: &mut ReversionInfo<F>,
608599
) -> Self {
609600
let value_is_zero = cb.is_zero_word(&value);
610-
// If receiver doesn't exist, create it
611-
TransferToGadget::create_account(
612-
cb,
613-
receiver_address.clone(),
614-
receiver_exists.clone(),
615-
must_create.expr(),
616-
value_is_zero.expr(),
617-
Some(reversion_info),
618-
);
619601
// Skip transfer if value == 0
620602
let sender = cb.condition(not::expr(value_is_zero.expr()), |cb| {
621603
cb.decrease_balance(sender_address, value.clone(), Some(reversion_info))
@@ -627,7 +609,7 @@ impl<F: Field> TransferGadget<F> {
627609
must_create.expr(),
628610
value,
629611
Some(reversion_info),
630-
false,
612+
true,
631613
);
632614

633615
Self {

0 commit comments

Comments
 (0)