Skip to content

Commit 3fd3386

Browse files
authored
Merge pull request #40 from privacycg/arichiv-patch-3
Resolve issue with bikeshed compile
2 parents 8181c94 + 889cea8 commit 3fd3386

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spec.bs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,12 @@ interface StorageAccessHandle {
160160

161161
partial interface Document {
162162
Promise<boolean> hasUnpartitionedCookieAccess();
163-
Promise<StorageAccessHandle> requestStorageAccess(StorageAccessTypes types);
163+
Promise<StorageAccessHandle> requestStorageAccess(optional StorageAccessTypes types = {});
164164
};
165165
</pre>
166166

167+
Issue: Although {{Document/requestStorageAccess(types)}} lists |types| as optional, it should be treated as if [OneMemberRequired](https://github.com/whatwg/webidl/issues/903) (not yet supported) were applied to indicate the dictionary must have at least one non-false argument. If {{Document/requestStorageAccess(types)}} is called without providing |types| you would actually be invoking {{Document/requestStorageAccess()}} which does not return a {{StorageAccessHandle}}.
168+
167169
A {{StorageAccessHandle}} object has an associated {{StorageAccessTypes}} <dfn for=StorageAccessHandle>types</dfn>.
168170

169171
When invoked on {{Document}} |doc|, the <dfn export method for=Document><code>hasUnpartitionedCookieAccess()</code></dfn> method must run these steps:

0 commit comments

Comments
 (0)