prevent crash if path callbacks are not disabled

alexrabi · alexrabi · commit 7eed3c7f67ab · 2025-03-24T11:04:17.000+01:00
diff --git a/picoquic/quicctx.c b/picoquic/quicctx.c
@@ -1703,7 +1703,7 @@ void picoquic_delete_path(picoquic_cnx_t* cnx, int path_index)
     }
 
     /* Signal to the application */
-    if (cnx->are_path_callbacks_enabled &&
+    if (cnx->are_path_callbacks_enabled && cnx->callback_fn != NULL &&
         cnx->callback_fn(cnx, path_x->unique_path_id, NULL, 0, picoquic_callback_path_deleted,
         cnx->callback_ctx, path_x->app_path_ctx) != 0) {
         picoquic_connection_error_ex(cnx, PICOQUIC_TRANSPORT_INTERNAL_ERROR, 0, "Path deleted callback failed.");

Original file line number	Diff line number	Diff line change
`@@ -1703,7 +1703,7 @@ void picoquic_delete_path(picoquic_cnx_t* cnx, int path_index)`
`1703`	`1703`	`}`
`1704`	`1704`
`1705`	`1705`	`/* Signal to the application */`
`1706`		`- if (cnx->are_path_callbacks_enabled &&`
	`1706`	`+ if (cnx->are_path_callbacks_enabled && cnx->callback_fn != NULL &&`
`1707`	`1707`	`cnx->callback_fn(cnx, path_x->unique_path_id, NULL, 0, picoquic_callback_path_deleted,`
`1708`	`1708`	`cnx->callback_ctx, path_x->app_path_ctx) != 0) {`
`1709`	`1709`	`picoquic_connection_error_ex(cnx, PICOQUIC_TRANSPORT_INTERNAL_ERROR, 0, "Path deleted callback failed.");`