Skip to content

Commit 0de09e9

Browse files
authored
Bidglass Bid Adapter : remove params.adUnitId numeric requirement (prebid#13091)
* Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Merge externally set targeting params * Updates to address gulp errors * Get `bidglass` reference from window * Add support for meta.advertiserDomains * Remove numeric requirement for params.adUnitId
1 parent f37c901 commit 0de09e9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

modules/bidglassBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const spec = {
2121
* @return boolean True if this is a valid bid, and false otherwise.
2222
*/
2323
isBidRequestValid: function(bid) {
24-
return !!(bid.params.adUnitId && !isNaN(parseFloat(bid.params.adUnitId)) && isFinite(bid.params.adUnitId));
24+
return !!bid.params.adUnitId; // only adUnitId is required
2525
},
2626
/**
2727
* Make a server request from the list of BidRequests.

0 commit comments

Comments
 (0)