Merge pull request #106 from proactiveops/fix-params

Fix query params handling: query -> params

Author: skwashd

picorun/picorun.py

@@ -27,7 +27,8 @@ def to_kwargs(self) -> dict[str, Any]:
         """Convert the object to a dictionary of keyword arguments for requests."""
         output = {}
         for property in ["headers", "json", "query"]:
-            output[property] = getattr(self, property)
+            key = property if property != "query" else "params"
+            output[key] = getattr(self, property)
         return output
 
 

tests/test_picorun.py

@@ -39,7 +39,7 @@ def test_api_request_args() -> None:
     assert args.to_kwargs() == {
         "headers": {"headers": "value"},
         "json": {"payload": "value"},
-        "query": {"query": "value"},
+        "params": {"query": "value"},
     }
 
 
@@ -53,7 +53,7 @@ def test_api_request_empty_args() -> None:
     assert args.to_kwargs() == {
         "headers": {},
         "json": {},
-        "query": {},
+        "params": {},
     }