fix(skore-hub-project/metrics): Raise exception from thread (#2296)

Since metrics compute is multi-threaded, ensure that any exceptions
thrown in a sub-thread are also thrown in the main thread.

Author: thomass-dev

skore-hub-project/src/skore_hub_project/report/report.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 from abc import ABC
-from collections import deque
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from functools import cached_property, partial
 from typing import ClassVar, Generic, TypeVar, cast
@@ -119,13 +118,12 @@ def metrics(self) -> list[Metric[Report]]:
                 for metric in metrics
             ]
 
-            deque(
-                progress.track(
-                    as_completed(tasks),
-                    description=f"Computing {self.report.__class__.__name__} metrics",
-                    total=len(tasks),
-                )
-            )
+            for task in progress.track(
+                as_completed(tasks),
+                description=f"Computing {self.report.__class__.__name__} metrics",
+                total=len(tasks),
+            ):
+                task.result()
 
         return [metric for metric in metrics if metric.value is not None]
 

skore-hub-project/tests/unit/report/test_cross_validation_report.py

@@ -338,6 +338,23 @@ def test_metrics(self, payload):
             PredictTimeTrainStd,
         ]
 
+    def test_metrics_raises_exception(self, monkeypatch, payload):
+        """
+        Since metrics compute is multi-threaded, ensure that any exceptions thrown in a
+        sub-thread are also thrown in the main thread.
+        """
+
+        def raise_exception(_):
+            raise Exception("test_metrics_raises_exception")
+
+        monkeypatch.setattr(
+            "skore_hub_project.metric.metric.CrossValidationReportMetric.compute",
+            raise_exception,
+        )
+
+        with raises(Exception, match="test_metrics_raises_exception"):
+            list(map(type, payload.metrics))
+
     @mark.filterwarnings(
         # ignore deprecation warnings generated by the way `pandas` is used by
         # `searborn`, which is a dependency of `skore`

skore-hub-project/tests/unit/report/test_estimator_report.py

@@ -122,6 +122,23 @@ def test_metrics(self, payload):
             PredictTimeTrain,
         ]
 
+    def test_metrics_raises_exception(self, monkeypatch, payload):
+        """
+        Since metrics compute is multi-threaded, ensure that any exceptions thrown in a
+        sub-thread are also thrown in the main thread.
+        """
+
+        def raise_exception(_):
+            raise Exception("test_metrics_raises_exception")
+
+        monkeypatch.setattr(
+            "skore_hub_project.metric.metric.EstimatorReportMetric.compute",
+            raise_exception,
+        )
+
+        with raises(Exception, match="test_metrics_raises_exception"):
+            list(map(type, payload.metrics))
+
     @mark.usefixtures("monkeypatch_artifact_hub_client")
     @mark.usefixtures("monkeypatch_upload_routes")
     def test_medias(self, payload):