Skip to content

Commit fb74952

Browse files
Remove outdated test
The test applies to things that have a `reports_` attribute, but in reality the only things `progress_decorator` applies to are skore.*Report and their associated Accessors.
1 parent f36df1c commit fb74952

File tree

1 file changed

+0
-38
lines changed

1 file changed

+0
-38
lines changed

skore/tests/unit/utils/test_progress_bar.py

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -125,41 +125,3 @@ def run(self):
125125

126126
# Verify progress bar was cleaned up
127127
assert task._progress_info is None
128-
129-
130-
def test_child_report_cleanup():
131-
"""Ensure that child reports in reports_ get progress assigned and then cleaned
132-
up."""
133-
134-
class Child:
135-
def __init__(self):
136-
self._progress_info = None
137-
self.called = False
138-
139-
@progress_decorator("Child Process")
140-
def process(self):
141-
self.called = True
142-
return "child_done"
143-
144-
class Parent:
145-
def __init__(self):
146-
self._progress_info = None
147-
self.reports_ = {"child1": Child(), "child2": Child()}
148-
149-
@progress_decorator("Parent Process")
150-
def run(self):
151-
results = []
152-
for rpt in self.reports_.values():
153-
results.append(rpt.process())
154-
return results
155-
156-
parent = Parent()
157-
results = parent.run()
158-
159-
assert results == ["child_done", "child_done"]
160-
assert all(rp.called for rp in parent.reports_.values())
161-
# Verify that progress attributes are cleaned for each child report
162-
for rp in parent.reports_.values():
163-
assert rp._progress_info is None
164-
# Also verify if parent reports are cleaned up as well
165-
assert parent._progress_info is None

0 commit comments

Comments
 (0)