`INSERT AFTER .comment` causes linker-error on xtensa

[t-moe]

#67 added INSERT AFTER .comment; to the bottom of embedded-test.x. This no longer compiles on xtensa, which blocks us from merging #68

cargo build
....
error: linking with `xtensa-esp32s2-elf-gcc` failed: exit status: 1
  |
  = note:  "xtensa-esp32s2-elf-gcc" <....> "-Wl,--gc-sections" "-no-pie" "-nodefaultlibs" "-nostartfiles" "-Tlinkall.x" "-Tembedded-test.x"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /home/timo/.rustup/toolchains/esp/xtensa-esp-elf/esp-14.2.0_20240906/xtensa-esp-elf/bin/../lib/gcc/xtensa-esp-elf/14.2.0/../../../../xtensa-esp-elf/bin/ld: .comment not found for insert
          collect2: error: ld returned 1 exit status

Strangly enough the .comment section is there (if I compile without -Tembedded-test.x)

$ xtensa-esp-elf-objdump -h target/xtensa-esp32s2-none-elf/debug/example |  grep -C2 .comment
 27 .debug_str    001f005b  00000000  00000000  00277d15  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
 28 .comment      0000003f  00000000  00000000  00467d70  2**0
                  CONTENTS, READONLY
 29 .debug_line   0009987a  00000000  00000000  00467daf  2**0

[kaspar030]

As the .comment fix is only needed for std builds (so a subset of the platforms), we could only add it there. E.g., use the previous embedded-test.x as default, and in build.rs only add the extra line, as part of the build.rs copy step.

[t-moe]

As the .comment fix is only needed for std builds (so a subset of the platforms), we could only add it there. E.g., use the previous embedded-test.x as default, and in build.rs only add the extra line, as part of the build.rs copy step.

We can certainly do that as a workaround, but Daniel wanted to find out the root cause....

You're still on vacation, yes?
I'll also be on vacation from next tuesday to friday...
But I would love to sort this one out, and also talk about ariel os integration blocker, so that I can release 0.7.0 before 1.9.25 if possible.
Can we discuss this on matrix next monday maybe?

[kaspar030]

You're still on vacation, yes?

I'm actually back, happy to discuss on matrix any time!

[t-moe]

I've implemented this workaround, and published as 0.7.0-alpha.2