Skip to content

Commit cb796a6

Browse files
authored
feat(mode): explicit mode selection and workflow update (#204)
* fix(action): minimal entrypoint — use GITHUB_ACTIONS to select Action vs CLI (parity with yesterday) * fix(action): allow CLI help/version/validate or --mode cli even under GITHUB_ACTIONS (keeps Action default for uses:) * test(e2e): force CLI path when VISOR_E2E_FORCE_RUN=true even under GITHUB_ACTIONS (keeps CI e2e stable) * fix(cli): treat --output json|sarif as CLI path even under GITHUB_ACTIONS (to support jq parsing in CI) * fix(cli): honor --cli flag at entrypoint to force CLI path (fixes markdown output test) * fix(otel): no-op tracer.startActiveSpan supports v1/v2 overloads and always invokes callback\n\nWhen OpenTelemetry isn't installed, lazy-otel provided a no-op tracer with a startActiveSpan signature that didn't handle the (name, options, callback) overload.\nThis could prevent the span callback from running under certain paths.\n\nImplement a robust no-op startActiveSpan that accepts all overloads and invokes the callback with a no-op span.\nThis ensures provider execution inside withActiveSpan actually runs in non-OTel environments (e.g., GH Actions without OTel). * feat(mode): rely on explicit --mode or Action input 'mode'; default to 'cli'; update internal PR review workflow to pass mode=github-actions\n\n- Entry point no longer depends on GITHUB_ACTIONS heuristic; --mode flag or core.getInput('mode') decides.\n- Keeps shorthand --cli for convenience.\n- Updated .github/workflows/pr-review.yml to pass mode: github-actions explicitly.\n- Dist rebuilt.
1 parent bcda4d8 commit cb796a6

File tree

4 files changed

+1051
-7830
lines changed

4 files changed

+1051
-7830
lines changed

.github/workflows/pr-review.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ jobs:
5454
id: visor_review
5555
uses: ./
5656
with:
57+
mode: github-actions
5758
app-id: ${{ secrets.APP_ID }}
5859
private-key: ${{ secrets.APP_PRIVATE_KEY }}
5960
installation-id: ${{ secrets.APP_INSTALLATION_ID }}

dist/generated/config-schema.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)