Revert "fix: avoid double logging of connection error (#391)"

This reverts commit cb7f51b.

Author: wolfy1339

index.ts

@@ -29,11 +29,7 @@ class SmeeClient {
 
 <<<<<<< HEAD
   #onerror: (err: ErrorEvent) => void = (err) => {
-    if (this.#events?.readyState === EventSource.CLOSED) {
-      this.#logger.error("Connection closed");
-    } else {
-      this.#logger.error("Error in connection", err);
-    }
+    this.#logger.error("Error in connection", err);
   };
 =======
   constructor({
@@ -133,12 +129,21 @@ class SmeeClient {
 
 <<<<<<< HEAD
     const connected = new Promise<void>((resolve, reject) => {
+      const onError = (err: ErrorEvent) => {
+        if (events.readyState === EventSource.CLOSED) {
+          this.#logger.error("Connection closed");
+        } else {
+          this.#logger.error("Error in connection", err);
+        }
+        reject(err);
+      };
+
       events.addEventListener("open", () => {
         this.#logger.info(`Connected to ${this.#source}`);
-        events.removeEventListener("error", reject);
+        events.removeEventListener("error", onError);
         resolve();
       });
-      events.addEventListener("error", reject);
+      events.addEventListener("error", onError);
     });
 
     this.#events = events;

test/connection-error.test.ts

@@ -5,7 +5,6 @@ import { VoidLogger } from "./helpers/void-logger.ts";
 import { WebhookServer } from "./helpers/webhook-server.ts";
 
 import SmeeClient from "../index.ts";
-import { randomInt } from "node:crypto";
 
 describe("connection", () => {
   test("should emit an error if the server closes connection unexpectedly", async () => {
@@ -53,25 +52,4 @@ describe("connection", () => {
     await smeeClient.stop();
     await webhookServer.stop();
   });
-
-  test("logs an error when the server is not found", async () => {
-    const domain = "bad.n" + randomInt(1e10).toString(36) + ".proxy";
-    const url = `http://${domain}/events`;
-
-    const logger = new VoidLogger();
-
-    try {
-      const smeeClient = new SmeeClient({
-        source: url,
-        target: "http://localhost:3000",
-        logger,
-      });
-      await smeeClient.start();
-      throw new Error("Expected an error to be thrown");
-    } catch (error: any) {
-      expect(logger.errorCalls.length).toBe(1);
-      expect(logger.errorCalls[0].length).toBe(2);
-      expect(logger.errorCalls[0][0]).toBe("Error in connection");
-    }
-  });
 });